3828 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Fabro	c14e1bdda3	fabro(01KT9X0N42W6PRBVH2N5914EQJ): check_review (succeeded) ... Fabro-Run: 01KT9X0N42W6PRBVH2N5914EQJ Fabro-Completed: 19 Fabro-Checkpoint: 54bb63fba7 ⚒️ Generated with [Fabro](https://fabro.sh)	2026-06-04 18:45:40 +00:00
Fabro	7ae5e84eee	fabro(01KT9X0N42W6PRBVH2N5914EQJ): review (succeeded) ... Fabro-Run: 01KT9X0N42W6PRBVH2N5914EQJ Fabro-Completed: 18 Fabro-Checkpoint: 02b08360fb ⚒️ Generated with [Fabro](https://fabro.sh)	2026-06-04 18:45:30 +00:00
Fabro	717c29e87a	fabro(01KT9X0N42W6PRBVH2N5914EQJ): check_integration (succeeded) ... Fabro-Run: 01KT9X0N42W6PRBVH2N5914EQJ Fabro-Completed: 17 Fabro-Checkpoint: e9123c270d ⚒️ Generated with [Fabro](https://fabro.sh)	2026-06-04 18:43:57 +00:00
Fabro	a8d8a942de	fabro(01KT9X0N42W6PRBVH2N5914EQJ): verify_integration (succeeded) ... Fabro-Run: 01KT9X0N42W6PRBVH2N5914EQJ Fabro-Completed: 16 Fabro-Checkpoint: 924c70232f ⚒️ Generated with [Fabro](https://fabro.sh)	2026-06-04 18:43:51 +00:00
Fabro	a08bed06e1	fabro(01KT9X0N42W6PRBVH2N5914EQJ): impl_integration (succeeded) ... Fabro-Run: 01KT9X0N42W6PRBVH2N5914EQJ Fabro-Completed: 15 Fabro-Checkpoint: 1c3d6d6c0e ⚒️ Generated with [Fabro](https://fabro.sh)	2026-06-04 18:42:53 +00:00
Fabro	288709fcfa	fabro(01KT9X0N42W6PRBVH2N5914EQJ): check_ui (succeeded) ... Fabro-Run: 01KT9X0N42W6PRBVH2N5914EQJ Fabro-Completed: 14 Fabro-Checkpoint: 6a0d9e9830 ⚒️ Generated with [Fabro](https://fabro.sh)	2026-06-04 18:37:32 +00:00
Fabro	cb9a9295f6	fabro(01KT9X0N42W6PRBVH2N5914EQJ): verify_ui (succeeded) ... Fabro-Run: 01KT9X0N42W6PRBVH2N5914EQJ Fabro-Completed: 13 Fabro-Checkpoint: ff7eed2c23 ⚒️ Generated with [Fabro](https://fabro.sh)	2026-06-04 18:37:21 +00:00
Fabro	7ec1f948aa	fabro(01KT9X0N42W6PRBVH2N5914EQJ): impl_ui (succeeded) ... Fabro-Run: 01KT9X0N42W6PRBVH2N5914EQJ Fabro-Completed: 12 Fabro-Checkpoint: 75d4b4937b ⚒️ Generated with [Fabro](https://fabro.sh)	2026-06-04 18:34:57 +00:00
Fabro	8522a2b165	fabro(01KT9X0N42W6PRBVH2N5914EQJ): check_logic (succeeded) ... Fabro-Run: 01KT9X0N42W6PRBVH2N5914EQJ Fabro-Completed: 11 Fabro-Checkpoint: 7460236b53 ⚒️ Generated with [Fabro](https://fabro.sh)	2026-06-04 18:29:52 +00:00
Fabro	757a5687d7	fabro(01KT9X0N42W6PRBVH2N5914EQJ): verify_logic (succeeded) ... Fabro-Run: 01KT9X0N42W6PRBVH2N5914EQJ Fabro-Completed: 10 Fabro-Checkpoint: 55b78d6bfa ⚒️ Generated with [Fabro](https://fabro.sh)	2026-06-04 18:29:42 +00:00
Fabro	8b8225ec6b	fabro(01KT9X0N42W6PRBVH2N5914EQJ): impl_logic (succeeded) ... Fabro-Run: 01KT9X0N42W6PRBVH2N5914EQJ Fabro-Completed: 9 Fabro-Checkpoint: 6074fbdf55 ⚒️ Generated with [Fabro](https://fabro.sh)	2026-06-04 18:27:55 +00:00
Fabro	ad7c3293d7	fabro(01KT9X0N42W6PRBVH2N5914EQJ): check_data (succeeded) ... Fabro-Run: 01KT9X0N42W6PRBVH2N5914EQJ Fabro-Completed: 8 Fabro-Checkpoint: 83a52bd963 ⚒️ Generated with [Fabro](https://fabro.sh)	2026-06-04 18:24:30 +00:00
Fabro	d4ccadfbda	fabro(01KT9X0N42W6PRBVH2N5914EQJ): verify_data (succeeded) ... Fabro-Run: 01KT9X0N42W6PRBVH2N5914EQJ Fabro-Completed: 7 Fabro-Checkpoint: 5042c7820e ⚒️ Generated with [Fabro](https://fabro.sh)	2026-06-04 18:24:19 +00:00
Fabro	ce5b1ccdc9	fabro(01KT9X0N42W6PRBVH2N5914EQJ): impl_data (succeeded) ... Fabro-Run: 01KT9X0N42W6PRBVH2N5914EQJ Fabro-Completed: 6 Fabro-Checkpoint: ddf1cc7819 ⚒️ Generated with [Fabro](https://fabro.sh)	2026-06-04 18:22:44 +00:00
Fabro	2f56c52495	fabro(01KT9X0N42W6PRBVH2N5914EQJ): check_setup (succeeded) ... Fabro-Run: 01KT9X0N42W6PRBVH2N5914EQJ Fabro-Completed: 5 Fabro-Checkpoint: 4be5ee1dba ⚒️ Generated with [Fabro](https://fabro.sh)	2026-06-04 18:19:08 +00:00
Fabro	e36ce2d2b6	fabro(01KT9X0N42W6PRBVH2N5914EQJ): verify_setup (succeeded) ... Fabro-Run: 01KT9X0N42W6PRBVH2N5914EQJ Fabro-Completed: 4 Fabro-Checkpoint: 094dc47722 ⚒️ Generated with [Fabro](https://fabro.sh)	2026-06-04 18:19:02 +00:00
Fabro	15fffe6b88	fabro(01KT9X0N42W6PRBVH2N5914EQJ): impl_setup (succeeded) ... Fabro-Run: 01KT9X0N42W6PRBVH2N5914EQJ Fabro-Completed: 3 Fabro-Checkpoint: 318fc6b17d ⚒️ Generated with [Fabro](https://fabro.sh)	2026-06-04 18:17:50 +00:00
Fabro	df1e9e39f6	fabro(01KT9X0N42W6PRBVH2N5914EQJ): expand_spec (succeeded) ... Fabro-Run: 01KT9X0N42W6PRBVH2N5914EQJ Fabro-Completed: 2 Fabro-Checkpoint: 0061c285b6 ⚒️ Generated with [Fabro](https://fabro.sh)	2026-06-04 18:10:34 +00:00
Bryan Helmkamp	497aaba6f2	Bump version to 0.254.0	2026-06-04 08:51:34 -04:00
fabro-releases[bot]	84d9f282ab	Bump version to 0.254.0-nightly.0	2026-06-04 10:33:58 +00:00
Bryan Helmkamp	1c4c264bec	fix(web): allow noVNC iframe storage	2026-06-03 12:01:27 -04:00
Bryan Helmkamp	d8c16e5396	fix(web): distinguish automations empty states ... The automations page collapsed loading, no-automations, and no-search- match into a single branch that always rendered `No automations match "{query}"`. With an empty query that read `No automations match ""`, which also flashed during the initial fetch and when the trigger filter (not the search) excluded everything. Split into loading / error / true-empty / no-match states using the shared EmptyState/ErrorState/LoadingState components. The true-empty state is now a "Create your first automation" panel with a primary CTA, and the search/filter toolbar is hidden when there is nothing to filter. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-03 08:29:24 -04:00
fabro-releases[bot]	d132b96fe7	Bump version to 0.253.0-nightly.0	2026-06-03 10:49:54 +00:00
Bryan Helmkamp	f69677cf82	Bump version to 0.252.0	2026-06-02 20:45:09 -04:00
fabro-releases[bot]	083bbf8b30	Bump version to 0.252.0-nightly.0	2026-06-02 23:27:41 +00:00
Bryan Helmkamp	ccbc62ea5d	fix(ci): restore Rust checks	2026-06-02 19:05:08 -04:00
Bryan Helmkamp	e952bb4c7f	fix(config): disable Slack unless configured ... Require an explicit server.integrations.slack table before Slack reports enabled or starts from vault tokens.	2026-06-02 18:41:36 -04:00
Bryan Helmkamp	160f587a1d	feat(install): enable only allowed sandbox providers ... Add an "Allow local sandboxes" checkbox (checked by default) below the Docker/Daytona choice in the web installer, and stop unconditionally enabling all three providers when generating settings.toml. The wizard now enables only the selected runtime plus local when allowed; the unselected runtime is written as `enabled = false` so the config resolver does not default it back on. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-02 18:39:31 -04:00
fabro-releases[bot]	f76d191a48	Bump version to 0.251.0-nightly.1	2026-06-01 23:57:37 +00:00
Bryan Helmkamp	efbd2d02e0	chore(server): switch CSP to report-only while tuning ... Emit the policy via Content-Security-Policy-Report-Only instead of the enforcing header so browsers log violations without blocking resources while we debug remaining CSP issues. The policy string is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-01 19:42:39 -04:00
Bryan Helmkamp	b3528a982e	chore: update CSP	2026-06-01 19:42:39 -04:00
fabro-releases[bot]	0f3ef1c63d	Bump version to 0.251.0-nightly.0	2026-06-01 22:40:10 +00:00
Bryan Helmkamp	3e881e9938	fix(server): allow required CSP handoffs ... Permit GitHub App manifest form posts and signed HTTPS VNC preview iframes while keeping the rest of the SPA CSP locked down. Mirror the policy in the split-web Caddy config.	2026-06-01 18:24:45 -04:00
Bryan Helmkamp	4a156d5551	feat(web): add Workflows settings nav section ... Group Variables and Secrets under a new "Workflows" nav section between General and Administration, and move Security under Administration next to Server. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-01 18:19:09 -04:00
fabro-releases[bot]	228387e53b	Bump version to 0.250.0-nightly.0	2026-05-31 10:07:23 +00:00
Bryan Helmkamp	b5de404354	ci: lock Cargo resolution and fix cancellation flake (#461) ... ## Summary Enforce Cargo lockfile use across CI and release automation so jobs fail on stale `Cargo.lock` state instead of resolving dependencies implicitly. This adds `--locked` to Rust CI, release builds/tests, nightly release tagging, the TypeScript workflow's embedded Rust build, and helper-owned Cargo calls in `fabro-dev`. This also fixes the Linux CI flake exposed by the PR: canceling a durably blocked in-process run could take the abort path while the workflow was still unwinding a human-input gate, causing `run.failed(cancelled)` to be followed by `run.unblocked`. That invalid event order broke projection rebuilds and made `GET /runs/{id}` return 404. Cancellation now uses the durable lifecycle status when selecting the in-process blocked-run path, so the pending interview is cancelled before the terminal event is emitted. The release command's intentional `cargo update --workspace` step is unchanged, because that step updates `Cargo.lock` after bumping the workspace version. ## Testing - `cargo nextest run --locked -p fabro-dev --features dev -E 'test(dry_run_computes_stable_version_from_date) | test(dry_run_prints_equivalent_build_commands)'` - `cargo --locked dev release --dry-run --skip-tests --release-date 2026-01-01` - `cargo --locked dev docs check` - `cargo nextest run --locked -p fabro-server --features test-support cancel_durably_blocked_in_process_run_cancels_pending_interview_without_abort_signal --status-level fail --final-status-level fail --show-progress none` - `cargo nextest run --locked -p fabro-server --features test-support --test it scenario::lifecycle --profile ci --status-level fail --final-status-level fail --show-progress none --no-fail-fast` - Linux Docker stress reproduction: `cargo nextest run --locked -p fabro-server --features test-support --test it scenario::lifecycle::full_http_lifecycle_cancel --profile ci --stress-count 200 --status-level fail --final-status-level fail --show-progress none` - `cargo +nightly-2026-04-14 fmt --check --all` - `cargo +nightly-2026-04-14 clippy --locked -p fabro-dev --features dev --all-targets -- -D warnings` - `cargo +nightly-2026-04-14 clippy --locked -p fabro-server --features test-support --all-targets -- -D warnings` - `git diff --check` Full `cargo nextest run --locked -p fabro-dev --features dev` currently has two unrelated policy-test failures: `policy::catalog_builtin_references_stay_in_allowlist` and `policy::workflow_template_rendering_call_sites_stay_in_allowlist`. --- [](https://github.com/EveryInc/compound-engineering-plugin) 🤖 Generated with GPT-5 via [Codex](https://openai.com/codex) --------- Co-authored-by: Release Repro <release-repro@example.com>	2026-05-30 15:07:41 -04:00
fabro-sh-0530[bot]	1184e25eab	Fix double-disabled condition on automation run button (#460) ... The run button's `disabled` prop previously checked `running` twice — once via `runDisabled` and again directly on `disabled={running || runDisabled}`. This consolidates the `running` check into `runDisabled` and removes the redundant inline check. ### Fabro Details <details> <summary>Ran 8 stages in 28m 43s for $8.28</summary> | Stage | Duration | Cost | Retries | |---|---|---|---| | start | 0s | – | 0 | | toolchain | 1s | – | 0 | | preflight_compile | 2m 5s | – | 0 | | preflight_lint | 2m 22s | – | 0 | | implement | 9m 24s | $6.20 | 0 | | simplify_opus | 3m 42s | $1.23 | 0 | | simplify_gpt | 1m 29s | $0.85 | 0 | | verify | 9m 10s | – | 0 | | **Total** | **28m 43s** | **$8.28** | **0** | </details> <details> <summary>Ran <code>ImplementPlan.fabro</code> (11 nodes and 14 edges)</summary> ```dot digraph ImplementPlan { graph [ goal="Implement and simplify", model_stylesheet=" * { model: claude-opus-4-7; } " ] rankdir=LR start [shape=Mdiamond, label="Start"] exit [shape=Msquare, label="Exit"] toolchain [label="Toolchain", shape=parallelogram, script="command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1", max_retries=0] preflight_compile [label="Preflight Compile", shape=parallelogram, script="cargo check -q --workspace 2>&1", max_retries=0] preflight_lint [label="Preflight Lint", shape=parallelogram, script="cargo +nightly-2026-04-14 clippy -q --workspace --all-targets -- -D warnings 2>&1", max_retries=0] fix_lints [label="Fix Lints", prompt="The preflight lint step failed. Read the build output from context and fix all clippy lint warnings.", max_visits=3] implement [label="Implement", prompt="Read the plan file referenced in the goal and implement every step. Make all the code changes described in the plan. Use red/green TDD.", model="gpt-55", reasoning_effort="xhigh"] simplify_opus [label="Simplify (Opus)", prompt="@prompts/simplify.md"] simplify_gpt [label="Simplify (GPT-55)", prompt="@prompts/simplify.md", model="gpt-55"] verify [label="Verify", shape=parallelogram, script="git fetch origin main 2>&1 && git merge --no-edit --no-stat origin/main 2>&1 && cargo +nightly-2026-04-14 fmt --all 2>&1 && cargo dev docs refresh 2>&1 && cargo +nightly-2026-04-14 fmt --check --all 2>&1 && { command -v rg >/dev/null 2>&1 || { echo 'rg is required for verify'; exit 127; }; } && ! rg -n 'AuthMode::Disabled|RunAuthMethod|RunSubjectProvenance|\bActorRef\b|\bActorKind\b|AuthenticatedSubject|AuthenticatedService|AuthorizeRunScoped|AuthorizeRunBlob|AuthorizeStageArtifact|AuthorizeCommandLog|auth_method\s*==\s*\"disabled\"' lib/crates apps lib/packages docs/public/api-reference/fabro-api.yaml 2>&1 && cargo +nightly-2026-04-14 clippy --workspace --all-targets -- -D warnings 2>&1 && cargo nextest run --workspace --status-level slow --profile ci 2>&1 && cargo dev docs check 2>&1 && bun install --frozen-lockfile 2>&1 && (cd apps/fabro-web && bun run typecheck) 2>&1 && (cd apps/fabro-web && bun run test) 2>&1 && (cd lib/packages/fabro-api-client && bun run typecheck) 2>&1 && cargo dev build -- -p fabro-cli --release 2>&1", goal_gate=true, retry_target="fixup"] fixup [label="Fixup", prompt="The verify step failed. Read the build output from context and fix all format, clippy, Rust test, docs, TypeScript typecheck/test, and build failures.", max_visits=3] start -> toolchain toolchain -> preflight_compile [condition="outcome=succeeded"] toolchain -> exit preflight_compile -> preflight_lint [condition="outcome=succeeded"] preflight_compile -> exit preflight_lint -> implement [condition="outcome=succeeded"] preflight_lint -> fix_lints fix_lints -> preflight_lint implement -> simplify_opus -> simplify_gpt -> verify verify -> exit [condition="outcome=succeeded"] verify -> fixup fixup -> verify } ``` </details> ⚒️ Generated with [Fabro](https://fabro.sh) --------- Co-authored-by: Fabro <noreply@fabro.sh>	2026-05-30 11:24:56 -04:00
Bryan Helmkamp	d7a00d52d0	fix(automation): honor schedule trigger enabled state ... Remove the stale top-level automation enabled gate from schedule filtering now that automations only carry trigger-level enabled flags.	2026-05-30 02:19:52 -04:00
fabro-sh-0530[bot]	17cae07e5a	Add scheduled automation executor with in-memory cron planner (#457) ... ## Summary Automation schedule triggers now fire automatically at their UTC cron times. A new long-lived server task (`spawn_automation_scheduler`) owns an in-memory planner that tracks one cursor per enabled schedule trigger and creates/starts a normal Fabro run whenever a cursor comes due — reusing the same materialization and run-creation path as API-triggered runs. ### Plan Summary - **Planner** (`AutomationSchedulePlanner`) — pure in-memory, no persistent state. Reconciles cursors from the live automation list on every tick; advances each due cursor _before_ spawning the fire task so a failed materialization never hot-loops. - **Executor loop** (`spawn_automation_scheduler`) — wakes on the nearest cursor due time (capped at 30 s), on automation store mutations (via `Notify`), or on shutdown. Spawns one Tokio task per due trigger so slow materializations don't block other triggers. - **Run firing** (`fire_scheduled_automation_run`) — materializes, calls `create_run_from_manifest` with `Principal::System { Engine }`, then calls `queue_run_start`. Warnings on any failure; next attempt waits for the next cron occurrence. - **Wiring** — `automation_scheduler_notify: Notify` added to `AppState`; `create_automation`, `replace_automation`, and `delete_automation` handlers call `notify_automation_scheduler()` so the planner reacts immediately to changes. - **Visibility widening** — `handler/lifecycle.rs` (`queue_run_start`) and `handler/mod.rs` (`lifecycle`) promoted from `pub(super)` to `pub(in crate::server)` so the scheduler (a sibling of `handler`) can call the same start path. - **Shared cron parser** — `parse_schedule_expression` extracted to `fabro-automation` and re-exported so both validation and the scheduler use the same parser configuration (no seconds, no year). ### Key design decisions | Decision | Rationale | |---|---| | Cursor advances before fire task spawns | Guarantees at-most-one attempt per occurrence even if materialization panics | | No backfill on startup | Matches locked spec; `next_occurrence(expr, now)` always starts from the current time | | `Principal::System { Engine }` for actor | Avoids adding new public enum variants or OpenAPI surface | | `automation_temp_root()` extracted to `AppState` | Removes duplicated `Storage::new(…).scratch_dir().join("automations")` from the automations handler | | Tests use `run_due_schedules_once` helper | Drives the planner directly with fixed `DateTime<Utc>` values; no wall-clock sleeps in tests | ### Fabro Details <details> <summary>Ran 9 stages in 60m 12s for $22.11</summary> | Stage | Duration | Cost | Retries | |---|---|---|---| | start | 0s | – | 0 | | toolchain | 1s | – | 0 | | preflight_compile | 2m 9s | – | 0 | | preflight_lint | 2m 26s | – | 0 | | implement | 20m 14s | $12.44 | 0 | | simplify_opus | 12m 29s | $6.34 | 0 | | simplify_gpt | 3m 53s | $2.79 | 0 | | verify | 11m 5s | – | 0 | | fixup | 6m 46s | $0.54 | 0 | | **Total** | **60m 12s** | **$22.11** | **0** | </details> <details> <summary>Ran <code>ImplementPlan.fabro</code> (11 nodes and 14 edges)</summary> ```dot digraph ImplementPlan { graph [ goal="Implement and simplify", model_stylesheet=" * { model: claude-opus-4-7; } " ] rankdir=LR start [shape=Mdiamond, label="Start"] exit [shape=Msquare, label="Exit"] toolchain [label="Toolchain", shape=parallelogram, script="command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1", max_retries=0] preflight_compile [label="Preflight Compile", shape=parallelogram, script="cargo check -q --workspace 2>&1", max_retries=0] preflight_lint [label="Preflight Lint", shape=parallelogram, script="cargo +nightly-2026-04-14 clippy -q --workspace --all-targets -- -D warnings 2>&1", max_retries=0] fix_lints [label="Fix Lints", prompt="The preflight lint step failed. Read the build output from context and fix all clippy lint warnings.", max_visits=3] implement [label="Implement", prompt="Read the plan file referenced in the goal and implement every step. Make all the code changes described in the plan. Use red/green TDD.", model="gpt-55", reasoning_effort="xhigh"] simplify_opus [label="Simplify (Opus)", prompt="@prompts/simplify.md"] simplify_gpt [label="Simplify (GPT-55)", prompt="@prompts/simplify.md", model="gpt-55"] verify [label="Verify", shape=parallelogram, script="git fetch origin main 2>&1 && git merge --no-edit --no-stat origin/main 2>&1 && cargo +nightly-2026-04-14 fmt --all 2>&1 && cargo dev docs refresh 2>&1 && cargo +nightly-2026-04-14 fmt --check --all 2>&1 && { command -v rg >/dev/null 2>&1 || { echo 'rg is required for verify'; exit 127; }; } && ! rg -n 'AuthMode::Disabled|RunAuthMethod|RunSubjectProvenance|\bActorRef\b|\bActorKind\b|AuthenticatedSubject|AuthenticatedService|AuthorizeRunScoped|AuthorizeRunBlob|AuthorizeStageArtifact|AuthorizeCommandLog|auth_method\s*==\s*\"disabled\"' lib/crates apps lib/packages docs/public/api-reference/fabro-api.yaml 2>&1 && cargo +nightly-2026-04-14 clippy --workspace --all-targets -- -D warnings 2>&1 && cargo nextest run --workspace --status-level slow --profile ci 2>&1 && cargo dev docs check 2>&1 && bun install --frozen-lockfile 2>&1 && (cd apps/fabro-web && bun run typecheck) 2>&1 && (cd apps/fabro-web && bun run test) 2>&1 && (cd lib/packages/fabro-api-client && bun run typecheck) 2>&1 && cargo dev build -- -p fabro-cli --release 2>&1", goal_gate=true, retry_target="fixup"] fixup [label="Fixup", prompt="The verify step failed. Read the build output from context and fix all format, clippy, Rust test, docs, TypeScript typecheck/test, and build failures.", max_visits=3] start -> toolchain toolchain -> preflight_compile [condition="outcome=succeeded"] toolchain -> exit preflight_compile -> preflight_lint [condition="outcome=succeeded"] preflight_compile -> exit preflight_lint -> implement [condition="outcome=succeeded"] preflight_lint -> fix_lints fix_lints -> preflight_lint implement -> simplify_opus -> simplify_gpt -> verify verify -> exit [condition="outcome=succeeded"] verify -> fixup fixup -> verify } ``` </details> ⚒️ Generated with [Fabro](https://fabro.sh) --------- Co-authored-by: Fabro <noreply@fabro.sh>	2026-05-29 22:19:47 -04:00
fabro-sh-0530[bot]	fe1d33c041	Remove top-level automation enabled master gate (#456) ... The top-level `enabled` flag on automations created a confusing two-level activation model (automation-level + trigger-level). Since automations are brand new with no existing data to migrate, the master gate is removed entirely — trigger-level `enabled` is now the sole activation control. ## What changed **Domain model (`fabro-automation`):** `enabled` removed from `Automation`, `AutomationDraft`, `AutomationReplace`, and `PersistedAutomation`. `enabled_api_trigger()` no longer short-circuits on the automation flag. The `default_true()` helper is gone. A new test asserts that TOML with a top-level `enabled` key is rejected (no silent compatibility path). **Server handler:** Conflict detail updated from `"automation is disabled or has no enabled API trigger"` → `"automation has no enabled API trigger"`. The `disabled_automation_run_endpoint_returns_conflict_code` test is deleted; the trigger-disabled and missing-trigger tests remain as the authoritative inactive-run coverage. **OpenAPI + generated clients:** `enabled` removed from `Automation`, `CreateAutomationRequest`, and `ReplaceAutomationRequest` schemas and from the generated TypeScript interfaces. Trigger-level `enabled` on `AutomationApiTrigger` and `AutomationScheduleTrigger` is untouched. **Web UI:** `AutomationFormValues.enabled` and the "Enabled" toggle row are gone. `isFormValid` no longer requires at least one enabled trigger. `canRun` in the detail view is now just `apiTrigger?.enabled === true`. The `StatusChip` component is removed. The automations list uses a new `apiEnabled` field (derived from `hasEnabledApiTrigger`) to drive run-button state and tooltip copy. A shared `lib/automation.ts` helper centralises `findApiTrigger`, `findScheduleTrigger`, and `hasEnabledApiTrigger` to avoid repeated inline `.find()` calls across routes. ### Fabro Details <details> <summary>Ran 8 stages in 41m 34s for $17.84</summary> | Stage | Duration | Cost | Retries | |---|---|---|---| | start | 0s | – | 0 | | toolchain | 1s | – | 0 | | preflight_compile | 2m 15s | – | 0 | | preflight_lint | 2m 25s | – | 0 | | implement | 13m 0s | $9.25 | 0 | | simplify_opus | 9m 43s | $6.18 | 0 | | simplify_gpt | 3m 56s | $2.41 | 0 | | verify | 9m 17s | – | 0 | | **Total** | **41m 34s** | **$17.84** | **0** | </details> <details> <summary>Ran <code>ImplementPlan.fabro</code> (11 nodes and 14 edges)</summary> ```dot digraph ImplementPlan { graph [ goal="Implement and simplify", model_stylesheet=" * { model: claude-opus-4-7; } " ] rankdir=LR start [shape=Mdiamond, label="Start"] exit [shape=Msquare, label="Exit"] toolchain [label="Toolchain", shape=parallelogram, script="command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1", max_retries=0] preflight_compile [label="Preflight Compile", shape=parallelogram, script="cargo check -q --workspace 2>&1", max_retries=0] preflight_lint [label="Preflight Lint", shape=parallelogram, script="cargo +nightly-2026-04-14 clippy -q --workspace --all-targets -- -D warnings 2>&1", max_retries=0] fix_lints [label="Fix Lints", prompt="The preflight lint step failed. Read the build output from context and fix all clippy lint warnings.", max_visits=3] implement [label="Implement", prompt="Read the plan file referenced in the goal and implement every step. Make all the code changes described in the plan. Use red/green TDD.", model="gpt-55", reasoning_effort="xhigh"] simplify_opus [label="Simplify (Opus)", prompt="@prompts/simplify.md"] simplify_gpt [label="Simplify (GPT-55)", prompt="@prompts/simplify.md", model="gpt-55"] verify [label="Verify", shape=parallelogram, script="git fetch origin main 2>&1 && git merge --no-edit --no-stat origin/main 2>&1 && cargo +nightly-2026-04-14 fmt --all 2>&1 && cargo dev docs refresh 2>&1 && cargo +nightly-2026-04-14 fmt --check --all 2>&1 && { command -v rg >/dev/null 2>&1 || { echo 'rg is required for verify'; exit 127; }; } && ! rg -n 'AuthMode::Disabled|RunAuthMethod|RunSubjectProvenance|\bActorRef\b|\bActorKind\b|AuthenticatedSubject|AuthenticatedService|AuthorizeRunScoped|AuthorizeRunBlob|AuthorizeStageArtifact|AuthorizeCommandLog|auth_method\s*==\s*\"disabled\"' lib/crates apps lib/packages docs/public/api-reference/fabro-api.yaml 2>&1 && cargo +nightly-2026-04-14 clippy --workspace --all-targets -- -D warnings 2>&1 && cargo nextest run --workspace --status-level slow --profile ci 2>&1 && cargo dev docs check 2>&1 && bun install --frozen-lockfile 2>&1 && (cd apps/fabro-web && bun run typecheck) 2>&1 && (cd apps/fabro-web && bun run test) 2>&1 && (cd lib/packages/fabro-api-client && bun run typecheck) 2>&1 && cargo dev build -- -p fabro-cli --release 2>&1", goal_gate=true, retry_target="fixup"] fixup [label="Fixup", prompt="The verify step failed. Read the build output from context and fix all format, clippy, Rust test, docs, TypeScript typecheck/test, and build failures.", max_visits=3] start -> toolchain toolchain -> preflight_compile [condition="outcome=succeeded"] toolchain -> exit preflight_compile -> preflight_lint [condition="outcome=succeeded"] preflight_compile -> exit preflight_lint -> implement [condition="outcome=succeeded"] preflight_lint -> fix_lints fix_lints -> preflight_lint implement -> simplify_opus -> simplify_gpt -> verify verify -> exit [condition="outcome=succeeded"] verify -> fixup fixup -> verify } ``` </details> ⚒️ Generated with [Fabro](https://fabro.sh) --------- Co-authored-by: Fabro <noreply@fabro.sh>	2026-05-29 22:18:14 -04:00
fabro-sh-0530[bot]	a65473f216	Add "Create automation from run" prefill flow (#454) ... ## Summary Adds a frontend-only flow that lets users bootstrap a new automation from an existing run's metadata. The run actions menu grows a context-aware entry: ordinary runs get **Create automation from run** (navigates to `/automations/new?from_run=<id>`); runs already tied to an automation get **View automation** instead. The `/automations/new` route reads the query param, loads the run + settings, and mounts a keyed form child pre-populated with the inferred values — no `useEffect` needed. ### Plan Summary - **`automation-form.tsx`** — new exported `automationFormValuesFromRun(run, settings)` helper plus three narrow private parsers (`githubRepositoryFromSettings`, `githubRepositoryName`, `githubRepositoryFromOriginUrl`) that only produce `owner/repo` for verifiable GitHub-style values and leave everything else blank. - **`automations-new.tsx`** — route split into a wrapper that reads `from_run`, calls `useRun`/`useRunSettings`, and either shows a loading placeholder, a graceful error fallback, or a keyed `<AutomationCreateForm>` so initial state is set once from props rather than via effects. - **`run-detail.tsx`** — `automationAction` computed from `summary.automation?.id` and inserted into the `operations` group after Preview. - **Tests** — new `automations-new.test.tsx` covers empty form, prefill, and error-fallback paths; `run-detail.test.ts` extended with automation navigation assertions and refactored `makeRunSummary` to accept named params. ### Key design decisions | Decision | Rationale | |---|---| | Keyed child form (`key={`from-run:${id}`}`) | Lets React reset `useState` from props without `useEffect`, per the effects policy | | Wait for both queries before mounting | Prevents edits being overwritten when settings arrive after the run | | GitHub-only repository parsing | Narrow match avoids silently populating wrong values for non-GitHub or unknown providers | | No schedule inference | Prefilled automations default to manual/API trigger enabled, schedule disabled | | Navigation-only action | No disabled states for terminal/demo runs — it's just a link | ### Fabro Details <details> <summary>Ran 8 stages in 31m 21s for $11.39</summary> | Stage | Duration | Cost | Retries | |---|---|---|---| | start | 0s | – | 0 | | toolchain | 6s | – | 0 | | preflight_compile | 2m 11s | – | 0 | | preflight_lint | 2m 31s | – | 0 | | implement | 10m 10s | $7.83 | 0 | | simplify_opus | 4m 23s | $2.16 | 0 | | simplify_gpt | 1m 34s | $1.40 | 0 | | verify | 9m 42s | – | 0 | | **Total** | **31m 21s** | **$11.39** | **0** | </details> <details> <summary>Ran <code>ImplementPlan.fabro</code> (11 nodes and 14 edges)</summary> ```dot digraph ImplementPlan { graph [ goal="Implement and simplify", model_stylesheet=" * { model: claude-opus-4-7; } " ] rankdir=LR start [shape=Mdiamond, label="Start"] exit [shape=Msquare, label="Exit"] toolchain [label="Toolchain", shape=parallelogram, script="command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1", max_retries=0] preflight_compile [label="Preflight Compile", shape=parallelogram, script="cargo check -q --workspace 2>&1", max_retries=0] preflight_lint [label="Preflight Lint", shape=parallelogram, script="cargo +nightly-2026-04-14 clippy -q --workspace --all-targets -- -D warnings 2>&1", max_retries=0] fix_lints [label="Fix Lints", prompt="The preflight lint step failed. Read the build output from context and fix all clippy lint warnings.", max_visits=3] implement [label="Implement", prompt="Read the plan file referenced in the goal and implement every step. Make all the code changes described in the plan. Use red/green TDD.", model="gpt-55", reasoning_effort="xhigh"] simplify_opus [label="Simplify (Opus)", prompt="@prompts/simplify.md"] simplify_gpt [label="Simplify (GPT-55)", prompt="@prompts/simplify.md", model="gpt-55"] verify [label="Verify", shape=parallelogram, script="git fetch origin main 2>&1 && git merge --no-edit --no-stat origin/main 2>&1 && cargo +nightly-2026-04-14 fmt --all 2>&1 && cargo dev docs refresh 2>&1 && cargo +nightly-2026-04-14 fmt --check --all 2>&1 && { command -v rg >/dev/null 2>&1 || { echo 'rg is required for verify'; exit 127; }; } && ! rg -n 'AuthMode::Disabled|RunAuthMethod|RunSubjectProvenance|\bActorRef\b|\bActorKind\b|AuthenticatedSubject|AuthenticatedService|AuthorizeRunScoped|AuthorizeRunBlob|AuthorizeStageArtifact|AuthorizeCommandLog|auth_method\s*==\s*\"disabled\"' lib/crates apps lib/packages docs/public/api-reference/fabro-api.yaml 2>&1 && cargo +nightly-2026-04-14 clippy --workspace --all-targets -- -D warnings 2>&1 && cargo nextest run --workspace --status-level slow --profile ci 2>&1 && cargo dev docs check 2>&1 && bun install --frozen-lockfile 2>&1 && (cd apps/fabro-web && bun run typecheck) 2>&1 && (cd apps/fabro-web && bun run test) 2>&1 && (cd lib/packages/fabro-api-client && bun run typecheck) 2>&1 && cargo dev build -- -p fabro-cli --release 2>&1", goal_gate=true, retry_target="fixup"] fixup [label="Fixup", prompt="The verify step failed. Read the build output from context and fix all format, clippy, Rust test, docs, TypeScript typecheck/test, and build failures.", max_visits=3] start -> toolchain toolchain -> preflight_compile [condition="outcome=succeeded"] toolchain -> exit preflight_compile -> preflight_lint [condition="outcome=succeeded"] preflight_compile -> exit preflight_lint -> implement [condition="outcome=succeeded"] preflight_lint -> fix_lints fix_lints -> preflight_lint implement -> simplify_opus -> simplify_gpt -> verify verify -> exit [condition="outcome=succeeded"] verify -> fixup fixup -> verify } ``` </details> ⚒️ Generated with [Fabro](https://fabro.sh) --------- Co-authored-by: Fabro <noreply@fabro.sh>	2026-05-29 22:18:04 -04:00
fabro-sh-0530[bot]	037073d2b2	feat: Add Environment REST CRUD API under /api/v1/environments (#453) ... ## Summary Adds a server-managed Environment CRUD API at `/api/v1/environments`, modeled after the existing Automations API and backed by `EnvironmentStore`. The API manages only server-side environment definitions in `environments/*.toml`; client-side catalogs (workflow, project TOML, run inputs) are unaffected. ### Plan Summary - **OpenAPI contract**: new `Environments` tag, `EnvironmentId` path parameter, five CRUD paths, list envelope, and REST-specific inline-only image schema (`EnvironmentApiImageSettings`) - **Server handler** (`environments.rs`): mirrors `automations.rs` — auth guard, ETag/If-Match, and `EnvironmentStoreError → ApiError` mapping - **Shared handler utilities**: `parse_required_if_match` and `json_with_etag_response` extracted from `automations.rs` into `handler/mod.rs` so both modules share them - **Inline-only Dockerfile enforcement**: `ApiDockerfileSource::Path` is parsed and immediately rejected with `422`; the file is never read - **Manifest refresh**: `refresh_manifest_run_settings_from_environment_catalog()` called after create, replace, and delete so `/system/info` and default run settings stay consistent - **Client regeneration**: TypeScript Axios client regenerated with `EnvironmentsApi` and new model files; Rust `fabro-api` type aliases updated - **Tests**: integration suite in `tests/it/api/environments.rs` covering all CRUD paths, error cases, and the manifest-refresh invariant; OpenAPI conformance test verifies generated surfaces ## Key Design Decisions **Inline-only Dockerfile at the REST boundary.** Allowing `path` sources over REST would let callers silently read arbitrary server-local files into the environment catalog. The handler recognizes the `path` discriminant so it can return a descriptive `422` rather than a generic parse error, but the payload is discarded via `IgnoredAny` — no disk access occurs. **Shared ETag utilities instead of per-handler helpers.** The original `parse_required_if_match` and ETag header builder in `automations.rs` were duplicated for environments. They're now generic over any `FromStr` revision type in `handler/mod.rs`, making future resource handlers cheaper to add. **`Environment` response type aliased to domain type.** The OpenAPI-generated `Environment` response struct is replaced with `fabro_environment::Environment` via `build.rs` `with_replacement`. A compile-time function-cast witness in `fabro-api/tests/environment_round_trip.rs` confirms the alias holds. Request types (`CreateEnvironmentRequest`, `ReplaceEnvironmentRequest`) stay API-specific because their image schema differs from the workflow/settings schema. **Stale revision → `409`.** Consistent with Automations; `428` is reserved for missing `If-Match` only. ### Fabro Details <details> <summary>Ran 8 stages in 59m 23s for $30.41</summary> | Stage | Duration | Cost | Retries | |---|---|---|---| | start | 0s | – | 0 | | toolchain | 1s | – | 0 | | preflight_compile | 2m 9s | – | 0 | | preflight_lint | 2m 25s | – | 0 | | implement | 25m 43s | $19.79 | 0 | | simplify_opus | 14m 34s | $6.98 | 0 | | simplify_gpt | 4m 39s | $3.64 | 0 | | verify | 9m 14s | – | 0 | | **Total** | **59m 23s** | **$30.41** | **0** | </details> <details> <summary>Ran <code>ImplementPlan.fabro</code> (11 nodes and 14 edges)</summary> ```dot digraph ImplementPlan { graph [ goal="Implement and simplify", model_stylesheet=" * { model: claude-opus-4-7; } " ] rankdir=LR start [shape=Mdiamond, label="Start"] exit [shape=Msquare, label="Exit"] toolchain [label="Toolchain", shape=parallelogram, script="command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1", max_retries=0] preflight_compile [label="Preflight Compile", shape=parallelogram, script="cargo check -q --workspace 2>&1", max_retries=0] preflight_lint [label="Preflight Lint", shape=parallelogram, script="cargo +nightly-2026-04-14 clippy -q --workspace --all-targets -- -D warnings 2>&1", max_retries=0] fix_lints [label="Fix Lints", prompt="The preflight lint step failed. Read the build output from context and fix all clippy lint warnings.", max_visits=3] implement [label="Implement", prompt="Read the plan file referenced in the goal and implement every step. Make all the code changes described in the plan. Use red/green TDD.", model="gpt-55", reasoning_effort="xhigh"] simplify_opus [label="Simplify (Opus)", prompt="@prompts/simplify.md"] simplify_gpt [label="Simplify (GPT-55)", prompt="@prompts/simplify.md", model="gpt-55"] verify [label="Verify", shape=parallelogram, script="git fetch origin main 2>&1 && git merge --no-edit --no-stat origin/main 2>&1 && cargo +nightly-2026-04-14 fmt --all 2>&1 && cargo dev docs refresh 2>&1 && cargo +nightly-2026-04-14 fmt --check --all 2>&1 && { command -v rg >/dev/null 2>&1 || { echo 'rg is required for verify'; exit 127; }; } && ! rg -n 'AuthMode::Disabled|RunAuthMethod|RunSubjectProvenance|\bActorRef\b|\bActorKind\b|AuthenticatedSubject|AuthenticatedService|AuthorizeRunScoped|AuthorizeRunBlob|AuthorizeStageArtifact|AuthorizeCommandLog|auth_method\s*==\s*\"disabled\"' lib/crates apps lib/packages docs/public/api-reference/fabro-api.yaml 2>&1 && cargo +nightly-2026-04-14 clippy --workspace --all-targets -- -D warnings 2>&1 && cargo nextest run --workspace --status-level slow --profile ci 2>&1 && cargo dev docs check 2>&1 && bun install --frozen-lockfile 2>&1 && (cd apps/fabro-web && bun run typecheck) 2>&1 && (cd apps/fabro-web && bun run test) 2>&1 && (cd lib/packages/fabro-api-client && bun run typecheck) 2>&1 && cargo dev build -- -p fabro-cli --release 2>&1", goal_gate=true, retry_target="fixup"] fixup [label="Fixup", prompt="The verify step failed. Read the build output from context and fix all format, clippy, Rust test, docs, TypeScript typecheck/test, and build failures.", max_visits=3] start -> toolchain toolchain -> preflight_compile [condition="outcome=succeeded"] toolchain -> exit preflight_compile -> preflight_lint [condition="outcome=succeeded"] preflight_compile -> exit preflight_lint -> implement [condition="outcome=succeeded"] preflight_lint -> fix_lints fix_lints -> preflight_lint implement -> simplify_opus -> simplify_gpt -> verify verify -> exit [condition="outcome=succeeded"] verify -> fixup fixup -> verify } ``` </details> ⚒️ Generated with [Fabro](https://fabro.sh) --------- Co-authored-by: Fabro <noreply@fabro.sh>	2026-05-29 17:30:57 -04:00
Bryan Helmkamp	0e224aa705	fix(web): remove slug field from automation edit page ... The slug cannot be changed after creation, so showing it as a read-only row on the edit page added noise without value. Keep the editable slug input on the create page. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-05-29 12:35:57 -04:00
Bryan Helmkamp	d3ed50f736	fix(web): align automation search input height with filter buttons ... The search input used text-sm (20px line-height) while the filter buttons use text-xs (16px), both with py-2, making the input 4px taller. Trim the input to py-1.5 so it matches the buttons' 34px height without resizing the shared filter button components. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-05-29 11:53:35 -04:00
Bryan Helmkamp	7c73f7ac02	fix(server): inline dockerfiles defined in the [environments.*] catalog ... The manifest bundler collects Dockerfile path references from both the named-environment catalog and [run.environment], but the server-side resolver only inlined [run.environment.image]. A Dockerfile declared under [environments.<slug>.image] therefore reached the Daytona provider as an un-inlined Path and tripped its guard ("dockerfile path should have been resolved to inline content before sandbox creation"), so no run could use a catalog-defined Dockerfile environment. Walk layer.environments alongside run.environment when resolving manifest dockerfiles, mirroring the bundler. Add a regression test proving a catalog dockerfile path is inlined. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-05-29 11:38:10 -04:00
Bryan Helmkamp	ba2c1cc168	config: define Daytona environment from Dockerfile for smoke workflow ... Runs were falling back to the built-in `default` environment (a bare daytona-medium snapshot with no Rust toolchain), so every Rust stage in the smoke workflow failed with exit 127 (cargo/rustc not found). The old [run.sandbox] config that built a custom snapshot was dropped in the move to named environments (#360) and never ported. Add a `fabro-dev` named environment that builds the Daytona snapshot from .fabro/Dockerfile (Rust + nightly-2026-04-14 + cargo-nextest + bun), with 8 CPU / 16GB RAM, and select it via [run.environment]. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-05-29 09:26:23 -04:00
Bryan Helmkamp	6a98cf4dbf	feat(web): add status, time, and repo filters to automation detail ... Match the toolbar on /runs?view=list so the runs section under /automations/:id supports the same client-side filters. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-29 09:23:54 -04:00
Bryan Helmkamp	0f6da7d5cc	chore: bump fabro-environment to 0.247.0-nightly.0 in Cargo.lock ... Cargo.lock churn from the merge with origin/main; the workspace bumped fabro-environment's version but Cargo.lock still pointed at the 0.246.0-nightly.0 entry until a build refreshed it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-29 08:52:24 -04:00
Bryan Helmkamp	ac66f6c1d6	Merge remote-tracking branch 'origin/main' into fix-center-size-column ... # Conflicts: # lib/crates/fabro-server/src/automation_materializer.rs # lib/crates/fabro-server/src/server.rs	2026-05-29 08:51:57 -04:00
Bryan Helmkamp	fee245d788	fix(web): make plural /automations/:id the canonical detail route ... The list card linked to the singular /automation/:id, which mismatched the rest of the new automations CRUD surface (/automations, /automations/new, /automations/:id/edit). Switch the card link and the slug-preview text on the create form to the plural form, and mount /automations/:id in the router alongside the existing singular route (kept as a back-compat alias for any older bookmarks). Drive-by: fold two adjacent `use super::*` imports into one and reflow a long `if let` line in the automations handler (linter cleanup; no behavior change). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-29 08:47:31 -04:00