Commit graph

5228 commits

Author SHA1 Message Date
Daniel Riccio
77bc9e6f92
fix: remove 'Full command' description and use correct translation keys
- Removed the 'Full command' description from the first pattern
- Updated translation keys to use existing ones from chat.json
- Fixed tooltip to use Trans component with settings link
- Updated tests to match the changes
2025-07-25 10:41:40 -05:00
Daniel Riccio
851617c0ff
feat: restore command pattern extraction with editable UI
- Re-added command-parser.ts and its tests
- Modified CommandPatternSelector to show both full command and extracted patterns
- Each pattern (including full command) is now individually editable with click-to-edit functionality
- Updated tests to match new component interface
- Maintains the improved UI with hover effects and focus rings
2025-07-25 10:33:30 -05:00
Daniel Riccio
20f99a2523
feat: improve command permissions UI with click-to-edit functionality
- Add click-to-edit behavior: command displays as text and becomes input on click
- Add proper padding between collapsible trigger and input field
- Fix layout shift between text and input states with transparent border
- Update focus styling to match standard input components (focus:outline-0)
- Add hover effect with background highlight for better UX
- Support Enter to confirm and Escape to cancel edits
2025-07-25 09:03:45 -05:00
Daniel Riccio
82350297a4
feat: simplify command permissions UI to use full commands instead of patterns
- Replace pattern extraction with single text input for full command
- Allow users to edit command before approving/denying
- Show active state (check/x) based on current allowed/denied lists
- Remove command-parser.ts and related pattern extraction logic
- Update tests to match new simplified behavior

This change addresses user feedback requesting a simpler interface where
users can edit the full command before setting permissions.
2025-07-25 08:23:43 -05:00
Daniel Riccio
ea360590af
fix: improve error handling in extractPatternsFromCommand function 2025-07-24 12:57:51 -05:00
Daniel Riccio
d819ae57b7
fix: remove unused index parameter in CommandPatternSelector 2025-07-24 12:47:49 -05:00
Daniel
63ce9e7a9b
Update webview-ui/src/components/chat/CommandPatternSelector.tsx
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-07-24 12:38:25 -05:00
Daniel
9481c95bbe
Update webview-ui/src/components/chat/CommandExecution.tsx
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
2025-07-24 12:37:44 -05:00
Daniel Riccio
7799f0cabf
refactor: remove automatic 'commands' description suffix from patterns 2025-07-24 12:26:42 -05:00
Daniel Riccio
cbc756d8b5
refactor: remove commandPatterns.ts and simplify command parsing
- Remove unnecessary commandPatterns.ts wrapper module
- Use extractPatternsFromCommand directly from command-parser.ts
- Simplify command/output parsing logic in CommandExecution.tsx
- Move CommandPattern interface to components that use it
- All tests passing
2025-07-24 12:17:28 -05:00
Daniel Riccio
627ea8462d
fix: stop extracting patterns at command flags and revert command-validation changes 2025-07-24 11:56:55 -05:00
Daniel Riccio
8b4150e017
Refactor command execution and security handling
- Removed security warning detection from CommandExecution component and related tests.
- Simplified command parsing logic by consolidating command extraction and validation.
- Updated command pattern extraction to handle duplicate patterns gracefully.
- Enhanced command parsing to limit extracted patterns to a maximum of three levels.
- Removed unused security issue detection functions and related tests.
- Improved test coverage for command pattern extraction and validation.
2025-07-24 10:40:08 -05:00
hannesrudolph
0a5cf463a1 fix: revert conditional display of command pattern selector
Per user feedback, the command pattern selector should always be displayed when patterns are available, regardless of whether command restrictions are configured.
2025-07-23 13:26:06 -06:00
hannesrudolph
17dbda3d4d fix: update command parser to handle all edge cases from original implementation
- Add support for all line ending types (\r\n, \r, \n)
- Handle simple variable references (, ) to prevent shell-quote from splitting them
- Handle special bash variables (0, , etc.)
- Maintain compatibility with all existing tests
- Fix linting warnings
2025-07-23 12:21:02 -06:00
hannesrudolph
55d0ff3f69 chore: remove temporary review files 2025-07-23 12:01:09 -06:00
hannesrudolph
38ed84b967 fix: consolidate command parsing logic and integrate security warnings
- Created shared command-parser.ts to eliminate duplicate parsing logic
- Integrated detectSecurityIssues to display warnings in the UI
- Made command suggestions configurable (only show when restrictions are enabled)
- Added comprehensive tests for the new command parser
- Updated existing tests to handle the new behavior
2025-07-23 12:01:09 -06:00
Roo Code
4b257fc628 refactor: simplify command pattern parser using shell-quote library
- Replace custom parsing logic with shell-quote library
- Implement simplified extractPatterns and processCommand functions
- Maintain all existing test compatibility
- Remove dependency on parseCommand from command-validation
2025-07-23 11:55:38 -06:00
hannesrudolph
0a25464cc3 refactor: eliminate code redundancy between extractCommandPatterns and parseCommand
- Refactored extractCommandPatterns to use the existing parseCommand function
- Ensures consistent command parsing behavior across the codebase
- Maintains security by removing subshell contents before parsing
- All existing tests continue to pass
2025-07-23 11:55:37 -06:00
hannesrudolph
f6642f6afe fix: prevent command output from appearing in permissions UI
- Fixed CommandExecution.tsx to only extract patterns from actual commands, not AI suggestions
- Enhanced extractCommandPatterns to filter out numeric patterns and common output words
- Added comprehensive test coverage for the bug scenario
- Ensures 'Manage Command Permissions' only shows actual executed commands

Fixes the issue where output like '0 total' from wc commands was incorrectly shown as a command pattern
2025-07-23 11:55:37 -06:00
hannesrudolph
ebf1b241c1 fix: improve command parsing to handle Output: separator correctly
- Fixed parseCommandAndOutput to properly handle the newline + 'Output:' separator
- Added test cases for commands with numbers at the start of output lines
- Updated existing tests to use template literals for proper newline handling
- Fixed test assertions to handle multiple code blocks when output is present

This resolves the issue where output lines starting with numbers (like 'wc -l' output)
were being incorrectly parsed as the command instead of the actual command text.
2025-07-23 11:55:37 -06:00
Roo Code
860631cfe3 fix: address code review feedback
- Replace unused showSuggestions state with SHOW_SUGGESTIONS constant
- Fix parseCommandAndOutput import name consistency
- Add test coverage for fallback case where command equals text
2025-07-23 11:55:37 -06:00
Roo Code
b24400b549 fix: address PR review feedback
- Refactored showSuggestions from state variable to constant SHOW_SUGGESTIONS
- Renamed breakingExps to stopPatterns for better clarity
- Added test coverage for edge cases in command parsing
- Fixed test assertion for multiline content handling
2025-07-23 11:55:37 -06:00
hannesrudolph
dd533c2af7 refactor: convert showSuggestions from state to constant
- Addresses code review feedback about unused state variable
- showSuggestions is always true and never changes, so it doesn't need to be state
- All tests pass and no linting issues
2025-07-23 11:55:37 -06:00
hannesrudolph
6fa0a528b9 fix: address PR review feedback
- Fix import error in CommandExecution.tsx (removed undefined parseCommandAndOutput)
- Add security features with detectSecurityIssues function for subshell detection
- Remove hardcoded command descriptions, use dynamic pattern instead
- Add comprehensive security tests for subshell detection
- Add integration tests for CommandExecution + CommandPatternSelector
- Fix Polish translation typo: 'z list' -> 'z listy'
- Simplify commandPatterns.ts by removing unnecessary complexity
2025-07-23 11:55:37 -06:00
hannesrudolph
6fda13643c feat: Add terminal command permissions UI to chat interface (#5480) 2025-07-23 11:55:37 -06:00
Matt Rubens
ba541ab848
chore: add changeset for v3.23.19 (#6130) 2025-07-23 13:53:26 -04:00
Bruno Bergher
4f8c9688a2
Roo Code Cloud Waitlist CTAs (#6104)
Co-authored-by: Roo Code <roomote@roocode.com>
Co-authored-by: Bruno Bergher <me@brunobergher.comexport>
2025-07-23 13:28:30 -04:00
Matt Rubens
4042fb0fd0
Smarter auto-deny (#6123) 2025-07-23 12:02:31 -04:00
Matt Rubens
9d434c2db9
Split commands on newlines (#6121) 2025-07-23 11:21:06 -04:00
github-actions[bot]
714fafd328
Changeset version bump (#6111)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matt Rubens <mrubens@users.noreply.github.com>
2025-07-23 09:07:14 -04:00
github-actions[bot]
637ba34958
Update contributors list (#5699)
Co-authored-by: mrubens <2600+mrubens@users.noreply.github.com>
2025-07-23 09:05:39 -04:00
Matt Rubens
a197c859f0
chore: add changeset for v3.23.18 (#6109) 2025-07-23 09:04:14 -04:00
KJ7LNW
3e89b06f25
debug: Add ErrorBoundary component for better error handling (#5085)
Co-authored-by: Eric Wheeler <roo-code@z.ewheeler.org>
2025-07-23 08:45:35 -04:00
Daniel
b0820ac755
fix: resolve 'Bad substitution' error in command parsing (#5743) 2025-07-23 08:43:36 -04:00
Christiaan Arnoldus
1c26bbc5ab
Fix todo list toggle not working (#6103) 2025-07-23 08:39:27 -04:00
Chris Estreich
9956cc1f48
Use SIGKILL for command execution timeouts in the "execa" variant (#6071) 2025-07-23 01:47:10 -07:00
github-actions[bot]
2411c8faa4
Changeset version bump (#6092)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matt Rubens <mrubens@users.noreply.github.com>
2025-07-22 21:45:53 -04:00
roomote[bot]
dbc8119601
Release v3.23.17 (#6091)
Co-authored-by: Roo Code <roomote@roocode.com>
Co-authored-by: Matt Rubens <mrubens@users.noreply.github.com>
2025-07-22 21:38:44 -04:00
Daniel
aa0e6d31d8
feat: add merge-resolver mode for intelligent conflict resolution (#6090) 2025-07-22 21:31:36 -04:00
Murilo Pires
0cb76d9ae9
fix: add Git installation check for checkpoints feature (#3109) (#5920)
Co-authored-by: Daniel Riccio <ricciodaniel98@gmail.com>
2025-07-22 21:31:20 -04:00
roomote[bot]
8dcc078d85
feat: add Qwen/Qwen3-235B-A22B-Instruct-2507 model to Chutes AI provider (#6052)
Co-authored-by: Roo Code <roomote@roocode.com>
Co-authored-by: Matt Rubens <mrubens@users.noreply.github.com>
2025-07-22 21:17:14 -04:00
Murilo Pires
c6a29f3f27
feat: add llama-4-maverick model to Vertex AI provider (#5808) (#6023)
* feat: add llama-4-maverick model to Vertex AI provider (#5808)

* fix: update llama-4-maverick pricing to correct values
2025-07-22 19:26:18 -04:00
Hannes Rudolph
2b8228ef0c
docs: clarify when to use update_todo_list tool (#5926)
* docs: clarify when to use update_todo_list tool

Added 'complicated' to the condition for when to use the update_todo_list tool,
making it clearer that the tool should be used for tasks that are either
complicated OR involve multiple steps.

* fix: update vscode mock and snapshots for update_todo_list tool changes

- Add missing RelativePattern export to vscode mock
- Fix onDidChangeWorkspaceFolders function in workspace mock
- Update test snapshots to reflect new "complicated" text in update_todo_list tool documentation
- Build tree-sitter WASM files to fix parsing tests

Fixes failing CI tests related to PR #5926 documentation changes.

* Delete package-lock.json

* revert: remove unrelated changes to src/__mocks__/vscode.js

---------

Co-authored-by: Roo Code <roomote@roocode.com>
Co-authored-by: Daniel <57051444+daniel-lxs@users.noreply.github.com>
2025-07-22 17:37:27 -04:00
roomote[bot]
dbde23c84e
fix: add case sensitivity mention to suggested fixes in apply_diff error message (#6076)
Co-authored-by: Roo Code <roomote@roocode.com>
2025-07-22 14:15:28 -07:00
roomote[bot]
5629199d51
Add jump icon for newly created files (#5738)
* feat: add jump icon for newly created files

- Add jump icon to newFileCreated tool case in ChatRow.tsx
- Matches existing pattern from readFile case for consistent UX
- Allows users to quickly open newly created files
- Fixes issue #5736

* fix: remove duplicate file path display in newFileCreated case

- Removed redundant ToolUseBlock that was showing file path twice
- Added onJumpToFile prop to CodeAccordian component to support jump icon
- Jump icon now appears in CodeAccordian header for newFileCreated files
- Maintains consistent UX with existing file operations while avoiding duplication

Fixes feedback from @daniel-lxs about duplicate elements being shown

* fix: address PR feedback for jump icon on new files

- Fix openFile message to use correct path format with './' prefix
- Remove duplicate chevron icon when jump icon is present
- Add aria-label for accessibility
- Fix styling: use mr-1 to match progressStatus icon
- Remove redundant margin style from jump icon

---------

Co-authored-by: Roo Code <roo@roocode.com>
Co-authored-by: Roo Code <roomote@roocode.com>
Co-authored-by: Daniel Riccio <ricciodaniel98@gmail.com>
2025-07-22 13:26:32 -04:00
Chris Estreich
984d368f7a
Fix evals; broken by #5865 (#6065) 2025-07-22 09:18:38 -07:00
John Richmond
e78d9541ca
Bugfix: Cloud: be more specific about session error codes (#6051)
InvalidClientTokenError indicates an unrecoverable state for
the session, so we need to be more exact about triggering it. A recent
Clerk outage resulted in a lot of 429 responses which should really cause
inactive-session, not a full clear to logged-out.
2025-07-22 07:16:15 -07:00
Matt Rubens
df6c57d293
feat: add moonshot provider (#6046)
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Co-authored-by: CellenLee <99465814+CellenLee@users.noreply.github.com>
2025-07-22 00:37:24 -04:00
roomote[bot]
b1bc085aa6
Add todo list tool enable checkbox to provider advanced settings (#6032)
Co-authored-by: Roo Code <roomote@roocode.com>
Co-authored-by: Daniel Riccio <ricciodaniel98@gmail.com>
Co-authored-by: Matt Rubens <mrubens@users.noreply.github.com>
2025-07-21 23:27:28 -04:00
Daniel
7e34fbcb0c
fix: add bedrock to ANTHROPIC_STYLE_PROVIDERS and restore vertex Claude model checking (#6019) 2025-07-21 22:27:20 -04:00