Commit graph

11756 commits

Author SHA1 Message Date
Dan Stillman
ec280c5bdf Item#fromJSON(): Don't process any Extra rows in strict mode
And enable migration of Extra rows to valid fields in non-strict mode,
but since that's only used by translators now, that probably won't do
anything

Fixes #3422
2025-01-22 03:16:22 -05:00
Dan Stillman
8642091d8e Don't auto-select item after sync on upload error
Bug from 2017
2025-01-22 03:14:07 -05:00
Dan Stillman
e3387bbe96 Adjust debug line if file not available for uploading
Files can be missing locally and flagged for uploading, so not just a
files still being saved
2025-01-22 03:10:40 -05:00
Dan Stillman
a2f3b28b48 Remove unnecessary code after ec50539e80
`getBaseIDFromTypeAndField()` now returns the field itself if it's
already a base field
2025-01-22 01:06:03 -05:00
Abe Jellinek
00c0679333 Add key to Advanced Search menuitem
Fixes #4978
2025-01-21 11:06:35 -05:00
Dan Stillman
296edc3fdd
Unset Mozilla environment variables when launching files and URLs (#4983)
Fixes #4981
2025-01-21 05:40:27 -05:00
Tom Najdek
a4414cc2f0
Remove last few legacy icons #3691 (#4996) 2025-01-21 05:37:56 -05:00
windingwind
67da025e3f
Fix attachments box race condition (#4997)
fix: #4611
Since the attachment preview already has a task queue,
don't skip render calls when rendering
2025-01-21 05:27:33 -05:00
Dan Stillman
810062a1af Remove reference to Zotero for Firefox in incompatible-DB error 2025-01-21 05:17:36 -05:00
Dan Stillman
850431af93 Fix display of button bar in sync error panel 2025-01-21 05:17:36 -05:00
Adomas Venčkauskas
94650e2ee9 Fix integration session breaking when an error is thrown during getDocument() 2025-01-20 12:11:50 +02:00
windingwind
998315dd58
Fix menu popup dblclick on MacOS (#4989) 2025-01-17 13:00:01 -05:00
Abe Jellinek
e11d93f0bc
Restore whitespace in search Collection condition menu (#4990) 2025-01-16 23:13:06 -05:00
Abe Jellinek
c8051aa3f8 Scaffold: Make Defer checkbox interactive 2025-01-16 11:07:45 -05:00
Abe Jellinek
0bdae76e49 Scaffold: Cleanup 2025-01-16 10:39:05 -05:00
Dan Stillman
484eb1f1d7 Fix ids showing instead of creator names for creator autocomplete
https://forums.zotero.org/discussion/121089/beta-author-suggestions-broken-only-suggest-numbers-instead-of-names

Related Mozilla bugs (though I don't see a change that would be directly
responsible for this):

https://bugzilla.mozilla.org/show_bug.cgi?id=1886064
https://bugzilla.mozilla.org/show_bug.cgi?id=1910073
2025-01-13 02:36:28 -05:00
windingwind
524660e10b
Fix dense call to setItemDownloadPercentage freezes app (#4979) 2025-01-11 03:17:56 -05:00
Dan Stillman
b86305f40e Fix json[c.field] is undefined sync error
Fix error if local note or attachment is added to a parent item while
the remote version was added to a collection. Now, the new local parent
item will be added to any collections the remote child item was added
to.

Fixes #2934
2025-01-09 03:11:01 -05:00
Dan Stillman
c44d845c8c Indent some switch case statements
For current style
2025-01-09 03:11:01 -05:00
Tom Najdek
c41eb54278
Fix Metadata Retrieval to correctly display the recognized item's title 2025-01-09 01:44:43 +01:00
Adomas Venčkauskas
b538b12d51 Refresh document with delayed citation updates when changing style
Closes #4974
2025-01-08 14:03:44 +02:00
Dan Stillman
2c377316e3 Update Mozilla langpack files 2025-01-08 01:41:29 -05:00
Dan Stillman
ab9849e71a fx128: Add arrowscrollbox.ftl from Mozilla
Fixes locales not being fully loaded, including for plugins, in 128

https://groups.google.com/g/zotero-dev/c/kcQ-A3EclBQ/m/ShIFTfM6DAAJ
2025-01-08 01:41:29 -05:00
windingwind
9777d21001
Fix export error of item.tags being undefined (#4962)
Item generated from embedded image attachment may not have attribute `tags`.
2025-01-03 00:48:31 -05:00
abaevbog
7dad8377df
qf: default arrowUp handling on locator menulist (#4965)
Do not close details panel on arrowUp when locator
type menulist is focused to allow for default handling
(e.g. select the next/previous option on windows).

Fixes: #4953
2025-01-02 22:42:38 -05:00
Dan Stillman
6ee556500d fx128: Implement non-incremental backup option
A new function, `Zotero.DB.backUpDatabase()`, by default makes offline
backups, by closing the database, doing a regular file copy, and
reopening the database. It takes an options object with an `online`
flag to make online, incremental backups that can take multiple minutes
to complete, though for now we're still running them on idle.

The old function, `Zotero.DB.backupDatabase(suffix, force)`, is
deprecated and proxies to the new function, making offline backups.

Fixes #4935
2025-01-02 02:56:41 -05:00
abaevbog
7b7a0b9e46
save tagsBox updates when another item is selected (#4945)
When tagsBox item is changed by clicking on an itemTree row,
the blur even never fires on the currently focused tag. So
whatever changes were made will be discarded. To avoid it,
blur any opened tag rows (which triggers a saveTx)
when an item is being set, same way it is done in itemBox.

Also, a small tweak to properly fetch the focused tag
via editable-text:focus-within selector, since editable-text:focus is
always empty because the focus is on the input inside of
editable-text.

Fixes: #4942
2024-12-20 02:55:33 -05:00
abaevbog
a89e0a1554
hide switch creator type in non-editable itembox (#4940)
Fixes: #4937
2024-12-20 02:52:06 -05:00
Dan Stillman
20e28d3f9e Fix handling of redirecting OpenURL base URLs with url query parameter
For a URL like
`https://ezproxy.school.edu/login?url=http://resolver.ebscohost.com/openurl`,
without a trailing `?`, we were just adding a `%` to the end, making the
URL invalid after the redirection (`/openurl&url_ver=Z39.88-2004`
instead of `/openurl?url_ver=Z39.88-2004`).

(And apparently no one who sent in these URLs actually tested them
in-app?)
2024-12-20 02:47:36 -05:00
Dan Stillman
244d182293 Fix logged error in integration progress bar
After b007bd4364
2024-12-20 02:37:25 -05:00
Abe Jellinek
fa48e978c7 Serialize _ensureFeedAbstractBrowserExists()
Prevent a potential race condition.
2024-12-18 12:20:00 -05:00
Abe Jellinek
013a814765 fx128: Fix feed abstracts
Closes #4938
2024-12-18 12:19:30 -05:00
abaevbog
cddbbdd208
fx128: fix broken database backup (#4931)
Per https://bugzilla.mozilla.org/show_bug.cgi?id=1869060#c18,
the backup utility was removed from the storage service and
exposed durectly on the connection itself in fx128.

Fixes: #4929
2024-12-18 07:11:27 -05:00
Martynas Bagdonas
b806b41b6f Render ink annotation images when previewing attachment annotations 2024-12-17 18:29:48 +02:00
Bogdan Abaev
b007bd4364 fx128: hide titlebars in dialogs on win and mac
Use titlebar.js to hide titlebars in windows and mac
in all relevant dialogs and windows.
2024-12-16 16:15:18 -05:00
Abe Jellinek
4d90fe72bd CookieSandbox: Fix XHR interface check
Actually broken since fx115.
2024-12-16 12:21:55 -05:00
windingwind
28e7966973 Fix ZoteroPane#buildFieldTransformMenu document variable (#4927)
fix: https://groups.google.com/g/zotero-dev/c/FwfrxviKi8I
2024-12-14 01:16:06 -05:00
Adomas Ven
e3b243ba45 Remove missing-component integration error. (#4923)
This is no longer a thing since word plugins are not Zotero extensions.
If that code throws - it's because we've done something wrong and it's
a bug
2024-12-14 01:16:05 -05:00
Dan Stillman
d580e420d3 Quick fix for inconsistent logging in updates window 2024-12-14 01:16:05 -05:00
Dan Stillman
ca1e9bc467 fx128: Fix app updates 2024-12-14 01:16:05 -05:00
Dan Stillman
468155c548 fx128: Fix broken Help menu on first open on Linux
Only assign a key to "Support and Documentation" on macOS

Fixes #4918
2024-12-14 01:16:04 -05:00
Dan Stillman
fa20733353 fx128: Fix login manager for WebDAV
Only `addLogin` → `addLoginAsync` is necessary at this time, but
`findLogins` is deprecated, so switch to `searchLoginsAsync` as well.
2024-12-14 01:16:04 -05:00
Dan Stillman
4319b8d78e Revert modifyLoginAsync to modifyLogin 2024-12-14 01:16:03 -05:00
Dan Stillman
a0bdeab401 fx128: Fix login manager
Use async methods (since the sync ones seem to already be broken from JS
despite https://bugzilla.mozilla.org/show_bug.cgi?id=1832756 still being
open) and avoid loading Firefox Accounts module
2024-12-14 01:16:03 -05:00
Abe Jellinek
d9550bb5df Server: Expose actual bound port (#4903)
And:
- Use a different port for tests so server tests don't break when Zotero
  is already running
- Remove no-op httpServer.enabled pref updates in tests
   - It's already enabled, no test disables it, and any test that did
     would clean up after itself
   - Updating that pref has no effect without a separate call to
     Zotero.Server.init()
- Remove unused arg to Zotero.Server.init()
2024-12-14 01:16:03 -05:00
Abe Jellinek
b858645957 fx128: -moz-nativehyperlinktext -> LinkText (#4902) 2024-12-14 01:16:03 -05:00
Abe Jellinek
72b56e7a59 Pass BrowsingContext to nsIFilePicker init
Fixes #4892
2024-12-14 01:16:02 -05:00
Abe Jellinek
f28fa763cc DataTransfer#types: contains() -> includes()
Not sure what this was before, but it's a standard read-only array now.

Fixes #4893
2024-12-14 01:16:02 -05:00
Dan Stillman
45e681431b fx128: Remove uses of nsIDOMChromeWindow
https://bugzilla.mozilla.org/show_bug.cgi?id=1522052
2024-12-14 01:16:01 -05:00
Dan Stillman
187b1649c1 fx128: Handle changed error message for IOUtils.makeDir on broken symlink 2024-12-14 01:16:00 -05:00