scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-10-04 02:31:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove unnecessary code after ec50539e80

Browse source 
`getBaseIDFromTypeAndField()` now returns the field itself if it's
already a base field
This commit is contained in:
Dan Stillman 2025-01-22 01:05:49 -05:00
parent 6308ea6a18
commit a2f3b28b48
1 changed files with 3 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
chrome/content/zotero/xpcom/data/item.js
View file

@ -5323,18 +5323,9 @@ Zotero.Item.prototype.fromJSON = function (json, options = {}) {
// https://github.com/zotero/zotero/issues/1504#issuecomment-572415083
if (!strict && extraFields.size) {
for (let field of setFields.keys()) {
let baseField;
if (Zotero.ItemFields.isBaseField(field)) {
baseField = field;
}
else {
let baseFieldID = Zotero.ItemFields.getBaseIDFromTypeAndField(itemTypeID, field);
if (baseFieldID) {
baseField = baseFieldID;
}
}
if (baseField) {
let mappedFieldNames = Zotero.ItemFields.getTypeFieldsFromBase(baseField, true);
let baseFieldID = Zotero.ItemFields.getBaseIDFromTypeAndField(itemTypeID, field);
if (baseFieldID) {
let mappedFieldNames = Zotero.ItemFields.getTypeFieldsFromBase(baseFieldID, true);
for (let mappedField of mappedFieldNames) {
if (extraFields.has(mappedField)) {
extraFields.delete(mappedField);