Commit graph

15735 commits

Author SHA1 Message Date
Martynas Bagdonas
e644df74fe Remove tab characters from FTL files to avoid parsing issues
Fixes #5447
2025-08-04 15:02:51 +03:00
Tom Najdek
8355a95407
Warn users running non-ARM version on ARM CPU on Linux (#5461) 2025-08-02 09:59:48 -04:00
Abe Jellinek
f8a1a2c6ed
Don't merge into a missing snapshot attachment (#5459) 2025-08-02 01:53:47 -04:00
abaevbog
487677958e
fix subcollection not being copied to library root (#5464)
Fixes: #5463
2025-08-02 01:50:54 -04:00
Abe Jellinek
68ffe9583c Clean up JSDoc comments and unused field (#5443) 2025-08-02 01:49:39 -04:00
Abe Jellinek
fd6c52ede4 Find Full Text: Simulate ProQuest redirect back to original page (#5443)
We don't follow JS redirects, so this is necessary in order for
us to get to a translatable page after authentication.
2025-08-02 01:49:39 -04:00
Abe Jellinek
91732419b6 Attach CookieSandbox to Find Full Text requests and translation (#5443)
With a 24-hour validity per site (eTLD+1).
2025-08-02 01:49:39 -04:00
abaevbog
2a60011414
fx140: fix cutoff progressWindow on linux (#5462)
Resize the window to fit content on load after the
header is rendered. If the window is resized on
DOMContentLoaded, nothing is rendered yet and the
window will look cutoff on Linux.

Addresses #5453
2025-08-02 01:41:39 -04:00
abaevbog
873beebc0f
close more leftover windows in tests (#5460)
- close hyphenationTest window.
- properly close zoteroPane window in preferences_syncTest.
after() hook inside of the test would not close the window until the
very end of the entire test run. Without this, during
subsequent tests that open their own zoteroPane window, there
are two instances of zoteroPane open at the same time.
- close open tabs in readerTest cleanup, since subsequent
tests expect library tab to be selected.

Followup to https://github.com/zotero/zotero/pull/5444#issuecomment-3141879892
2025-08-02 01:40:21 -04:00
Abe Jellinek
74926fcc2e Fix menubar menu not opening after submenu item is selected
On Windows and (I'm assuming) Linux. Regression in c3f8ba8.

Fixes #5456
2025-08-01 12:12:36 -04:00
windingwind
37ff8c9143
Improve linux popup appearance (#5452)
* Fix tabs menu panel padding

* Fix tabs menu panel background

* Fix panel style selector

resolve: #5434
2025-08-01 11:02:14 -04:00
windingwind
1dbfb1a998
Improve linux window appearance (#5451)
resolve: #5449
2025-08-01 10:59:38 -04:00
Dan Stillman
2bff6541f2 Update note-editor and reader submodules 2025-07-31 22:50:21 -04:00
abaevbog
b1e163b7f5
fx140: Use architecture-specific build folder for tests on Linux (#5445) 2025-07-31 22:48:21 -04:00
Dan Stillman
87d27f9c51
Close ProgressQueueDialog after connector server tests (#5446)
Since some connector operations trigger recognition

This will hopefully fix the tags box test failures.
2025-07-31 21:54:15 -04:00
windingwind
773ca6f724
Improve item pane test stability (#5436) 2025-07-31 21:51:40 -04:00
abaevbog
69fdf0b145
fx140: fix collection tree toolbar color on Linux (#5440)
Override default toolbar color set in https://searchfox.org/mozilla-esr140/source/toolkit/themes/linux/global/toolbar.css#12

Fixes #5439
2025-07-31 13:35:14 -04:00
Dan Stillman
19a848484a Don't split tags at em dashes on paste in item tags box
https://github.com/zotero/zotero/pull/5366#discussion_r2245628458
2025-07-31 11:25:57 -04:00
Dan Stillman
5063a8b396 isAbove → isAtLeast in sync engine tests for testing delays
Maybe related to Bluebird?
2025-07-31 10:45:19 -04:00
Tom Najdek
efadc21cdc
Update a call to a deprecated function in Mendeley import 2025-07-31 16:04:06 +02:00
Tom Najdek
a5cdd8d5aa
Fix context menu closes on every third right-click. Resolve #5427 2025-07-31 13:03:01 +02:00
Dan Stillman
682722bc29 Update LibreOffice and Word for Mac submodules 2025-07-30 22:31:12 -04:00
abaevbog
95e4a34476 fx140: fix separators on linux (#5432)
- fix transparent gap between tag selector and separator
- remove double border below separator of context pane in
stacked mode

Fixes: #5430
2025-07-30 22:31:12 -04:00
Dan Stillman
7f684ce130 Remove unused argument (previously to Zotero.Promise.map()) 2025-07-30 22:31:12 -04:00
Dan Stillman
87971248c5 Replace Bluebird's .spread() in integration code 2025-07-30 22:31:11 -04:00
Dan Stillman
18ff5c30f0 Update LibreOffice and Word for Mac submodules for fx140 2025-07-30 22:31:11 -04:00
Dan Stillman
922af23c63 fx140: Fix Mendeley Importer import 2025-07-30 22:31:11 -04:00
Dan Stillman
57fd2162d1 fx140: Fix NetUtil import 2025-07-30 22:31:11 -04:00
windingwind
08e2be9875 fx140: fix item pane test further
Should call updateLayout after changing layout
Should wait for notify after saving object
2025-07-30 22:31:11 -04:00
windingwind
0ce54e2b14 Fix item pane test failure
fix: #5421
2025-07-30 22:31:11 -04:00
abaevbog
747a3f7a9f fx140: remove sliding animation from panels (#5423) 2025-07-30 22:31:10 -04:00
Abe Jellinek
5af15f6496 fx140: Bring tabbox tabs back to the middle
And nudge them down a bit further.
2025-07-30 22:31:10 -04:00
Dan Stillman
4a5689e9b6 Restore rejection of last feed item when FeedReader terminates
Without this, the "should reject if the provided url is not a valid
feed" test fails

Follow-up to #5412
2025-07-30 22:31:10 -04:00
Abe Jellinek
c1270e635e Overhaul testing in Scaffold (#5301) 2025-07-30 22:31:10 -04:00
abaevbog
2e135d035f Fx140: do not use bluebird methods in citation dialog (#5416)
Instead, decide if the search should be skipped after
the delay based on the timestamps.

Fixes: #5414
2025-07-30 22:31:10 -04:00
Dan Stillman
0a33eeb0c0 Update translate submodule 2025-07-30 22:31:10 -04:00
Dan Stillman
4c51883b97 Restore Zotero.Promise.method() on ItemGetter#setAll()
Required for noWait translation
2025-07-30 22:31:09 -04:00
Dan Stillman
d797c7a4d8 BluebirdShimPromise: Add value() and fix isResolved() semantics
- value() is used in noWait export translation

- isResolved() technically means fulfilled or rejected -- unclear if we
  ever depended on that, but it might as well be correct
2025-07-30 22:31:09 -04:00
abaevbog
dd5667c09b fx140: update X icon for search cancel button (#5417)
searchfield-cancel.svg no longer exists, use close-12.svg
that is the same one used by search-textbox
2025-07-30 22:31:09 -04:00
windingwind
d1c6ee33be Fix plugin API test failure
Fix: #5411
2025-07-30 22:31:09 -04:00
Abe Jellinek
a53e474f9c Make filterStack() a no-op 2025-07-30 22:31:09 -04:00
Dan Stillman
e7805914f4 ConcurrentCaller: Increment numRunning in the correct place 2025-07-30 22:31:09 -04:00
Dan Stillman
0f560f4e4c ConcurrentCaller: Fix return value in comment after Bluebird removal 2025-07-30 22:31:09 -04:00
Dan Stillman
5c172e3be9 ConcurrentCaller: Reject queued promises when stopping queue
Previously, we simply cleared the queue, leaving any pending promises
unresolved, and we checked for isResolved()/isPending() in
storageEngine.js (and maybe other places). storageEngine.js was changed
to simply await those promises, but that results in a hang if the queue
is stopped, since the promises were never resolved. Instead, when
stopping the queue, reject queued promises with a CanceledException and
ignore those promises in storageEngine.js.
2025-07-30 22:31:08 -04:00
Abe Jellinek
0a62553746 Remove remaining chai-as-promised method calls 2025-07-30 22:31:08 -04:00
Abe Jellinek
9442b7ee6c Fix Zotero.Feed tests after chai-as-promised removal 2025-07-30 22:31:08 -04:00
Abe Jellinek
7e706354f9 Don't try to reject last feed item when FeedReader terminates
As the comment says, this hasn't been useful (and isn't used anywhere),
and I honestly don't understand how the test ever passed - process()
would've resolved all the feed item promises already.

Fixes #5412
2025-07-30 22:31:08 -04:00
Abe Jellinek
c8aff336b3 Migrate Bluebird methods in Zotero.Utilities.Internal.saveDocument()
Fixes #5415
2025-07-30 22:31:08 -04:00
Dan Stillman
26ffaf0ad3 Update translate module
Fixes test failure in fx140
2025-07-30 22:31:08 -04:00
Dan Stillman
f81763b173 Remove Chai as Promised
A test using `assert.eventually` was failing after the Bluebird removal
but worked with just `await`, and since there hasn't really been much
point to Chai as Promised since the introduction of `async`/`await` ages
ago, just remove the library instead of figuring out why.
2025-07-30 22:31:08 -04:00