scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-10-09 03:18:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Don't try to reject last feed item when FeedReader terminates

Browse source 
As the comment says, this hasn't been useful (and isn't used anywhere),
and I honestly don't understand how the test ever passed - process()
would've resolved all the feed item promises already.

Fixes #5412
This commit is contained in:
Abe Jellinek 2025-07-28 12:09:56 -04:00 • committed by Dan Stillman
parent c8aff336b3
commit 7e706354f9
2 changed files with 0 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
chrome/content/zotero/xpcom/feedReader.js
View file

@ -221,17 +221,6 @@ Zotero.FeedReader.prototype.terminate = function (status) {
// Reject feed promise if not resolved yet
this._feedProcessed.reject(new Error(status));
// Reject feed item promise if not resolved yet
let lastItem = this._feedItems[this._feedItems.length - 1];
// It seemed like a good idea to reject the last item but
// it's not really been useful yet, aside from bluebird
// throwing errors about unhandled rejections in tests
// so we suppress them here. TODO: We should probably
// rethink whether this code makes sense and make it better.
// FIXME: fx140: We can no longer "handle" the rejection here
let er = new Error(status);
lastItem.reject(er);
};
Zotero.defineProperty(Zotero.FeedReader.prototype, 'feedProperties', {

8
test/tests/feedReaderTest.js
View file

@ -86,14 +86,6 @@ describe("Zotero.FeedReader", function () {
e = await getPromiseError(fr._feedItems[fr._feedItems.length-1].promise);
assert.ok(e);
});
it('should reject last feed item if feed processed', async function () {
let fr = new Zotero.FeedReader(rssFeedURL);
await fr.process();
fr.terminate("test");
let e = await getPromiseError(fr._feedItems[fr._feedItems.length-1].promise);
assert.ok(e);
});
});
describe('#feedProperties', function () {