Commit graph

15199 commits

Author SHA1 Message Date
Abe Jellinek
2aee7ae8d5 RemoteTranslate: Fix updated tests not inheriting defer 2025-01-28 10:07:11 -05:00
Adomas Venčkauskas
2afbe030d5 Update Word for Windows submodule 2025-01-28 10:39:44 +02:00
Dan Stillman
d1e67987bd Fix broken test after #5004
Reverts a change I made to the PR. Only `since=0` would be valid in the
web API, but local items don't have a version by default, so it has to
be `-1` to match those. This probably isn't a great solution, since tools
targeting the web API would use `0`, but this will fix the test for now.
2025-01-28 01:25:08 -05:00
Abe Jellinek
65393d09eb
Check editability based on tab when adding attachments (#4936)
And make `get[Selected/Sorted]Items()` and `canEdit[Library/Files]()` tab-aware
2025-01-28 01:00:17 -05:00
Abe Jellinek
a7fff8cada
Local API: Add /fulltext endpoints (#5004) 2025-01-28 00:58:12 -05:00
Abe Jellinek
6cdae37e5b
Local API: Fix 500 error when attachment has unparseable path (#5010) 2025-01-28 00:54:29 -05:00
Abe Jellinek
48b50064e9
Item box: Fix missing Copy/Paste menuitems on URL fields (#5001) 2025-01-28 00:48:41 -05:00
Abe Jellinek
be023c3a95 RemoteTranslate: Fix error when creating test 2025-01-27 15:23:51 -05:00
Dan Stillman
71d697801e Fix banner style issues
- Fix background color on post-upgrade banner
- Add drop shadow between stacked banners (e.g., post-upgrade banner and
  Mac Word banner, which will generally appear together on an upgrade
  and have the same background color)
- Align right edge of buttons in post-upgrade and Mac Word
- Unify other spacing and font sizes
2025-01-27 07:34:31 -05:00
Dan Stillman
7a467b8bfa Fix selectItems() not selecting non-top-level item in trash
https://forums.zotero.org/discussion/comment/484380/#Comment_484380

Adds `Zotero.Item#isInTrash()` that returns true if the item or any of
its ancestors is in the trash (i.e., `.deleted == true`)
2025-01-27 04:02:10 -05:00
Dan Stillman
814e59f694 Use commas in file size in over-quota error 2025-01-27 04:02:10 -05:00
Dan Stillman
39cbf5e520 Fix double URL launch via keyboard in sync error panel
Space bar or Enter are (now?) equivalent to `click` on a button
2025-01-27 04:02:10 -05:00
Abe Jellinek
465cc89ad6 Scaffold: Use native checkboxes in select dialog 2025-01-24 15:04:52 -05:00
Abe Jellinek
9510eef69a Scaffold: Fix select dialog overflow (again!)
And restore button spacing.
2025-01-24 15:04:43 -05:00
Abe Jellinek
ff3ab619d1 Scaffold: Fix appearance regressions, simplify margin/padding
- Move 16px padding into the tabbox, which lets us eliminate the
  negative margin on #right-pane and the 5px padding to make room for
  the focus ring
- Remove width: 100% from the textarea - not necessary and causes
  horizontal overflow on macOS

Tested on macOS and Windows.
2025-01-24 14:26:05 -05:00
Abe Jellinek
679b1df116 Update translate submodule 2025-01-24 14:10:31 -05:00
Abe Jellinek
3a816fad55 Scaffold & RemoteTranslate: Improve defer handling
- Use extracted delay routine
- Pass defer into newTest()
2025-01-24 12:10:33 -05:00
Abe Jellinek
5f983d71c1 RemoteTranslate: Improve page readiness checks
Treat page as immediately ready after readyState == 'complete', or give
it 100ms after 'interactive'. This is rough, but 'interactive' isn't
always fully ready and 'complete' sometimes never happens.
2025-01-24 12:10:15 -05:00
Abe Jellinek
79092fadcd Update translate submodule 2025-01-24 12:02:43 -05:00
Abe Jellinek
b6ca3eac37 Remove dead contentType branch
Already handled in isCachedMIMEType().
2025-01-23 17:56:32 -05:00
Tom Najdek
dcf809961a
Add a gap between the buttons in the progress queue 2025-01-23 14:59:42 +01:00
Dan Stillman
ed045e640a Tests for Item#fromJSON() changes (#3422) 2025-01-22 03:23:06 -05:00
Dan Stillman
ec280c5bdf Item#fromJSON(): Don't process any Extra rows in strict mode
And enable migration of Extra rows to valid fields in non-strict mode,
but since that's only used by translators now, that probably won't do
anything

Fixes #3422
2025-01-22 03:16:22 -05:00
Dan Stillman
8642091d8e Don't auto-select item after sync on upload error
Bug from 2017
2025-01-22 03:14:07 -05:00
Dan Stillman
e3387bbe96 Adjust debug line if file not available for uploading
Files can be missing locally and flagged for uploading, so not just a
files still being saved
2025-01-22 03:10:40 -05:00
Dan Stillman
aaf7984a8e Fix alignment of tag rows in long tag fixer
Rows were center-aligned
2025-01-22 03:09:31 -05:00
Dan Stillman
39b92d6cdb Fix incorrect spacing around link in Z7 post-upgrade banner
Regression from 564b1766aa

Fixes #4926
2025-01-22 03:07:36 -05:00
Dan Stillman
d2952d3e71 Remove duplicate padding rule 2025-01-22 03:07:19 -05:00
Dan Stillman
9e569c33f8 Adjust nesting of #post-upgrade-banner SCSS 2025-01-22 03:06:40 -05:00
Dan Stillman
a2f3b28b48 Remove unnecessary code after ec50539e80
`getBaseIDFromTypeAndField()` now returns the field itself if it's
already a base field
2025-01-22 01:06:03 -05:00
Dan Stillman
6308ea6a18 Update reader submodule 2025-01-21 22:30:51 -05:00
Abe Jellinek
00c0679333 Add key to Advanced Search menuitem
Fixes #4978
2025-01-21 11:06:35 -05:00
Dan Stillman
296edc3fdd
Unset Mozilla environment variables when launching files and URLs (#4983)
Fixes #4981
2025-01-21 05:40:27 -05:00
Tom Najdek
a4414cc2f0
Remove last few legacy icons #3691 (#4996) 2025-01-21 05:37:56 -05:00
windingwind
67da025e3f
Fix attachments box race condition (#4997)
fix: #4611
Since the attachment preview already has a task queue,
don't skip render calls when rendering
2025-01-21 05:27:33 -05:00
Dan Stillman
810062a1af Remove reference to Zotero for Firefox in incompatible-DB error 2025-01-21 05:17:36 -05:00
Dan Stillman
850431af93 Fix display of button bar in sync error panel 2025-01-21 05:17:36 -05:00
Dan Stillman
e1cee8cc45 Don't try to initialize Places, since we removed its files 2025-01-21 05:17:36 -05:00
Martynas Bagdonas
b84f1a70f0 Update pdf-worker submodule and extract only worker.js from zip build
The pdf-worker zip builds now include cmaps and standard_fonts but in Zotero client we reuse them from Zotero Reader path
2025-01-20 19:12:50 +02:00
Adomas Venčkauskas
94650e2ee9 Fix integration session breaking when an error is thrown during getDocument() 2025-01-20 12:11:50 +02:00
windingwind
998315dd58
Fix menu popup dblclick on MacOS (#4989) 2025-01-17 13:00:01 -05:00
Abe Jellinek
e11d93f0bc
Restore whitespace in search Collection condition menu (#4990) 2025-01-16 23:13:06 -05:00
Dan Stillman
9f83790ed6 fx128: Fix broken update channel after an update on macOS
Don't delete ChannelPrefs.framework during updates
2025-01-16 19:05:43 -05:00
Abe Jellinek
c8051aa3f8 Scaffold: Make Defer checkbox interactive 2025-01-16 11:07:45 -05:00
Abe Jellinek
0bdae76e49 Scaffold: Cleanup 2025-01-16 10:39:05 -05:00
Yichao Yu
8cfcdeb8e6
Use uname -m instead of arch (#4982)
`uname` is used in the script elsewhere already and `arch` does not seem to be available everywhere
2025-01-13 23:37:49 -05:00
Dan Stillman
484eb1f1d7 Fix ids showing instead of creator names for creator autocomplete
https://forums.zotero.org/discussion/121089/beta-author-suggestions-broken-only-suggest-numbers-instead-of-names

Related Mozilla bugs (though I don't see a change that would be directly
responsible for this):

https://bugzilla.mozilla.org/show_bug.cgi?id=1886064
https://bugzilla.mozilla.org/show_bug.cgi?id=1910073
2025-01-13 02:36:28 -05:00
windingwind
524660e10b
Fix dense call to setItemDownloadPercentage freezes app (#4979) 2025-01-11 03:17:56 -05:00
abaevbog
459d00448a
Hide "Report" button from plugin context menu (#4976)
Fixes: #4975
2025-01-10 01:25:51 -05:00
Dan Stillman
52c342b697 Update ESLint and Babel
Updated ESLint is necessary for flat config changes from 54db192be8
2025-01-09 03:11:01 -05:00