windingwind
08e2be9875
fx140: fix item pane test further
...
Should call updateLayout after changing layout
Should wait for notify after saving object
2025-07-30 22:31:11 -04:00
windingwind
0ce54e2b14
Fix item pane test failure
...
fix : #5421
2025-07-30 22:31:11 -04:00
abaevbog
747a3f7a9f
fx140: remove sliding animation from panels ( #5423 )
2025-07-30 22:31:10 -04:00
Abe Jellinek
5af15f6496
fx140: Bring tabbox tabs back to the middle
...
And nudge them down a bit further.
2025-07-30 22:31:10 -04:00
Dan Stillman
4a5689e9b6
Restore rejection of last feed item when FeedReader terminates
...
Without this, the "should reject if the provided url is not a valid
feed" test fails
Follow-up to #5412
2025-07-30 22:31:10 -04:00
Abe Jellinek
c1270e635e
Overhaul testing in Scaffold ( #5301 )
2025-07-30 22:31:10 -04:00
abaevbog
2e135d035f
Fx140: do not use bluebird methods in citation dialog ( #5416 )
...
Instead, decide if the search should be skipped after
the delay based on the timestamps.
Fixes : #5414
2025-07-30 22:31:10 -04:00
Dan Stillman
0a33eeb0c0
Update translate submodule
2025-07-30 22:31:10 -04:00
Dan Stillman
4c51883b97
Restore Zotero.Promise.method() on ItemGetter#setAll()
...
Required for noWait translation
2025-07-30 22:31:09 -04:00
Dan Stillman
d797c7a4d8
BluebirdShimPromise: Add value() and fix isResolved() semantics
...
- value() is used in noWait export translation
- isResolved() technically means fulfilled or rejected -- unclear if we
ever depended on that, but it might as well be correct
2025-07-30 22:31:09 -04:00
abaevbog
dd5667c09b
fx140: update X icon for search cancel button ( #5417 )
...
searchfield-cancel.svg no longer exists, use close-12.svg
that is the same one used by search-textbox
2025-07-30 22:31:09 -04:00
windingwind
d1c6ee33be
Fix plugin API test failure
...
Fix : #5411
2025-07-30 22:31:09 -04:00
Abe Jellinek
a53e474f9c
Make filterStack() a no-op
2025-07-30 22:31:09 -04:00
Dan Stillman
e7805914f4
ConcurrentCaller: Increment numRunning in the correct place
2025-07-30 22:31:09 -04:00
Dan Stillman
0f560f4e4c
ConcurrentCaller: Fix return value in comment after Bluebird removal
2025-07-30 22:31:09 -04:00
Dan Stillman
5c172e3be9
ConcurrentCaller: Reject queued promises when stopping queue
...
Previously, we simply cleared the queue, leaving any pending promises
unresolved, and we checked for isResolved()/isPending() in
storageEngine.js (and maybe other places). storageEngine.js was changed
to simply await those promises, but that results in a hang if the queue
is stopped, since the promises were never resolved. Instead, when
stopping the queue, reject queued promises with a CanceledException and
ignore those promises in storageEngine.js.
2025-07-30 22:31:08 -04:00
Abe Jellinek
0a62553746
Remove remaining chai-as-promised method calls
2025-07-30 22:31:08 -04:00
Abe Jellinek
9442b7ee6c
Fix Zotero.Feed tests after chai-as-promised removal
2025-07-30 22:31:08 -04:00
Abe Jellinek
7e706354f9
Don't try to reject last feed item when FeedReader terminates
...
As the comment says, this hasn't been useful (and isn't used anywhere),
and I honestly don't understand how the test ever passed - process()
would've resolved all the feed item promises already.
Fixes #5412
2025-07-30 22:31:08 -04:00
Abe Jellinek
c8aff336b3
Migrate Bluebird methods in Zotero.Utilities.Internal.saveDocument()
...
Fixes #5415
2025-07-30 22:31:08 -04:00
Dan Stillman
26ffaf0ad3
Update translate module
...
Fixes test failure in fx140
2025-07-30 22:31:08 -04:00
Dan Stillman
f81763b173
Remove Chai as Promised
...
A test using `assert.eventually` was failing after the Bluebird removal
but worked with just `await`, and since there hasn't really been much
point to Chai as Promised since the introduction of `async`/`await` ages
ago, just remove the library instead of figuring out why.
2025-07-30 22:31:08 -04:00
Dan Stillman
26b6c70b96
Fix Libraries test after Bluebird removal
2025-07-30 22:31:07 -04:00
Dan Stillman
6809aa50ad
Fix item tree tests after Bluebird removal
...
Remove uses of PromiseInspection.value()
2025-07-30 22:31:07 -04:00
Dan Stillman
dc80fb2d50
fx140: nsIStringInputStream#setData() → setByteStringData()
2025-07-30 22:31:07 -04:00
Dan Stillman
1500fb9fa3
ConcurrentCaller: Revert to Promise.delay()
...
We're shimming it, and we override it with a stub in a syncAPIClient
test.
2025-07-30 22:31:07 -04:00
Dan Stillman
0bf4fc54c4
Remove uses of Promise.isFulfilled() in connector server tests
2025-07-30 22:31:07 -04:00
Dan Stillman
c2b6a9cc12
fx140: Fix NetUtil import in server tests
2025-07-30 22:31:03 -04:00
Dan Stillman
c4cfee1807
fx140: Fix additional mendeleyImport.mjs imports
2025-07-30 22:30:58 -04:00
Dan Stillman
b7c2002b63
Fix another Bluebird removal bug
...
Use of `Promise.map()`
2025-07-30 22:30:58 -04:00
Dan Stillman
e07ac6243c
Fix bug from Bluebird removal
...
Bluebird had a `Promise.filter` method
Fixes failing data directory tests
2025-07-30 22:30:58 -04:00
Abe Jellinek
9f038891ef
Set name for Zotero.DBConnection.TimeoutError
...
Fixes failing timeout test in dbTest.js.
2025-07-30 22:30:57 -04:00
Abe Jellinek
97dbcc6870
Restore timeout in dataObjectTest.js, fix test
...
OK, the timeout removed in 05e8da wasn't actually useless, but this test
was.
41706a changed erase() so it no longer forwards skipNotifier when
deleting child items. That means that we *would* get a notify() call for
the deleted child, so the test should have been failing.
However! Because of a bug in Bluebird's filtered catch() implementation,
Promise.TimeoutError wasn't recognized as an Error subclass, and it was
instead used as a predicate function, which would always pass.
So all errors were caught as "timeouts" and suppressed, making this test
always pass. Now it no longer always passes (but does pass with the
current behavior).
2025-07-30 22:30:57 -04:00
Abe Jellinek
6203b9712d
Fully asyncify feedTest.js
2025-07-30 22:30:57 -04:00
Abe Jellinek
b87bdeea41
Update asyncify script to handle more Mocha hooks
2025-07-30 22:30:57 -04:00
Abe Jellinek
20e75c3251
Remove Bluebird methods in concurrentCallerTest.js
...
This is really messy and not ideal, but these tests were written for
Bluebird Promise state inspection, and it's difficult to make them look
nice without that being available.
2025-07-30 22:30:57 -04:00
Abe Jellinek
2bc0afa830
Remove useless timeout() in dataObjectTest.js
2025-07-30 22:30:57 -04:00
Abe Jellinek
d9341bbf1a
Use alternate method to test feed check delay
2025-07-30 22:30:56 -04:00
Abe Jellinek
2b7535cd83
Fix test runner
...
By restoring ZOTERO_TEST=1 in runtests.sh after 711b336
2025-07-30 22:30:56 -04:00
Tom Najdek
7e1f4b8dbf
fx140: ESMify errorReport.xhtml
2025-07-30 22:30:56 -04:00
Abe Jellinek
52b4fc0b9d
Preferences: Fix sandbox destructor
2025-07-30 22:30:56 -04:00
windingwind
519c4cb518
fx140: Fix scaffold missing menubar
2025-07-30 22:30:56 -04:00
windingwind
db29ed6501
fx140: Fix Linux window control button position
2025-07-30 22:30:56 -04:00
windingwind
331ed31b1c
fx140: Fix Linux titlebar appearance
2025-07-30 22:30:56 -04:00
windingwind
2562871424
fx140: Fix menu icon overlap
...
Fix after #5343
2025-07-30 22:30:55 -04:00
Tom Najdek
4eae5bc658
Fix incorrect MendeleyImporter import path after ESMify
2025-07-30 22:30:55 -04:00
Abe Jellinek
f4a5ee0c7e
fx140: ESMify about.xhtml
2025-07-30 22:30:55 -04:00
Abe Jellinek
e4878052aa
fx140: Add draft macOS native-like textarea style
...
Firefox doesn't use any native textareas anymore, so I guess they just
removed/broke native textarea rendering.
2025-07-30 22:30:55 -04:00
Dan Stillman
072b2e3285
Force Firefox refetch when switching to older branch
2025-07-30 22:30:55 -04:00
Dan Stillman
ac32c0fd8b
Add Firefox build script for Linux
2025-07-30 22:30:55 -04:00
