Todd Gruben
fe8756927c
manual gofmt
2018-09-14 15:40:37 -05:00
Todd Gruben
51e57ad550
code cleanup
2018-09-14 14:46:02 -05:00
tgruben
eb7af13be2
Merge branch 'master' into bounds-check
2018-09-14 14:37:23 -05:00
Travis Turner
55bb12a434
Merge pull request #1643 from travisturner/generate-update
...
re-generate the apimethod stringer
2018-09-14 10:32:16 -05:00
Todd Gruben
136ee7beab
updated comments and gofmt
2018-09-14 10:27:33 -05:00
Travis Turner
2223b23b95
re-generate the apimethod stringer
2018-09-14 09:40:48 -05:00
Travis Turner
734c31d963
Merge pull request #1622 from travisturner/roaring-import
...
Roaring import
2018-09-13 22:43:20 -05:00
Matt Jaffee
495af54c10
Merge branch 'master' into roaring-import
2018-09-13 15:50:16 -05:00
Matt Jaffee
870c5e131f
replace waitgroup with errgroup to avoid race on err
2018-09-13 15:27:00 -05:00
Matt Jaffee
f943c17e0b
ImportRoaring, add remote arg, fix data copy bug
...
also, handle err properly in client method instead of discarding.
2018-09-13 15:05:05 -05:00
Matt Jaffee
b412309447
rename standard roaring to "official" throughout
2018-09-13 13:38:18 -05:00
Matt Jaffee
b2ec5e373e
fixup explanatory comment
2018-09-13 13:33:51 -05:00
Matt Jaffee
7b0d4d75b4
remove validators on import-roaring and test handler
...
validators are for query args, not url vars. Also some misc cleanup and error
handling in the handler.
2018-09-13 13:14:35 -05:00
Matt Jaffee
fd655c998e
rename all instances of roaringbytes
...
function names now importRoaring and byte slice args are just called data. Also
renamed http endpoint from /importroaring to /import-roaring
2018-09-13 12:27:23 -05:00
Matt Jaffee
9e7cfeedc9
readability changes in fragment.go
2018-09-13 11:41:46 -05:00
Matt Jaffee
af7d405b11
add explanatory comment and move comment to correct spot
2018-09-13 10:41:36 -05:00
Matt Jaffee
f006df7758
re-order ImportRoaringBytes args to be more consistent
2018-09-13 10:39:00 -05:00
Matt Jaffee
c6817340c7
rename sliceWidth->shardWidth
2018-09-13 10:31:58 -05:00
Matt Jaffee
79c783eaf8
add nolint directive
...
there isn't much piont in making snapshot take a WriterTo, because the only
thing that's going to be written to a fragment is a roaring bitmap. making it
WriterTo just makes it slightly more annoying to jump into the Bitmap.WriterTo
implementation. since it's a private function, it should be straightforward to
change this in the future if the need arises.
2018-09-12 17:31:57 -05:00
Matt Jaffee
4a5f12631c
more naked returns
2018-09-12 17:29:35 -05:00
Matt Jaffee
d0d0bdd722
simplify fragment.unprotectedRow (unparam)
2018-09-12 17:25:12 -05:00
Matt Jaffee
3bc9c66f5e
remove some naked returns and simplify
2018-09-12 17:21:17 -05:00
Matt Jaffee
70e9da3b75
fmt -s fragment_internal_test
2018-09-12 17:13:07 -05:00
Matt Jaffee
f8569102f5
update some fragment comments re: the cache
2018-09-12 17:10:28 -05:00
Matt Jaffee
3ea07ae3a7
use cache.Recalculate instead of Invalidate for imports
...
Invalidate does not always rebuild the cache - if the last rebuild is < 10s ago,
it does nothing. We always want to rebuild the cache after imports.
Also updated the comments around recalculate/invalidate to clarify.
2018-09-12 17:07:46 -05:00
Matt Jaffee
14a8362261
roaring import - add cache invalidate and broken test
2018-09-12 16:48:07 -05:00
Matt Jaffee
b5a14de1fd
roaring import: fix api doc, refactor/rename, test merge
2018-09-12 16:11:51 -05:00
Matt Jaffee
a3243f99e1
linter fixes - reorder return vals, remove unused const
2018-09-12 13:24:59 -05:00
Todd Gruben
156260e68e
roaring allowed import to merge with existing data
2018-09-12 13:20:07 -05:00
Matt Jaffee
8254d0fadd
improve import roaring docs, check errors
2018-09-12 12:08:57 -05:00
Matt Jaffee
d3717e2afe
make Bitmap.UnmarshalBinary work for roaring or pilosa format
2018-09-12 10:50:05 -05:00
Matt Jaffee
cf47950bd7
gofmt all
2018-09-12 10:06:03 -05:00
Travis Turner
6a15ceb4ed
Merge pull request #1635 from travisturner/not
...
implements Not() query
2018-09-12 09:21:14 -05:00
Travis Turner
424ca9378a
fixing a copy/paste issue in the Not() docs
2018-09-12 09:20:31 -05:00
Travis Turner
d78d9511ed
Merge branch 'master' into not
2018-09-12 08:49:04 -05:00
Yuce Tekol
c5e86e0395
Merge pull request #1636 from yuce/options-call-docs
...
Added docs for the Options call
2018-09-12 15:43:07 +03:00
Yuce Tekol
63f1b65c0a
updated Options docs
2018-09-12 00:59:44 +03:00
Yuce Tekol
b1af66a427
updated Options docs
2018-09-12 00:57:45 +03:00
Yuce Tekol
e4b5449388
Merge branch 'master' into options-call-docs
2018-09-12 00:54:21 +03:00
Yuce Tekol
ec9371aae4
Updated Options docs
2018-09-12 00:53:40 +03:00
Cody Soyland
e13434a253
Merge pull request #1634 from codysoyland/metalinter-deadline-increase
...
Increase gometalinter deadline so CI stops failing
2018-09-11 16:41:25 -05:00
Cody Soyland
6944be7033
Merge branch 'master' into metalinter-deadline-increase
2018-09-11 16:23:46 -05:00
Yuce Tekol
96893e2e9f
Merge branch 'master' into options-call-docs
2018-09-12 00:04:52 +03:00
Yuce Tekol
2dcdd9614c
Added docs for the Options call
2018-09-12 00:01:22 +03:00
Matthew Jaffee
c3dfb7f581
Merge pull request #1612 from jaffee/1609-log-race
...
remove unused log buffers from test cluster, fixes race
2018-09-11 15:42:22 -05:00
Cody Soyland
c05d751516
Merge branch 'master' into metalinter-deadline-increase
2018-09-11 15:39:42 -05:00
Travis Turner
319456bbd7
implements Not() query
2018-09-11 15:29:43 -05:00
Matt Jaffee
4ea48e1b40
remove unused log buffers from test cluster, fixes race
...
the buffers were unused internally and external users had no access to them.
Those wishing to read the logs of the cluster in tests may replace stdout/stderr
with buffers on the Command struct.
The race occurred when a node was stopped and then started again. some
memberlist goroutines might not be completely cleaned up by the time the node
restarted, and then two loggers were using the same output buffer.
2018-09-11 15:28:16 -05:00
Travis Turner
3315c9e35c
Merge pull request #1628 from travisturner/not-null-field
...
implement NotNull field with index option trackNotNull
2018-09-11 15:27:03 -05:00
Travis Turner
a89e1c521b
benchmark import instead of set on existence field
2018-09-11 15:15:37 -05:00
