Matt Jaffee
fe7b926773
make sure more tests and benchmarks can have their temp dir set by flag
...
This is to allow the directory to be set to where a particular disk is mounted
during benchmarking.
2019-01-21 16:23:27 -06:00
Matthew Jaffee
1c470e4c10
Merge pull request #1834 from seebs/seebs/deadlock
...
prevent deadlock in replication logic on reopening a store
2019-01-21 16:21:46 -06:00
Matthew Jaffee
3bbd3cbfb1
Merge branch 'master' into seebs/deadlock
2019-01-21 15:33:41 -06:00
Matthew Jaffee
7b8589bdab
Merge pull request #1835 from jaffee/log-nil-fix
...
pass loggers around properly in gossip
2019-01-21 15:33:22 -06:00
Matt Jaffee
bb9f3a95d2
move legacy field check to non-concurrent code
2019-01-21 15:17:33 -06:00
Matt Jaffee
44270fe9fd
rename memberlist.logger and add explanatory comments
2019-01-21 14:47:02 -06:00
Matt Jaffee
6f4dee5e31
pass loggers around properly in gossip
2019-01-21 14:47:02 -06:00
Matthew Jaffee
36c38808f4
Merge pull request #1837 from jaffee/staticcheck-fixes
...
Staticcheck fixes (lint)
2019-01-21 14:46:23 -06:00
Matt Jaffee
20e06b7b0f
fix direct usage of std log instead of configured logger
2019-01-21 14:39:24 -06:00
Matt Jaffee
f1ecead069
fix failing tests due to staticcheck fixes
2019-01-21 14:38:58 -06:00
Matt Jaffee
daa87d8e12
fix staticcheck warnings
2019-01-21 14:24:11 -06:00
Yuce Tekol
d0f7115c91
Merge pull request #1830 from yuce/1805-rows-call-format
...
Fixes #1805 . Fixes Store call error messages
2019-01-21 22:31:43 +03:00
seebs
7961f87430
Merge branch 'master' into seebs/deadlock
2019-01-21 13:31:21 -06:00
Yuce Tekol
b898460a18
Merge branch 'master' into 1805-rows-call-format
2019-01-21 18:35:05 +03:00
Yuce Tekol
1d3fafa207
trivial
2019-01-21 18:32:58 +03:00
Travis Turner
2e6635ec6d
Merge pull request #1836 from travisturner/cluster-nodes-rlock
...
cluster.Nodes() just needs a read lock
2019-01-21 09:30:50 -06:00
Yuce Tekol
511f7de422
added staticcheck to gometalinter target
2019-01-21 18:29:42 +03:00
Yuce Tekol
7531c337a9
removed megacheck from metalienter target
2019-01-21 18:23:40 +03:00
Yuce Tekol
21c0a5e3de
Merge branch 'master' into 1805-rows-call-format
2019-01-21 18:03:50 +03:00
Yuce Tekol
773d661b68
GroupBy legacy Rows
2019-01-21 18:02:51 +03:00
Travis Turner
fc1de2dba9
cluster.Nodes() just needs a read lock
2019-01-18 14:49:58 -06:00
Seebs
cd534af430
prevent deadlock in replication logic on reopening a store
...
Depending on where in the replicate() loop you are when a
store is closed or reassigned, it's possible for it to deadlock.
The deadlock would be that replicate has just successfully read an
entry from your PrimaryTranslateStore.Reader, when a new
PrimaryTranslateStore event happens. Then handlePrimaryTranslateStore
grabs the mutex, signals that the replication handler should
close, and waits for the replication handler to close. Meanwhile,
the replicate() loop tries to grab the mutex... and deadlocks.
Solution: Make the replicate() loop part that needs the mutex
a goroutine that signals on a channel, so we can put it in a select
along with checking for the replicationClosing signal (or the
context terminating). If one of those happens, replicate()
terminates, allowing monitorReplication() to return, which
causes the anonymous function which called it to call
repWG.Done(), allowing handlePrimaryTranslateStore to continue
and eventually release the mutex. At some later point, appendEntry
succeeds or fails, dumps its result status in a buffered
channel, and exits, and the buffered channel is garbage collected.
This is way simpler than it sounds, but it took me a while
to figure out how simple it was.
2019-01-18 13:24:24 -06:00
seebs
8762c2a4dc
Merge pull request #1763 from seebs/seebs/bench
...
improve sliceascending/slicedescending benchmarks.
2019-01-18 09:17:00 -06:00
Yuce Tekol
ca7dc073ab
Merge branch 'master' into 1805-rows-call-format
2019-01-18 17:48:58 +03:00
Yuce Tekol
5fb82ac7b3
Rows sets _field if field is set
2019-01-18 17:46:20 +03:00
Yuce Tekol
c30f9bc192
Rows accepts a fields param for backward compat.
2019-01-18 17:41:54 +03:00
seebs
a2005d556c
Merge branch 'master' into seebs/bench
2019-01-17 23:43:15 -06:00
Travis Turner
86e9456afc
Merge pull request #1826 from travisturner/error-time-nostandardview
...
raise an error on Rows() query against a time field with noStandardView: true
2019-01-17 21:36:44 -06:00
Travis Turner
9ce319eeee
Merge branch 'master' into error-time-nostandardview
2019-01-17 14:48:36 -06:00
Matthew Jaffee
6f21eb32de
Apply suggestions from code review
...
Co-Authored-By: travisturner <travis@pilosa.com>
2019-01-17 14:47:35 -06:00
seebs
7857730b7f
Merge branch 'master' into seebs/bench
2019-01-17 13:48:19 -06:00
Yuce Tekol
dc735c17b8
Fixes #1805 . Fixes Store call error messages
2019-01-16 20:52:33 +03:00
seebs
63255315b1
Merge pull request #1820 from seebs/seebs/setvaluebenchmarks
...
setValue test and benchmark updates
2019-01-15 16:00:27 -06:00
seebs
4e592b4b8a
Merge branch 'master' into seebs/setvaluebenchmarks
2019-01-15 15:04:41 -06:00
Travis Turner
173bfb8b3c
Merge pull request #1827 from travisturner/keep-sample-fragment-data
...
don't delete test fragment data (part of repo)
2019-01-15 11:39:35 -06:00
Travis Turner
0a8bd6548b
don't delete test fragment data (part of repo)
2019-01-14 17:15:30 -06:00
Travis Turner
44f53a5f1d
raise an error on Rows() query against a time field with noStandardView:true
2019-01-14 16:14:45 -06:00
Yuce Tekol
897221a24e
Merge pull request #1824 from yuce/1823-fix-row-range-default-to-updated-docs
...
fixes #1823 . Updates tests and docs for row range
2019-01-15 00:27:20 +03:00
Yuce Tekol
76de81dacf
updated row range test
2019-01-14 23:46:34 +03:00
Yuce Tekol
d75e9eb772
updated row range test
2019-01-14 23:45:58 +03:00
Yuce Tekol
600b39e4e5
updates row range test with a timestamp > the default end timestamp
2019-01-14 23:40:31 +03:00
Yuce Tekol
9f6d489be8
fixes #1823 . Updates tests and docs for row range
2019-01-14 14:39:08 +03:00
Travis Turner
01f54c1f70
Merge pull request #1822 from travisturner/range-between-bug
...
fixes a bug on upper end of bsi range queries
2019-01-11 17:27:28 -06:00
Travis Turner
f7e3296f62
fixes a bug on upper end of bsi range queries
2019-01-11 17:05:29 -06:00
Travis Turner
b0d0105e79
Merge pull request #1818 from travisturner/groupby-filter-test
...
add a test for groupby filter with RangeLTLT
2019-01-11 16:06:39 -06:00
Travis Turner
0b1fb73b14
add a test for groupby filter with RangeLTLT
2019-01-10 16:56:10 -06:00
Matthew Jaffee
f101cb17b5
Merge pull request #1821 from jaffee/verbose-to-ci-race-tests
...
add verbose flag to circle ci race test to help debug timeout
2019-01-10 16:36:49 -06:00
Matt Jaffee
93b6048263
add verbose flag to circle ci race test to help debug timeout
2019-01-10 16:12:54 -06:00
Seebs
07674d859c
setValue test and benchmark updates
...
This provides a simple benchmark that can be used for
setValue, to give a way to compare results from adding BSI
support to roaring. Use the BSIGroup prefix for the
fragments, and specify a cache type of "none", to prevent
the use of a LRU cache (which makes things more expensive).
Add a parallel benchmark for ImportValue, so we can compare
them. (Unsurprisingly, the bulk-import endpoint is quite a
lot faster.)
Also, add a test for clearing values to the TestFragment_Sum
test; it turns out that this was never tested in this code,
but the http client test would test it and verify it, it should
probably also be tested here.
2019-01-10 12:07:04 -06:00
Travis Turner
7f6f9be88e
Merge pull request #1817 from travisturner/issue-template
...
reverse the order of items in the github issue template
2019-01-10 11:06:45 -06:00
