Merge pull request #1836 from travisturner/cluster-nodes-rlock

cluster.Nodes() just needs a read lock
This commit is contained in:
Travis Turner 2019-01-21 09:30:50 -06:00 • committed by GitHub
commit 2e6635ec6d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -609,8 +609,8 @@ func (c *cluster) addNodeBasicSorted(node *Node) bool {
// Nodes returns a copy of the slice of nodes in the cluster. Safe for
// concurrent use, result may be modified.
func (c *cluster) Nodes() []*Node {
c.mu.Lock()
defer c.mu.Unlock()
c.mu.RLock()
defer c.mu.RUnlock()
ret := make([]*Node, len(c.nodes))
copy(ret, c.nodes)
return ret