Commit graph

9081 commits

Author SHA1 Message Date
Todd Gruben
d322cc7aef batch size 65536 2022-03-11 06:20:07 -06:00
souhailanoor
ac450a0c95
Merge pull request #1969 from molecula/fb-1186-updates
FB-1186: make deletes concurrent
2022-03-10 17:11:23 -06:00
souhailanoor
7c8fde3bd6
Merge branch 'master' into fb-1186-updates 2022-03-10 16:18:50 -06:00
Souhaila Noor
a7b849c5fa release read tx 2022-03-10 16:18:39 -06:00
Matthew Jaffee
85ea078e86
Merge pull request #1972 from molecula/remove-circle
Remove CircleCI config
2022-03-10 14:52:20 -06:00
souhailanoor
c67b8f6653
Merge branch 'master' into fb-1186-updates 2022-03-10 13:15:55 -06:00
Matthew Jaffee
92562e547e remove old circle CI config 2022-03-10 11:41:35 -06:00
Samir Patel
4baec78303
Merge pull request #1944 from molecula/bug-primary-ingest
[FB-1082] retry request on primary host
2022-03-10 12:23:47 -05:00
souhailanoor
c0db6670c9
Merge branch 'master' into fb-1186-updates 2022-03-10 10:29:35 -06:00
Samir Patel
48997347b9 add server side redirect to primary for ingest requests
this applies to handlePostIngestData, handlePostIngestSchema

also moves a helper method (ApplyOneIngestSchema) from
http handler to API
2022-03-10 10:22:13 -06:00
Samir Patel
17e8dbd318 client side retry ingestAPI requests on primary host
If non-primary host fails to process a request, retry on primary node.

conditions when we should not do this:
- no error
- we've aleady tried the primary
- we're making a status request to get the primary node...this
  could lead to lock contention if we allow it to happen as we are
  making an http request within an on going http request to discover
  the primary node.

This also deletes the RemoveHost method and the associated test b/c
it is not used anywhere anymore and updates the returned error type.
2022-03-10 10:22:13 -06:00
tgruben
000eccae46
Merge pull request #1971 from molecula/SUP-178
[FB-1247] undo bitmapN fix
2022-03-10 10:21:11 -06:00
Souhaila Noor
f653457b5a address reviewer's comments 2022-03-10 09:36:18 -06:00
Todd Gruben
57b8dcd43a go fmt 2022-03-10 09:03:07 -06:00
tgruben
52e9027c79
Update roaring.go 2022-03-10 08:26:07 -06:00
Todd Gruben
09a9932951 extra protection of bitmapToArray 2022-03-10 07:48:51 -06:00
Todd Gruben
4a6c0ab086 bitmapN not reliable et 2022-03-09 21:02:39 -06:00
Souhaila Noor
37f43d7d6f added concurrency for delete during start-up 2022-03-09 09:40:08 -06:00
Ben Johnson
b7c93072d4
Merge pull request #1966 from molecula/fb-1239
[FB-1239] Free previous RBF bitmap pointer page when replacing container
2022-03-09 08:13:02 -07:00
Ben Johnson
7cad6d2973 Free previous RBF bitmap pointer page when replacing container 2022-03-08 15:05:23 -07:00
tgruben
5545bc5e8e
Merge pull request #1967 from molecula/SUP-170-upgrade-go
[FB-1244] bump go to go 1.17.7
2022-03-08 09:52:42 -06:00
Todd Gruben
8c247ff419 bump go to go 1.17.7 2022-03-08 08:38:07 -06:00
hphamMolecula
f7639e4a0b
Merge pull request #1954 from molecula/fb-1188-ttl
FB-1188 - Added TTL field option
2022-03-08 03:59:43 -06:00
tgruben
c3ac40991f
Merge branch 'master' into fb-1188-ttl 2022-03-07 16:57:38 -06:00
Hoang Pham
8b19e7a9e1 FB-1188 - removed parseDuration error logs in proto.go 2022-03-07 11:45:29 -06:00
seebs
fae3376581
Merge pull request #1965 from molecula/fb1240
[FB-1240] handle BitN when updating an existing bitmap pointer cell
2022-03-07 11:22:33 -06:00
Hoang Pham
49cf5c8817 FB-1188 - improved description of TTL 2022-03-07 11:16:33 -06:00
Seebs
d8b9a921b8 handle BitN when updating an existing bitmap pointer cell
We have code to correctly fill in cell.BitN when a leaf cell already
exists but isn't of the correct sort, but not to handle the case where
it already exists and *is* a BitmapPtr, but doesn't necessarily have
the right BitN value.
2022-03-07 09:16:16 -06:00
tgruben
806a8875a2
Merge branch 'master' into fb-1188-ttl 2022-03-07 07:42:56 -06:00
Travis Turner
30424499fa
Merge pull request #1813 from molecula/tlt/tx-comments
Clean up some of the go-doc entries in tx.go
2022-03-04 15:30:01 -06:00
Travis Turner
c4bc78bb36
Merge branch 'master' into tlt/tx-comments 2022-03-04 15:05:39 -06:00
tgruben
0e819b7d7a
Merge branch 'master' into fb-1188-ttl 2022-03-04 11:30:46 -06:00
seebs
aed3fc7fee
Merge pull request #1963 from molecula/fb1235
[FB-1235] Don't deadlock on multiple simultaneous CreateField
2022-03-04 11:20:21 -06:00
Seebs
9135b41ca8 test multiple field creations at once on a cluster
This test tries to verify that we can create multiple fields on a cluster
without deadlocking or getting errors *other than* ErrFieldExists or
wrappers of it. The "or wrappers of it" implies a change to ConflictError's
semantics, but honestly I think it should have had those semantics all along.
2022-03-04 10:21:18 -06:00
Seebs
bc6947a9ac try not to deadlock on simultaneous CreateField to two nodes in a cluster
Two CreateField messages reaching different nodes in a cluster at the same
time could cause a deadlock because each CreateField runs with a write lock
held, then issues requests to other nodes which, at a minimum, need
a read lock and which may require a write lock. Reorder things a bit to
make the broadcast to other nodes happen outside the lock. We may also
need to do something to have nodes handle the case where something's been
created in etcd but they haven't gotten the message about it yet.
2022-03-04 10:21:18 -06:00
Samir Patel
be5cffff32
Merge pull request #1964 from molecula/sql-where-testcases
[FB-1226 FB-1227] Add tests for sql WHERE clause with timestamps
2022-03-04 11:02:38 -05:00
Samir Patel
2ebb4d1865 add tests for sql WHERE clause with timestamps
Creates a timestamp field in the TestSQLQuery dataset.

Modifies a helper function to allow datasets with
timestamp to be properly converted to table responses.

Adds test cases for:
- conditional where clauses
- where clause with group by
- timestamp within where clause
- select distinct with where clause
2022-03-03 22:20:49 -06:00
Hoang Pham
4f32938ec8 FB-1188 - format server.go 2022-03-03 17:14:41 -06:00
Hoang Pham
5314f24bb1 FB-1188 - added back disco import that was accidently removed from merge conflict 2022-03-03 16:23:55 -06:00
Hoang Pham
31aa5ceaa4 Merge branch 'fb-1188-ttl' of ssh://github.com/molecula/featurebase into fb-1188-ttl 2022-03-03 16:20:11 -06:00
Hoang Pham
5f640aab0c FB-1188 - Fixed ttl parseDuration 2022-03-03 16:19:29 -06:00
hphamMolecula
a7a9722722
Merge branch 'master' into fb-1188-ttl 2022-03-03 16:12:42 -06:00
Hoang Pham
6d18d9e0c4 FB-1188 - added more unit tests 2022-03-03 16:09:37 -06:00
Ben Johnson
32fb80960a
Merge pull request #1962 from molecula/fb-1237
[FB-1237] Revert auto-quoting in Web UI
2022-03-03 13:01:45 -07:00
Ben Johnson
d9ad819fe9 Revert auto-quoting in Web UI 2022-03-03 12:35:54 -07:00
Matthew Jaffee
b7469acb04
Merge pull request #1952 from molecula/1222-release-format
FB-1222 release format
2022-03-02 15:25:45 -06:00
Matthew Jaffee
3fc271ff07 change release format
This was in response to some feedback we got about the new release
format. Executables were no longer had executable permission due to
going through S3 (hence the tarballs), and we wanted a more consistent
directory structure in the final release which included the versions
of various components.
2022-03-02 14:39:41 -06:00
reesporte
2f6aed74e6
Merge pull request #1956 from molecula/fb-1127
remove /schema/details cardinality calculation, and schemaDetailsOn config option
2022-03-02 14:37:53 -06:00
reesporte
17203e3441 remove cardinality calculation from schema/details
this is related to work for [fb-1127](https://molecula.atlassian.net/browse/FB-1127)

cardinality reporting has caused no shortage of issues such that we recommend
disabling them almost everywhere.

this commit removes the cardinality calculation for right now, as well as the option
to enable/disable schema details.
2022-03-02 14:09:09 -06:00
Hoang Pham
d883d4de53 FB-1188 - TTL - added more unit tests 2022-03-02 12:46:21 -06:00