scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-08-28 10:54:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

address reviewer's comments

Browse source
This commit is contained in:
Souhaila Noor 2022-03-10 09:36:18 -06:00
parent 37f43d7d6f
commit f653457b5a
2 changed files with 22 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
holder.go
View file

@ -344,13 +344,15 @@ func (h *Holder) processDeleteInflight() error {
g.Go(func() error {
for shard := range ch {
if err := h.deletePerShard(index, shard); err != nil {
return err
return fmt.Errorf("delete shard %d: %w", shard, err)
}
}
return nil
})
}
g.Wait()
if err := g.Wait(); err != nil {
return err
}
}
}
return nil

33
holder_internal_test.go
View file

@ -94,21 +94,24 @@ func TestHolder_ProcessDeleteInflight(t *testing.T) {
}
for _, test := range tests {
idx, f := test.idx, test.f
tx := idx.Txf().NewTx(Txo{Write: false, Index: idx1, Shard: uint64(0)})
defer tx.Rollback()
for _, r := range rowCol {
row, err := f.Row(tx, r.row)
if err != nil {
t.Fatalf("failed to get row: %v", err)
func() {
idx, f := test.idx, test.f
tx := idx.Txf().NewTx(Txo{Write: false, Index: idx1, Shard: uint64(0)})
defer tx.Rollback()
for _, r := range rowCol {
row, err := f.Row(tx, r.row)
if err != nil {
t.Fatalf("failed to get row: %v", err)
}
existenceRow, err := idx.existenceFld.Row(tx, r.row)
if err != nil {
t.Fatalf("failed to get row: %v", err)
}
if len(row.Columns()) != 0 || len(existenceRow.Columns()) != 0 {
t.Fatalf("expected columns for fields to be empty after delete")
}
}
existenceRow, err := idx.existenceFld.Row(tx, r.row)
if err != nil {
t.Fatalf("failed to get row: %v", err)
}
if len(row.Columns()) != 0 || len(existenceRow.Columns()) != 0 {
t.Fatalf("expected columns for fields to be empty after delete")
}
}
}()
}
}