Nia Weiss
beea6c7143
address review comments for #989 translate-maybe
2020-10-23 15:22:09 -04:00
Nia Weiss
4b61b1cef3
add basic tests for queries with missing keys
2020-10-23 15:21:37 -04:00
Nia Weiss
064d267d1e
re-apply single equals fix
2020-10-23 15:21:10 -04:00
Nia Weiss
6d6b2de374
finish translate-if-exists
2020-10-23 15:21:10 -04:00
Nia Weiss
78f87c6bb0
cleanup of key translation fix
2020-10-23 15:21:06 -04:00
Nia Weiss
8474854dd3
deal with linter false positives
2020-10-23 15:14:22 -04:00
Nia Weiss
c9928b0c7f
the tests pass now
2020-10-23 15:13:54 -04:00
Nia Weiss
b495035405
add some validation
2020-10-23 15:12:10 -04:00
Nia Weiss
fbe216099c
fix find & create foreign index keys
2020-10-23 15:11:09 -04:00
Nia Weiss
aa4a4484eb
it mostly works now
2020-10-23 15:11:07 -04:00
Nia Weiss
19b4e72f39
query translation WIP
2020-10-23 14:58:19 -04:00
Nia Weiss
8032f9daf5
test new translation paths via API
2020-10-23 14:55:43 -04:00
Nia Weiss
dc008110b5
address review comments
2020-10-23 14:55:43 -04:00
Nia Weiss
473c079697
apply "maybe" key translation WIP
2020-10-23 14:55:36 -04:00
Matthew Jaffee
451ced5e33
Merge pull request #980 from jaffee/equalsdatarace2.1
...
Fix data race in executor when processing int with single '='
2020-10-15 09:12:52 -05:00
Matt Jaffee
937bc271de
fix data race on call map in single = logic
...
This moves the code which modifies the PQL call object if a Row query
on an int field uses a single = instead of ==. Instead of processing
this at the shard level, we'll process it during the initial
translation step so that it isn't operated on concurrently.
2020-10-15 07:41:41 -05:00
Matt Jaffee
a293f864f2
add test of single = int query over multiple shards
2020-10-14 16:12:24 -05:00
Nia
12af1b56c3
Merge pull request #962 from niaow/all-writeable
...
Make all query translations writeable
2020-10-12 14:26:19 -04:00
Nia Weiss
fa481c91de
remove meaningless Writeable function
2020-10-12 14:18:38 -04:00
Nia Weiss
420b44a79a
make all query translations writeable
2020-10-12 11:33:04 -04:00
Nia
6fa8ead5ff
Merge pull request #954 from niaow/v2.1-fix-nil-grpc
...
Fix handling of nil in grpc responses
2020-10-09 12:31:56 -04:00
Nia Weiss
ad9f33cdc4
fix handling of nil in grpc responses
2020-10-09 12:01:46 -04:00
Nia
4c47836732
Merge pull request #943 from niaow/revert-inspect-ungarbage
...
Remove "fix" for inspecting garbage keys
2020-10-08 14:39:04 -04:00
Nia Weiss
9f7225b149
delete commented-out broken code in inspect
2020-10-08 13:21:30 -04:00
Nia
2805b22975
Merge pull request #946 from niaow/v2.1-split-batches
...
Split query batches in the executor
2020-10-08 13:18:22 -04:00
Nia Weiss
27289c5f35
split query batches in the executor
...
We previously had some significant bugs in which our error handling for translation would cause an entire batch of queries to silently fail.
This change processes each call seperately, such that all executable queries are processed.
2020-10-08 09:53:11 -04:00
Nia Weiss
195c6f7704
remove "fix" for inspecting garbage keys
...
Inspect was changed to discard garbage keys.
Unfortunately, this change was incorrect, and users of inspect do not expect this.
2020-10-07 12:14:44 -04:00
Nia
33af6c1ac7
Merge pull request #937 from niaow/v2.1-break-inspect-more
...
Restore creation of column keys in inspect when they do not exist
2020-10-06 14:00:19 -04:00
Nia Weiss
da157a5aa4
restore creation of column keys in inspect when they do not exist
...
This sounds completely conterintuitive but everything relies on it.
2020-10-06 12:43:46 -04:00
Matthew Jaffee
fe47d4764e
Merge pull request #930 from jaffee/pr224-on-2.1
...
ensure that Inspect generates a result for every header item
2020-10-05 19:24:23 -05:00
Jason Aten
8c5a2d4a6d
ensure that Inspect generates a result for every header item
...
This was previously done for the path where an index did not have keys
and this commit does it for the paths which do have keys.
This was originally two commits as there was some tricky cases that
needed multiple else statments within a single type.
2020-10-05 17:06:16 -05:00
Travis Turner
5e79e224f2
Merge pull request #821 from travisturner/container-thaw-v21
...
remove container thaw in test; use repair instead
2020-10-05 12:23:27 -05:00
Matthew Jaffee
adae58b800
Merge pull request #896 from molecula/2.1.4-backport-822-intgrtn-tests
...
fix inspect panic from incorrect handling of the many types of empty …
2020-09-24 20:14:08 -05:00
Nia Weiss
fb4822f22c
fix inspect panic from incorrect handling of the many types of empty argument
2020-09-24 16:36:01 -05:00
Matthew Jaffee
75d857ead2
Merge pull request #890 from molecula/v2.1.4
...
V2.1.4
2020-09-23 13:25:50 -05:00
Matthew Jaffee
a3f7cc0bbc
Merge pull request #894 from jaffee/2.1.4-plus-882-inspect-fix
...
Fix holes in grpc response for inspect
2020-09-23 13:20:21 -05:00
Kuba Podgórski
4dde0f9878
Fix holes in grpc response for inspect
...
Had to remove QuerySQLUnary stuff from grpc_test.go since that was testing functionality which has added by the VDSM collapse and we're backporting this fix onto 2.1 which is pre-VDSM collapse
2020-09-23 11:58:52 -05:00
Jason Aten
060db4e412
builds
2020-09-18 16:34:03 -05:00
Jason Aten
f9944e6498
add 732
2020-09-18 16:31:29 -05:00
Kuba Podgórski
4b0789ebf0
Merge pull request #732 from kuba--/translatekey-writable
...
Add writable argument to TranslateKey functions.
2020-09-18 16:23:46 -05:00
tgruben
450ae490a5
Merge pull request #868 from molecula/with_primary_instead_owner
...
Translate only on coordinator/primary
2020-09-18 14:02:22 -05:00
Kuba Podgórski
d77cdb745a
Merge pull request #853 from kuba--/fix-translate_index_keys
...
Fix translation index keys
2020-09-18 13:54:14 -05:00
Kuba Podgórski
6348956850
Merge pull request #847 from kuba--/fix-writable
...
Fix TranslateStore writable
2020-09-18 13:36:39 -05:00
Travis
77410bbd1d
remove container thaw in test; use repair instead
2020-09-08 15:47:08 -05:00
Matthew Jaffee
817d6f1498
Merge pull request #754 from molecula/backport-nondeleting-fix
...
Backport nondeleting fix
2020-09-02 16:48:16 -05:00
Seebs
1f2868f059
when updating a container, drop the single-container cache
...
This can cause incredibly weird and hard-to-debug problems if the previous
container value is still in the cache after an update, and in particular,
can result in having a stale container value cached after a roaring import
that modified the container. Coupled with another bug which could corrupt
containers on a delete, this produces a very strange bug where a value is
present in a fragment, but an attempt to delete it reports failure.
2020-08-28 11:10:13 -05:00
Travis
6cd5b4fbbd
stop setting N on a frozen container
2020-08-28 11:09:36 -05:00
Travis Turner
76dbedc082
Merge pull request #640 from travisturner/backport-executeclearrow
...
safe cast of bool in executeClearRow
2020-08-04 17:18:33 -05:00
Travis
f80b787de0
safe cast of bool in executeClearRow
2020-08-04 15:54:48 -05:00
Travis Turner
fc15489124
Merge pull request #598 from travisturner/backport-bug-fixes
...
Backport bug fixes
2020-07-23 11:49:09 -05:00
