- Deleted GlamaHandler export from providers index.
- Removed Glama callback handling from ClineProvider.
- Updated tests to exclude Glama API key and model checks.
- Removed Glama-related configurations from ProfileValidator and validation functions.
- Eliminated Glama components and settings from the UI.
- Cleaned up localization files by removing Glama-specific entries.
- Updated API utility functions to exclude Glama authentication.
* refactor: Unify history item UI with TaskItem and TaskItemHeader
Introduces `TaskItem.tsx` and `TaskItemHeader.tsx` to centralize and
standardize the rendering of history entries. `TaskItem` handles the
overall structure for "compact" (Preview) and "full" (HistoryView)
variants. `TaskItemHeader` consolidates all metadata (timestamp, tokens,
cost, cache, file size) into a single, consistent line above the task
content, enhancing visual clarity and reducing UI clutter.
This refactor significantly simplifies `HistoryPreview.tsx` and
`HistoryView.tsx`. Approximately 314 lines of previous rendering logic
were removed from these components and replaced by 242 lines in the new,
focused, and reusable `TaskItem` and `TaskItemHeader` components,
resulting in a net reduction and improved maintainability.
Most importantly, rendering logic happens in one place.
Key UI Changes:
- Metadata (timestamp, tokens, cost, cache, file size) now displayed
inline on a single header row in both variants.
- Removed explicit "Tokens:" and "API Cost:" labels for a cleaner look.
- Action buttons (Copy, Export, Delete) in the full view are now
aligned with the metadata header.
- File size is displayed in the header for the "full" variant only.
- Workspace information is no longer displayed in the "compact" preview.
Component Changes:
- Created `webview-ui/src/components/history/TaskItem.tsx` (125 lines)
- Created `webview-ui/src/components/history/TaskItemHeader.tsx` (117 lines)
- Modified `webview-ui/src/components/history/HistoryPreview.tsx` (-65 lines, +3 lines)
- Modified `webview-ui/src/components/history/HistoryView.tsx` (-249 lines, +3 lines)
- Uses `HistoryItem` type for standardized data handling.
Fixes: #4018
Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>
* test: fix TaskItem and HistoryView test failures after refactor
Fixes test failures that occurred after the major refactoring that introduced
the shared TaskItem component. The original implementation was correct but
the tests needed updates to match the new component structure.
- Add data-testid attributes to TaskItemHeader for reliable test selection
- Update TaskItem.test.tsx assertions to use new test IDs for tokens/cache
- Fix Checkbox import path in TaskItem.tsx (ui/checkbox vs ui)
- Add missing mocks for lucide-react and Checkbox in HistoryView.test.tsx
- Update HistoryView test assertions to use correct selectors
- Ensure all 19 history component tests pass successfully
The refactoring reduced code duplication by ~250+ lines while maintaining
functionality, and these test fixes ensure the quality gates remain intact.
Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>
* ui: move token and cost info from header to dedicated footer
Create a new TaskItemFooter component that displays token and cost information
with different styles for compact and full views. Move the CopyButton and
ExportButton from header to footer in full view. Adjust file size display
positioning in the header for better visual alignment.
Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>
* test: update history component tests to match implementation
Update data-testid attributes in HistoryView and TaskItem tests to match the
actual implementation in TaskItemFooter component. The tests were looking for
generic "tokens-in" and "tokens-out" attributes, but the implementation uses
variant-specific attributes like "tokens-in-footer-full".
Also added mocks for CopyButton and ExportButton components to resolve
"Element type is invalid" errors during test rendering.
Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>
* Move cache information from header to footer to be consistent with cost/token data
* Fix ESLint warnings: remove unused imports and variables
---------
Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>
Co-authored-by: Eric Wheeler <roo-code@z.ewheeler.org>
fix: improve directory link handling in markdown
Enhance the openFile function to better handle directory links in markdown:
- Add support for resolving ./SimpleName paths to home directory if not found in workspace
- Improve path resolution by checking multiple potential locations
- Ensure directories are properly revealed in the Explorer view
- Attempt to expand directories after revealing them
Fixes: #3686
Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>
Co-authored-by: Eric Wheeler <roo-code@z.ewheeler.org>
* add support for mcp server instructions
* Update McpView.tsx
* feat(mcp): add instructions field to MCP localization files and update UI to display instructions
---------
Co-authored-by: huixin <yuanhx@cffex.com.cn>
Co-authored-by: Daniel Riccio <ricciodaniel98@gmail.com>
Adds a new test case that allows testing the multi-search-replace diff strategy directly from the command line by passing source and diff files as arguments.
This enables easier debugging and manual testing of the diff application functionality without needing to modify test code for each test case.
Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>
Co-authored-by: Eric Wheeler <roo-code@z.ewheeler.org>
* Implement support for streamable-http transport type mcp servers
* add streamable-http mock in same fashion as sse - which does not seem to currently be actually leveraged
* rename mock to resolve kebabcase vs camelCase
* fix (seemingly unrelatd) test failure in writeToFileTool.test.ts
* fix tests
This commit upgrades Node.js version from v20.18.1 to v20.19.2.
This version incorporates security patches that address known
vulnerabilities, improving the overall security posture.
Co-authored-by: Peter Dave Hello <hsu@peterdavehello.org>
The Virtuoso component has a inner footer component that serves only as a bottom spacer, after investigation this component keeps re-rendering, beccause its unnecessary it was removed and the spaccing added to the component itselve
* refactor: Add pushToolWriteResult method to DiffViewProvider
Previously, each tool file contained duplicate code for formatting file write
responses and conditionally sending user_feedback_diff messages. This led to
inconsistent implementations and made changes difficult to maintain.
This refactoring centralizes the response formatting and messaging logic in the
DiffViewProvider class, which now:
- Stores results from saveChanges() in class properties
- Only sends user_feedback_diff when user edits exist
- Configures XMLBuilder with no indentation for cleaner output
Tool files now make a single method call instead of duplicating logic.
Fixes: #3647
Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>
* fix: conditionally show user edits message in file write response
Make the 'If the user's edits have addressed part of the task...' message
conditional based on whether there are actual user edits. This prevents
showing irrelevant guidance when no user edits were made to the file.
Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>
---------
Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>
Co-authored-by: Eric Wheeler <roo-code@z.ewheeler.org>
Adds validation to ensure that `:start_line:` and `:end_line:`
markers do not appear in the REPLACE section of an apply_diff
operation. These markers are only valid within the SEARCH section.
This change prevents potential errors and confusion when users
might inadvertently include these markers in the replacement content.
New tests have been added to verify this validation.
Fixes: #4013
Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>
Co-authored-by: Eric Wheeler <roo-code@z.ewheeler.org>
* feat: Add custom VPC endpoint support for AWS Bedrock
* fix: Fix TypeScript error in Bedrock.tsx
* fix: Update VPC endpoint UI to match Cline's implementation
* Fix AWS Bedrock VPC endpoint UI implementation
- Changed checkbox label to 'Use custom VPC endpoint' to match Cline
- Fixed conditional rendering to show text field when checkbox is checked
- Ensured placeholder text appears correctly
- Maintained proper styling for consistency
* Fix AWS Bedrock VPC endpoint UI implementation to match Cline exactly
- Added state variable to track checkbox selection
- Fixed conditional rendering to show/hide text field based on checkbox state
- Maintained proper styling and placeholder text
* Fix AWS Bedrock VPC endpoint UI implementation with proper event handling
- Fixed checkbox onChange handler to accept boolean directly instead of event object
- Added unit tests to verify the behavior
- Maintained proper styling and placeholder text
* Update Bedrock VPC endpoint tests with proper test IDs
* Improve AWS Bedrock VPC endpoint text field alignment
- Removed left margin from text field to align with checkbox
- Maintained proper styling and placeholder text
* Preserve AWS Bedrock VPC endpoint URL when toggling checkbox
- Added awsBedrockEndpointEnabled field to schema
- Modified Bedrock provider to check both endpoint URL and enabled flag
- Updated UI to preserve endpoint URL when checkbox is toggled
- Maintained proper alignment with checkbox
* Implement AWS Bedrock Custom VPC Endpoint functionality
* fix: update ApiConfiguration to ProviderSettings in Bedrock tests and regenerate types
* fix: update all instances of ApiConfiguration to ProviderSettings in Bedrock tests
* Fixed broken unit test
* Add changeset for Bedrock VPC endpoint support
* informative placeholder
* Bug fixes
* Fixed failing tests
* Add example URLs to Bedrock VPC endpoint section and update tests
* Fix truncated test assertion in Bedrock.test.tsx that was breaking the UI
* Refactor mock components in Bedrock.test.tsx for improved data-testid handling
* feat(i18n): add VPC endpoint translations for AWS Bedrock settings
* test: update Bedrock component tests for internationalized strings
---------
Co-authored-by: Kevin White <kcwhite@ancestry.com>
Co-authored-by: Daniel <57051444+daniel-lxs@users.noreply.github.com>
Co-authored-by: Daniel Riccio <ricciodaniel98@gmail.com>
* feat(ConcurrentFileReadsExperiment): improve logic for enabling/disabling and add tests
* fix: ensure slider always displays valid value (min 2) for concurrent file reads
- Fix issue where slider could display values below minimum when enabled with maxConcurrentFileReads <= 1
- Add test cases for edge cases (value 0 and 1)
- Ensure UI always shows at least the minimum value of 2
---------
Co-authored-by: Daniel Riccio <ricciodaniel98@gmail.com>
* feat(read_file): enhance file reading capabilities with multi-file support and improved parameter handling
fix(read_file): change return to continue on approval rejection in readFileTool
Enhance readFileTool with improved error handling and validation
- Introduced a FileEntry interface for better type management.
- Added validation for start_line and end_line to ensure proper ranges.
- Implemented RooIgnore validation before processing files.
- Enhanced error handling with dedicated functions for file and global errors.
- Streamlined file reading logic to handle binary files, definitions-only mode, and line thresholds more effectively.
- Improved user feedback for empty files and read limits.
chore: update Jest snapshot for system prompt tool usage
Refactor read-file tool to support XML input format and multiple line ranges
- Updated the `getReadFileDescription` function to reflect new XML structure for file reading requests.
- Modified `readFileTool` to parse XML input, allowing multiple line ranges for each file.
- Removed old parsing logic that handled line ranges as separate parameters.
- Implemented validation for line ranges and ensured proper error handling for file access.
- Adjusted approval messaging to accommodate new line range format.
- Enhanced error handling to provide consistent feedback for file read errors.
update from KJ7LNW comment
feat: add maxConcurrentFileReads setting to enhance read_file tool performance
feat: enhance readFileTool with XML parsing and file processing state tracking
feat: enhance readFileTool to include user feedback handling and processing state tracking
chore: clean up read_file tool documentation by removing extra newlines
feat: update read_file tool tests to handle user feedback and approval states
feat: add tests for feedback message formatting and XML special character handling in read_file tool
Implement code changes to enhance functionality and improve performance
feat: increase max concurrent file reads and adjust slider range in settings
feat: increase default max concurrent file reads from 5 to 15 across settings and context management
fix(read_file): enhance legacy path handling and remove duplicate parameters
feat(read_file): enhance file description handling and add support for multiple files in messages
done poc for new ux
idea 1
* fix the test
* fix: normalize locale file formatting to use tabs
- Applied prettier formatting to all locale JSON files
- Fixed mixed indentation (spaces/tabs) to use consistent tabs
- Aligns with project's prettier configuration
* fix(settings): improve checkbox handling and slider configuration in ConcurrentFileReadsExperiment
* fix(read_file): enhance description to include partial reads support
* fix(read_file): update description for partial reads and improve example clarity
* fix: suggestions
* fix: translations
* test: update system prompt snapshots for multi-file read tool
* fix: remove batch permission question from readFile tool translations
---------
Co-authored-by: Daniel Riccio <ricciodaniel98@gmail.com>
* Fix UTF-8 encoding issue in integrated terminal
- Set LANG and LC_ALL environment variables to en_US.UTF-8
- Resolves Encoding::CompatibilityError in Ruby/CocoaPods commands
- Ensures consistent UTF-8 encoding across all terminal sessions
This change addresses the terminal encoding issue where commands like
'pod install' would fail due to incompatible character encoding. The
fix ensures all integrated terminals are initialized with proper
UTF-8 locale settings.
* Add comprehensive unit tests for ExecaTerminalProcess UTF-8 encoding fix
- Tests verify LANG and LC_ALL are set to en_US.UTF-8
- Tests ensure existing environment variables are preserved
- Tests confirm UTF-8 settings override conflicting locale values
- Addresses PR feedback requesting test coverage for encoding fix
- All 7 tests passing with proper mocking of execa and ps-tree
