fix: SSE MCP Invocation (#4251)

* only apply transport.start for stdio

* instructions

* formatting
This commit is contained in:
Taylor Wilsdon 2025-06-02 07:41:36 -04:00 committed by GitHub
parent c67356991e
commit 6423fc301c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -598,13 +598,23 @@ export class McpHub {
}
await this.notifyWebviewOfServerChanges()
}
transport.onclose = async () => {
const connection = this.findConnection(name, source)
if (connection) {
connection.server.status = "disconnected"
}
await this.notifyWebviewOfServerChanges()
}
} else {
// Correctly placed "unsupported type" else block
// Should not happen if validateServerConfig is correct
throw new Error(`Unsupported MCP server type: ${(configInjected as any).type}`)
}
// transport.start assignment moved after all type-specific initializations
transport.start = async () => {} // No-op now, .connect() won't fail
// Only override transport.start for stdio transports that have already been started
if (configInjected.type === "stdio") {
transport.start = async () => {}
}
const connection: McpConnection = {
server: {