scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-10-11 03:38:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
15095 commits 12 branches 404 tags 331 MiB
Commit graph

11729 commits

Author SHA1 Message Date
Adomas Venčkauskas
051280fc43 Update ScienceDirect cf captcha selector 2025-02-19 02:03:27 -05:00
Abe Jellinek
264f55545a Fix faulty siblings-of-type check in setAutoAttachmentTitle() (#5045) 2025-02-19 02:03:26 -05:00
Dan Stillman
184671f919 Fix sync not downloading queued objects on first sync of session 
`firstInSession` wasn't being properly set, so previously failed data
objects weren't being retried until a manual sync. Local files also
weren't being scanned for changes for three hours, but that's probably
better in the age of DB-stored annotations, so leave that off for now
and address properly in #5025.
 2025-02-19 02:03:26 -05:00
Dan Stillman
24c7f146b3 Don't open new copies of runJS/scaffold/csledit 
Possible we'll get complaints about no longer being able to open
multiple copies of at least runJS and csledit, and we can reconsider if
so, but reopening the existing window is certainly the intended
behavior.
 2025-02-19 02:03:26 -05:00
Abe Jellinek
707c71506f Check editability based on tab when adding attachments (#4936) 
And make `get[Selected/Sorted]Items()` and `canEdit[Library/Files]()` tab-aware
 2025-02-19 02:03:26 -05:00
Abe Jellinek
569bd1ffae Item box: Fix missing Copy/Paste menuitems on URL fields (#5001) 2025-02-19 02:03:26 -05:00
Dan Stillman
62d46d337a Fix selectItems() not selecting non-top-level item in trash 
https://forums.zotero.org/discussion/comment/484380/#Comment_484380

Adds `Zotero.Item#isInTrash()` that returns true if the item or any of
its ancestors is in the trash (i.e., `.deleted == true`)
 2025-02-19 02:03:26 -05:00
Dan Stillman
ce0f7c0378 Use commas in file size in over-quota error 2025-02-19 02:03:25 -05:00
Dan Stillman
b4bf86915b Item#fromJSON(): Don't process any Extra rows in strict mode 
And enable migration of Extra rows to valid fields in non-strict mode,
but since that's only used by translators now, that probably won't do
anything

Fixes #3422
 2025-02-19 02:03:25 -05:00
Dan Stillman
8804effba4 Don't auto-select item after sync on upload error 
Bug from 2017
 2025-02-19 02:03:25 -05:00
Abe Jellinek
006a787272 Add key to Advanced Search menuitem 
Fixes #4978
 2025-02-19 02:03:25 -05:00
Dan Stillman
0424faee42 Unset Mozilla environment variables when launching files and URLs (#4983) 
Fixes #4981
 2025-02-19 02:03:25 -05:00
windingwind
3c9dcc94bc Fix attachments box race condition (#4997) 
fix: #4611
Since the attachment preview already has a task queue,
don't skip render calls when rendering
 2025-02-19 02:03:24 -05:00
Adomas Venčkauskas
4bc61273a0 Fix integration session breaking when an error is thrown during getDocument() 2025-02-19 02:03:24 -05:00
windingwind
59b3268d01 Fix dense call to setItemDownloadPercentage freezes app (#4979) 2025-02-19 02:03:24 -05:00
Dan Stillman
ddb1daabbc Fix json[c.field] is undefined sync error 
Fix error if local note or attachment is added to a parent item while
the remote version was added to a collection. Now, the new local parent
item will be added to any collections the remote child item was added
to.

Fixes #2934
 2025-02-19 02:03:24 -05:00
Tom Najdek
d0debc0bed Fix Metadata Retrieval to correctly display the recognized item's title 2025-02-19 02:03:24 -05:00
Adomas Venčkauskas
b5b59062a7 Refresh document with delayed citation updates when changing style 
Closes #4974
 2025-02-19 02:03:24 -05:00
windingwind
f7b4cf907b Fix export error of item.tags being undefined (#4962) 
Item generated from embedded image attachment may not have attribute `tags`.
 2025-02-19 02:03:23 -05:00
abaevbog
36838e6a9a qf: default arrowUp handling on locator menulist (#4965) 
Do not close details panel on arrowUp when locator
type menulist is focused to allow for default handling
(e.g. select the next/previous option on windows).

Fixes: #4953
 2025-02-19 02:03:23 -05:00
abaevbog
5b427ac332 save tagsBox updates when another item is selected (#4945) 
When tagsBox item is changed by clicking on an itemTree row,
the blur even never fires on the currently focused tag. So
whatever changes were made will be discarded. To avoid it,
blur any opened tag rows (which triggers a saveTx)
when an item is being set, same way it is done in itemBox.

Also, a small tweak to properly fetch the focused tag
via editable-text:focus-within selector, since editable-text:focus is
always empty because the focus is on the input inside of
editable-text.

Fixes: #4942
 2025-02-19 02:03:23 -05:00
abaevbog
65c77ddaae hide switch creator type in non-editable itembox (#4940) 
Fixes: #4937
 2025-02-19 02:03:23 -05:00
Dan Stillman
09813be7e0 Fix handling of redirecting OpenURL base URLs with url query parameter 
For a URL like
`https://ezproxy.school.edu/login?url=http://resolver.ebscohost.com/openurl`,
without a trailing `?`, we were just adding a `%` to the end, making the
URL invalid after the redirection (`/openurl&url_ver=Z39.88-2004`
instead of `/openurl?url_ver=Z39.88-2004`).

(And apparently no one who sent in these URLs actually tested them
in-app?)
 2025-02-19 02:03:22 -05:00
Abe Jellinek
85b111de4a Serialize _ensureFeedAbstractBrowserExists() 
Prevent a potential race condition.
 2025-02-19 02:03:22 -05:00
Martynas Bagdonas
e3ae991bb3 Render ink annotation images when previewing attachment annotations 2025-02-19 02:03:22 -05:00
Abe Jellinek
06fe4ad346 CookieSandbox: Fix XHR interface check 
Actually broken since fx115.
 2025-02-19 02:03:22 -05:00
windingwind
2019ac39a1 Fix ZoteroPane#buildFieldTransformMenu document variable (#4927) 
fix: https://groups.google.com/g/zotero-dev/c/FwfrxviKi8I
 2025-02-19 02:03:21 -05:00
Dan Stillman
02b48318d7 Update locales from Transifex 2025-02-19 02:03:21 -05:00
abaevbog
1321447374 let Zotero_Tabs.undoClose reopen duplicate tabs (#4920) 
Fixes: #4919
 2025-02-19 02:03:21 -05:00
Tom Najdek
c0c00752e7 Improve importing from Mendeley 
- Make the annotations importer more resilient to missing data
- Fix notebooks not being imported in some cases
- Fix an instance of a hidden browser leaked by the Mendeley Importer
 2025-02-19 02:03:21 -05:00
Dan Stillman
b9d1f50559 Remove debug line 2025-02-19 02:03:20 -05:00
Dan Stillman
77bdb0b4cb Shower nicer error for malformed WebDAV URL 
We fix `://` or `//` automatically after #3483, but a leading ':'
character would still show an internal `NS_ERROR_MALFORMED_URI` error.
Instead, just say "[url] is not a valid WebDAV URL".
 2025-02-19 02:03:20 -05:00
Dan Stillman
320399dca9 Strip leading :// or // in WebDAV URL 
Closes #3483
 2025-02-19 02:03:20 -05:00
Dan Stillman
8c54b98483 Reset file sync history when changing WebDAV URL 
Fixes #3535
 2025-02-19 02:03:20 -05:00
Dan Stillman
a0009f0fa3 Clear library storage version when resetting file sync history 
Fixes #1753
 2025-02-19 02:03:20 -05:00
windingwind
cb0b2f9d58 Item pane scroll pos fix after switching from note (#4897) 
Follow up to #4879
fix: #4276
 2025-02-19 02:03:20 -05:00
Abe Jellinek
886dbd17ff Abstract box: Use focused getter instead of :focus-within 
See b4c5c5d539

Fixes #4878
 2024-12-05 14:39:27 -05:00
Dan Stillman
6740115cf2 Revert "Fix Item Pane unstable rendering during scrolling (#4879)" 
Regressions:

https://forums.zotero.org/discussion/120216/blinking-item-pane-when-switching-item-with-pinned-section-in-the-sidenav
https://forums.zotero.org/discussion/120217/title-field-is-not-visible-anymore-after-creating-a-new-item-if-a-section-is-pinned-in-the-sidenav

This reverts commit 4067745c7a.
 2024-12-04 01:35:04 -05:00
Martynas Bagdonas
8317f77837 Trigger annotation import only for PDF attachments when creating a note 
Fixes https://forums.zotero.org/discussion/120181/batch-create-note-from-annotations-for-different-attachment-types
 2024-12-03 21:24:37 +00:00
Abe Jellinek
1c70e53006
Fix several automatic relinking regressions due to PathUtils (#4887) 2024-12-03 16:23:00 -05:00
Dan Stillman
6fe2772318 Update locales from Transifex 2024-12-03 16:15:48 -05:00
windingwind
4067745c7a
Fix Item Pane unstable rendering during scrolling (#4879) 
Fix wrong vertical position in the Item Pane after switching from a note

fix: #4276
 2024-12-02 22:42:32 -05:00
Dan Stillman
99b80723b8 Move special handling of 'timestamp' locator 
Avoid "Locator 'timestamp' is empty in en-US locale" warning when
opening citation dialog after 969feb620d
 2024-12-02 22:39:34 -05:00
Dan Stillman
969feb620d Add "Timestamp" to locator menu 
https://forums.zotero.org/discussion/comment/480030/#Comment_480030
 2024-11-30 01:47:00 -05:00
windingwind
7296583f2a
Fix item pane custom info row render after item change (#4875) 
Add test for info row render after item change
fix: #4874
 2024-11-29 16:18:31 -05:00
abaevbog
247826194a
fix advanced search anyField condition breakage (#4873) 
Process "joinMode" before other conditions that may rely on it

Fixes: #4871

Co-authored-by: Dan Stillman <dstillman@zotero.org>
 2024-11-27 23:43:09 -05:00
Dan Stillman
bacb60a103 Fix failure loading feed if no link and no url 
APA feed link here:

https://forums.zotero.org/discussion/119954/issue-adding-new-feed-from-url-in-zotero-7
 2024-11-26 22:44:48 -05:00
Abe Jellinek
0e2427fc9f Scaffold: Correct field help 2024-11-26 11:04:25 -05:00
Abe Jellinek
5a005b9adb Scaffold: Clean up tab select code slightly 2024-11-26 11:01:18 -05:00
Abe Jellinek
08ed672445 Update translate submodule 2024-11-26 10:48:39 -05:00