Commit graph

11807 commits

Author SHA1 Message Date
abaevbog
d3cee95fb7
Click on itemBox label focus edits (#5065)
Click on a label of a focused field will refocus itemTree
or the reader content, depending on the tab. That way
focus is not lost.

Fixes: #5063
2025-03-05 05:59:11 -05:00
Dan Stillman
3a26ce3bb1 Avoid args is undefined logged error in file sync tests 2025-03-05 05:50:58 -05:00
Dan Stillman
1f401f0897 Replace Zotero.Utilities.Internal.saveURI() with Zotero.HTTP.download()
Adds a new function, Zotero.HTTP.download(), that uses
Zotero.HTTP.request(). This fixes downloads via authenticated proxies in
Zotero 7 and gives us other request() functionality (e.g., 5xx retrying)
for free.

The downside is that this is probably less efficient, potentially
loading large downloads in memory. We should create a replacement for
request() based on fetch() that supports getting the body as a
ReadableStream.

Fixes #5062
2025-03-05 04:46:51 -05:00
windingwind
ccc1800f21
Fix attachment preview background (#5067)
regression from 9c41874
2025-03-04 09:45:22 -05:00
Abe Jellinek
5c8859b618 RemoteTranslate: Fix request methods not sending cookies 2025-02-28 15:22:37 -05:00
Abe Jellinek
c19f43ea46 Scaffold: Suppress ESLint JSON.parse() syntax errors 2025-02-28 15:16:26 -05:00
Abe Jellinek
1e08985dcd Scaffold: Accept shorthand URLs in URL box
Like "google.com" instead of "https://www.google.com/".
2025-02-28 15:16:12 -05:00
Abe Jellinek
ba7b521bb1 Scaffold: Clean up load() slightly 2025-02-26 12:09:06 -05:00
Abe Jellinek
ddb5977c48 Scaffold: Remove 2028/2029 fix
Hasn't been an issue since ES2019.
2025-02-26 11:27:02 -05:00
Abe Jellinek
26221b6786 Fix broken browser window on print + remove many Mozilla files (#5050) 2025-02-26 03:00:04 -05:00
Abe Jellinek
90a9c5164a
macOS: Unescape dragged path when NSURL doesn't (#5059) 2025-02-25 05:28:12 -05:00
abaevbog
c049120efb
do not try to select deleted item in a collection (#5061)
After navigating to the collection from "Libraries and Collections"
section of an item in the trash. Deleted item does not appear in actual
collections and trying to select it will just re-select the trash.

Fixes: #5060
2025-02-25 05:24:59 -05:00
Abe Jellinek
854f2188c2 Duplicates: Fix hidden elements remaining visible
And update comment.

Fixes #5056
2025-02-24 11:18:48 -05:00
abaevbog
54346b0ca7
fix broken QF cancellation from editor instance (#5054)
Define missing cancel method on io object passed from the
editor instance to quickFormat dialog. Without this
Escape keypresses throws an error because io.cancel is
undefined.

Followup to #4859
2025-02-21 22:13:41 +02:00
Abe Jellinek
d3871d6864 editable-text: Forward onTextEntered() from input
Fixes #5043
2025-02-20 14:40:58 -05:00
Adomas Ven
2e9b9d4070
Close citation dialog if user interacts with the integration plugin (#4859)
Asks the user if they want to discard the changes in their existing dialog if
they have made changes.

If there is no citation dialog, but a command is running (like updating the document)
an alert is displayed.

Closes #4855
2025-02-18 05:52:23 -05:00
Adomas Venčkauskas
d231fb3b53 Do not attempt to activate windows on wayland using X11 libraries
I don't know if something changed in my Ubuntu installation or in the
Firefox runtime (probably the former), but that code crashes Zotero on
wayland.

Window activation (e.g. citation window) does not seem to be affected.
2025-02-18 10:55:22 +02:00
Adomas Venčkauskas
e765a4d3af Update ScienceDirect cf captcha selector 2025-02-18 10:53:02 +02:00
Dan Stillman
fc3b7e0f83 Local API: Fix handling of style ids without standard prefix
Follow-up to #5032
2025-02-17 03:16:22 -05:00
Dan Stillman
9c6b3368f2 Revert "Zotero.Styles: Serialize init() and remove Zotero.Promise.coroutine()"
This breaks style initialization if you trigger it manually before the
normal startup initialization.

This reverts commit d141ab25b1.

https://forums.zotero.org/discussion/121879/missing-item-pane-header
https://forums.zotero.org/discussion/121878/cannot-copy-citation-bibliography-in-reader
2025-02-17 02:19:59 -05:00
abaevbog
506f3b14e3
Allow dragging items, collections, and searches into trash (#5033)
Fixes: #1943
2025-02-13 02:58:25 -05:00
Abe Jellinek
5978353d57
Fix faulty siblings-of-type check in setAutoAttachmentTitle() (#5045) 2025-02-12 22:29:49 -05:00
Adomas Ven
8dbc6177ce
Macos integration progress bar (#5016)
* Display the progress bar on macOS integration commands more

Avoid displaying before Add/Edit Citations, Add Note and Doc Prefs
since that brings Zotero window to the foreground along with the
relevant dialog, but display the progress bar after confirming those
dialogs, which will bring Zotero to the front, but is still better than
no progress indication.

Display the progress bar for Refresh, Doc Prefs, Unlink and Add/Edit
Bibliography

* Fix progress bar indeterminate state not being visible and not working.

- Update _progressMeter.scss for fx115+
- Some adjustments/resizing to progress bar display in quick format
2025-02-12 08:43:11 +02:00
Abe Jellinek
98a5b7eaec Local API: Handle out-of-repo styles correctly (#5032) 2025-02-07 07:43:28 -05:00
Abe Jellinek
d25b96643c Zotero.Styles: Serialize init() and remove Zotero.Promise.coroutine() 2025-02-07 07:43:28 -05:00
Dan Stillman
7256072c5b Merge new English strings 2025-02-05 05:10:14 -05:00
Dan Stillman
083b4f69c9 Pretty-print zoteroTypeSchemaData.js
We should get rid of this, but in the meantime, pretty-print it (though
it will need to be generated in a new data directory to be consistent).
2025-02-05 03:27:33 -05:00
Dan Stillman
5d5c043161 Fix sync not downloading queued objects on first sync of session
`firstInSession` wasn't being properly set, so previously failed data
objects weren't being retried until a manual sync. Local files also
weren't being scanned for changes for three hours, but that's probably
better in the age of DB-stored annotations, so leave that off for now
and address properly in #5025.
2025-02-05 02:06:15 -05:00
Martynas Bagdonas
553f0f3994 Implement reader appearance popup with custom themes support
Implements #4949, #5005
2025-02-04 13:43:50 +02:00
Dan Stillman
3d75801a84 Don't open new copies of runJS/scaffold/csledit
Possible we'll get complaints about no longer being able to open
multiple copies of at least runJS and csledit, and we can reconsider if
so, but reopening the existing window is certainly the intended
behavior.
2025-01-31 00:58:37 -05:00
Dan Stillman
7466fa479f fx128: Further tweaks to "Check for Updates…" code
Don't use internal interface if we can help it

Relevant Mozilla changes:
https://bugzilla.mozilla.org/show_bug.cgi?id=1875502#c60
2025-01-29 01:07:51 -05:00
Dan Stillman
eb776f8e6e fx128: Fix "No updates found" if update was already downloaded
Previously fixed for fx115 in #3148, but `nsIUpdateManager` changed in
fx128

https://forums.zotero.org/discussion/121482/zotero-7-1beta-does-not-find-updates
2025-01-29 00:46:00 -05:00
Abe Jellinek
51349a5a97 Local API: Read headers case-insensitively 2025-01-28 10:45:08 -05:00
Abe Jellinek
2a7f4fb2a5 Local API: Return everything when since=0
Addresses #5011 (option A)
2025-01-28 10:39:43 -05:00
Abe Jellinek
2aee7ae8d5 RemoteTranslate: Fix updated tests not inheriting defer 2025-01-28 10:07:11 -05:00
Abe Jellinek
65393d09eb
Check editability based on tab when adding attachments (#4936)
And make `get[Selected/Sorted]Items()` and `canEdit[Library/Files]()` tab-aware
2025-01-28 01:00:17 -05:00
Abe Jellinek
a7fff8cada
Local API: Add /fulltext endpoints (#5004) 2025-01-28 00:58:12 -05:00
Abe Jellinek
6cdae37e5b
Local API: Fix 500 error when attachment has unparseable path (#5010) 2025-01-28 00:54:29 -05:00
Abe Jellinek
48b50064e9
Item box: Fix missing Copy/Paste menuitems on URL fields (#5001) 2025-01-28 00:48:41 -05:00
Abe Jellinek
be023c3a95 RemoteTranslate: Fix error when creating test 2025-01-27 15:23:51 -05:00
Dan Stillman
71d697801e Fix banner style issues
- Fix background color on post-upgrade banner
- Add drop shadow between stacked banners (e.g., post-upgrade banner and
  Mac Word banner, which will generally appear together on an upgrade
  and have the same background color)
- Align right edge of buttons in post-upgrade and Mac Word
- Unify other spacing and font sizes
2025-01-27 07:34:31 -05:00
Dan Stillman
7a467b8bfa Fix selectItems() not selecting non-top-level item in trash
https://forums.zotero.org/discussion/comment/484380/#Comment_484380

Adds `Zotero.Item#isInTrash()` that returns true if the item or any of
its ancestors is in the trash (i.e., `.deleted == true`)
2025-01-27 04:02:10 -05:00
Dan Stillman
814e59f694 Use commas in file size in over-quota error 2025-01-27 04:02:10 -05:00
Dan Stillman
39cbf5e520 Fix double URL launch via keyboard in sync error panel
Space bar or Enter are (now?) equivalent to `click` on a button
2025-01-27 04:02:10 -05:00
Abe Jellinek
465cc89ad6 Scaffold: Use native checkboxes in select dialog 2025-01-24 15:04:52 -05:00
Abe Jellinek
9510eef69a Scaffold: Fix select dialog overflow (again!)
And restore button spacing.
2025-01-24 15:04:43 -05:00
Abe Jellinek
679b1df116 Update translate submodule 2025-01-24 14:10:31 -05:00
Abe Jellinek
3a816fad55 Scaffold & RemoteTranslate: Improve defer handling
- Use extracted delay routine
- Pass defer into newTest()
2025-01-24 12:10:33 -05:00
Abe Jellinek
5f983d71c1 RemoteTranslate: Improve page readiness checks
Treat page as immediately ready after readyState == 'complete', or give
it 100ms after 'interactive'. This is rough, but 'interactive' isn't
always fully ready and 'complete' sometimes never happens.
2025-01-24 12:10:15 -05:00
Abe Jellinek
79092fadcd Update translate submodule 2025-01-24 12:02:43 -05:00