scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-10-03 02:21:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Local API: Handle out-of-repo styles correctly (#5032)

Browse source
This commit is contained in:
Abe Jellinek 2025-02-06 12:50:12 -05:00 • committed by Dan Stillman
parent d25b96643c
commit 98a5b7eaec
1 changed files with 32 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
chrome/content/zotero/xpcom/localAPI/server_localAPI.js
View file

@ -87,6 +87,18 @@ const exportFormats = new Map([
*/
class LocalAPIEndpoint {
async init(requestData) {
try {
return await this._initInternal(requestData);
}
catch (e) {
if (!(e instanceof BadRequestError)) {
throw e;
}
return this.makeResponse(400, 'text/plain', e.message);
}
}
async _initInternal(requestData) {
if (!Zotero.Prefs.get('httpServer.localAPI.enabled')) {
return this.makeResponse(403, 'text/plain', 'Local API is not enabled');
}
@ -929,19 +941,29 @@ async function citeprocToHTML(itemOrItems, searchParams, asCitationList) {
// Filter out attachments, annotations, and notes, which we can't generate citations for
items = items.filter(item => item.isRegularItem());
let styleID = searchParams.get('style') || 'chicago-note-bibliography';
let styleIDOrURL = searchParams.get('style') || 'chicago-note-bibliography';
let locale = searchParams.get('locale') || 'en-US';
let linkWrap = searchParams.get('linkwrap') == '1';
if (!styleID.startsWith('http://www.zotero.org/styles/')) {
styleID = 'http://www.zotero.org/styles/' + styleID;
}
let style = Zotero.Styles.get(styleID);
let style = Zotero.Styles.get(styleIDOrURL);
if (!style) {
// The client wants a style we don't have locally, so download it
let url = styleID.replace('http', 'https');
await Zotero.Styles.install({ url }, url, true);
style = Zotero.Styles.get(styleID);
// If they didn't pass an absolute URL, resolve relative to the style repo base
try {
let styleURL = new URL(styleIDOrURL, 'https://www.zotero.org/styles/');
if (styleURL.protocol === 'http:' && styleURL.host === 'www.zotero.org') {
styleURL.protocol = 'https:';
}
styleURL = styleURL.toString();
let { styleID } = await Zotero.Styles.install({ url: styleURL }, styleURL, true);
style = Zotero.Styles.get(styleID);
}
catch (e) {
throw new BadRequestError(`Invalid style: ${styleIDOrURL} (${e.message})`);
}
}
if (!style) {
throw new Error(`Unable to install style: ${styleIDOrURL}`);
}
let cslEngine = style.getCiteProc(locale, 'html');
@ -996,3 +1018,5 @@ function evaluateSearchSyntax(searchStrings, items, predicate) {
}
return items;
}
class BadRequestError extends Error {}