Dan Stillman
1979efd8ce
Fix Zotero.Fulltext.getTotalPagesFromFile() call
2015-05-31 22:57:34 -04:00
Dan Stillman
1ecd934d04
Merge pull request #743 from egh/feature/search_tests
...
Add basic tests for fulltext search
2015-05-31 17:46:26 -04:00
Dan Stillman
365f8181e3
Disable emptyTrash() assertion, which is still faiing on Travis
2015-05-31 17:45:25 -04:00
Erik Hetzner
aac1255d3d
Add basic tests for full-text search
...
- also add importFileAttachment support function
2015-05-31 14:39:37 -07:00
Dan Stillman
9e573cdce2
Work around Zotero.Items::emptyTrash() test failure for now
...
Until I figure out the race condition that's causing this to fail on
Travis, use a different check so that all builds aren't failing.
2015-05-31 17:19:30 -04:00
Dan Stillman
b8d9504a4f
Missed lines from 420985661
2015-05-31 17:07:59 -04:00
Dan Stillman
cc3d81da93
Add Zotero.DataObjectUtilities.generateKey()
...
For now, this just calls Zotero.Utilities.generateObjectKey(), but this
function makes more sense in DataObjectUtilities. It does need to be
accessible to the connectors, but if it's possible to add an alias in
Zotero.Utilities just for the connectors, it'd probably be better to do
that and use Zotero.DataObjectUtilities.generateKey() elsewhere.
2015-05-31 16:59:10 -04:00
Dan Stillman
fd45032210
Add -g flag to run only tests matching a pattern (grep)
...
(Actually, it's only matching strings for me, not patterns, but according to
Mocha it's supposed to compile the patterns using RegExp.)
2015-05-31 03:37:45 -04:00
Dan Stillman
420985661b
Default to user library when assigning unsaved item to collection
...
And fix some issues setting the libraryID property on unsaved objects
Also return .deleted as false, not an empty string
2015-05-31 02:03:53 -04:00
Dan Stillman
ed1c0a4637
Fix updating of cached child collections/items, and make more efficient
2015-05-30 19:03:42 -04:00
Dan Stillman
807c40859f
Missed lines from 2154673dd
2015-05-29 21:55:47 -04:00
Dan Stillman
e19ee53f3d
Enable debugging for test that's failing on Travis
2015-05-29 14:36:02 -04:00
Dan Stillman
2154673dd3
Return a Zotero.Item from all Zotero.Attachments methods
...
These previously returned an itemID, but now that new saved items can be edited
without a refetch, they should just return the new item.
(Possible I missed a few spots where these are called.)
2015-05-29 05:33:54 -04:00
Dan Stillman
5a2ec43de1
Add Notifier.queue()
...
Notifier.trigger() needs to be async, since if it actually runs it waits for
promises returned from observers. But the vast majority of trigger() calls are
in transactions where they just queue and can therefore be synchronous. This
replaces all such calls with Notifier.queue().
This should fix a race condition that was causing the emptyTrash() test to fail
intermittently.
2015-05-29 05:03:05 -04:00
Dan Stillman
f3a6b41c1c
Add -f test flag to stop after first test failure
...
(Mocha has a 'bail' config flag that's supposed to do this, but it doesn't seem
to work when passed to mocha.setup() (maybe because we're setting a custom fail
handler?), so this just calls abort() on the runner manually.)
2015-05-29 04:01:40 -04:00
Dan Stillman
15252623d7
Log the actual number of Notifier observers for a type
2015-05-29 03:37:29 -04:00
Dan Stillman
4c5920ba9a
Remove stray this.timeout() call
2015-05-29 01:38:47 -04:00
Dan Stillman
5051b938ae
Increase default timeout to 5 seconds from 2
...
This is arbitrary, and we could increase it more or make it configurable via
the command line if Travis continue to time out, but this allows all tests to
complete for me in a VM.
2015-05-29 01:34:20 -04:00
Dan Stillman
025411f9b4
Wait 250ms before quitting after tests, to avoid DB errors
...
Not crazy about this, but (at least on my system) it's an easy way to
avoid DB errors due to interrupted transaction or query errors after the
DB connection was cleaned up. (I can reproduce those pretty reliably
right now by running collectionTreeView tests alone.)
2015-05-29 01:15:04 -04:00
Dan Stillman
72e0124e4e
Fix tag purging with stricter DB parameter checks
...
Should have failed without libraryID being passed
2015-05-29 01:15:04 -04:00
Dan Stillman
4e1dd6f5b6
Restore DB parameter checking and add tests
...
Some parameter situations also weren't being properly handled
2015-05-29 01:15:04 -04:00
Dan Stillman
1e7c822ab0
Fix linked file creation
2015-05-29 01:09:24 -04:00
Dan Stillman
a804efce67
Fix getAttachments()/getNotes() with no child items after save
2015-05-27 22:18:40 -04:00
Dan Stillman
8f2356f7c3
Delete test directory on exit when using -c
2015-05-27 21:42:37 -04:00
Dan Stillman
7eaa57562f
Fix Zotero.ItemFields.getBaseIDFromTypeAndField()
...
Closes #741
2015-05-27 05:01:48 -04:00
Dan Stillman
80d5b74cf3
Merge 4.0 up to 28301ea45f
...
Conflicts:
chrome/content/zotero/preferences/preferences_export.js
chrome/content/zotero/xpcom/proxy.js
2015-05-26 17:48:22 -04:00
Dan Stillman
8c64d8b410
Fixes #739 , Item added to "My Publications" despite choosing cancel
2015-05-26 17:20:42 -04:00
Dan Stillman
f71140da64
Remove Zotero.Item.prototype.addTags
...
Can use addTag() or setTags()
Addresses #735
2015-05-26 12:13:27 -04:00
Dan Stillman
8a0b4d92a6
Fix PDF tools installation on Linux
2015-05-26 04:44:02 -04:00
Dan Stillman
3d3b817724
Allow data to be set after save() on a new object without load() calls
...
After saving a new object and reloading primary data and any changed
data (which we can maybe reconsider at some point), mark all other data
types as loaded, since there's no other data we don't have. For example,
this allows for item.save() to be followed by item.setField() without
needing to call item.loadItemData() first.
2015-05-26 04:08:47 -04:00
Dan Stillman
5d530e4173
Don't load item data and collections for all items in the middle pane
2015-05-26 03:19:44 -04:00
Dan Stillman
41a68af1ae
Remove debug line when loading collections
2015-05-26 03:19:44 -04:00
Dan Stillman
ea1573e1c3
Don't log warning when localized string for search condition not found
...
Falls back to item field strings, so not sure why I added logging for
this.
2015-05-26 03:19:30 -04:00
Dan Stillman
9f4b128c14
Remove header and footer from stack trace display
2015-05-26 03:15:04 -04:00
Dan Stillman
28301ea45f
Center the site-specific Quick Copy and proxy editing windows
...
On OS X these show up as sheets, but on Windows without this flag they
appear in the top-left of the screen.
2015-05-25 23:36:24 -04:00
Dan Stillman
c152e81bed
Merge pull request #732 from rmzelle/edit-button-quickcopy
...
Add Edit button for site-specific Quick Copy settings
2015-05-25 23:31:44 -04:00
rmzelle
5833d87169
Add Edit button for site-specific Quick Copy settings
2015-05-25 23:21:50 -04:00
Dan Stillman
ab3b0367ef
Merge locales from Transifex
2015-05-25 22:26:50 -04:00
Dan Stillman
6e4eb61694
Merge pull request #673 from sendecomp/optional-proxy-redirect-notification
...
Add an option to not show the proxy redirection notification
2015-05-25 21:57:16 -04:00
Dan Stillman
96f5bab3a1
Cancel relatedbox loading if binding disappears
2015-05-25 21:48:47 -04:00
Dan Stillman
31af26af08
Fix selection of new items
2015-05-25 21:48:47 -04:00
Dan Stillman
2bd246e2ea
Fixes #728 , Tag selector refreshing
2015-05-25 21:48:46 -04:00
LinuxMercedes
34c0e746f5
Add an option to not show the proxy redirection notification
2015-05-25 17:38:24 -05:00
Dan Stillman
cbbdebc5b7
Fix hang in collectionsTreeView::selectWait() if row is already selected
2015-05-25 01:43:07 -04:00
Dan Stillman
43762248a4
Fix trash emptying, and do it in batches of 50
2015-05-25 00:14:49 -04:00
Dan Stillman
87fa51849f
Accept promise-yielding generators directly in forEachChunkAsync()
2015-05-24 22:56:44 -04:00
Dan Stillman
bf1ee0d52b
Move getLibraryAndKeyFromID() tests to dataObjectsTest.js
2015-05-24 22:14:52 -04:00
Dan Stillman
6933f64616
Fix reselection of trash after restart
2015-05-24 22:04:40 -04:00
Dan Stillman
dd52206b37
Don't show "Loading item data" when data is cached
2015-05-24 21:34:11 -04:00
Dan Stillman
e35575e6fd
If last viewed collection is set but not found, default to My Library
2015-05-24 20:00:10 -04:00
