scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-09-28 01:31:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

HiddenBrowser: Remove leak timer

Browse source 
Always logged a warning, even though it doesn't seem like memory is
actually being leaked here.
This commit is contained in:
Abe Jellinek 2025-08-21 12:19:29 -04:00
parent ba4949e822
commit 74c8226323
1 changed files with 0 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
chrome/content/zotero/HiddenBrowser.mjs
View file

@ -87,10 +87,6 @@ export class HiddenBrowser {
options.cookieSandbox.attachToBrowser(browser);
}
if (Zotero.Debug.enabled) {
startLeakWarningTimer(browser);
}
if (options.blockRemoteResources) {
this._blockingObserver = new BlockingObserver({
shouldBlock(uri) {
@ -316,21 +312,3 @@ export class HiddenBrowser {
}
}
}
function startLeakWarningTimer(browser) {
const CHECK_AFTER_SECONDS = 60;
// We need to use Cu.getWeakReference() to get an xpcIJSWeakReference here -
// DOM WeakRefs, paradoxically, keep the browser alive
let weakBrowser = Cu.getWeakReference(browser);
browser = null;
arguments.length = 0;
setTimeout(() => {
let browser = weakBrowser.get();
if (browser) {
Zotero.debug(`Browser object still alive after ${CHECK_AFTER_SECONDS} seconds - memory leak?`);
Zotero.debug('Viewing URI ' + browser.currentURI?.spec)
}
}, 1000 * CHECK_AFTER_SECONDS);
}