From 74c82263233a1633d099e085399fa2ac6c65dfca Mon Sep 17 00:00:00 2001 From: Abe Jellinek Date: Thu, 21 Aug 2025 12:19:29 -0400 Subject: [PATCH] HiddenBrowser: Remove leak timer Always logged a warning, even though it doesn't seem like memory is actually being leaked here. --- chrome/content/zotero/HiddenBrowser.mjs | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/chrome/content/zotero/HiddenBrowser.mjs b/chrome/content/zotero/HiddenBrowser.mjs index d7ebfe9970..d8c0bbb8aa 100644 --- a/chrome/content/zotero/HiddenBrowser.mjs +++ b/chrome/content/zotero/HiddenBrowser.mjs @@ -87,10 +87,6 @@ export class HiddenBrowser { options.cookieSandbox.attachToBrowser(browser); } - if (Zotero.Debug.enabled) { - startLeakWarningTimer(browser); - } - if (options.blockRemoteResources) { this._blockingObserver = new BlockingObserver({ shouldBlock(uri) { @@ -316,21 +312,3 @@ export class HiddenBrowser { } } } - -function startLeakWarningTimer(browser) { - const CHECK_AFTER_SECONDS = 60; - - // We need to use Cu.getWeakReference() to get an xpcIJSWeakReference here - - // DOM WeakRefs, paradoxically, keep the browser alive - let weakBrowser = Cu.getWeakReference(browser); - browser = null; - arguments.length = 0; - - setTimeout(() => { - let browser = weakBrowser.get(); - if (browser) { - Zotero.debug(`Browser object still alive after ${CHECK_AFTER_SECONDS} seconds - memory leak?`); - Zotero.debug('Viewing URI ' + browser.currentURI?.spec) - } - }, 1000 * CHECK_AFTER_SECONDS); -}