scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-10-05 02:43:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Remove key hack for setting innerHTML in item tree

Browse source 
Results in a segfault during tests due to a null pointer deference
This commit is contained in:
Dan Stillman 2023-05-04 07:59:20 -04:00
parent 7ee5dd564c
commit 4c283d88c7
1 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
chrome/content/zotero/itemTree.jsx
View file

@ -933,13 +933,6 @@ var ItemTree = class ItemTree extends LibraryTree {
}} }}
className={"items-tree-message"} className={"items-tree-message"}
style={{ display: showMessage ? "flex" : "none" }} style={{ display: showMessage ? "flex" : "none" }}
// Due to some collision between React and the XUL environment
// setting innerHTML on a cached React node triggers an XML
// parsing error god knows where. So on every refresh we set a new
// key for the element, forcing it to be recreated. This shouldn't
// be a major performance concern since we're not calling #forceUpdate()
// that often and even if we did it's just a single div here.
key={Date.now()}
dangerouslySetInnerHTML={{ __html: itemsPaneMessageHTML }}> dangerouslySetInnerHTML={{ __html: itemsPaneMessageHTML }}>
</div>); </div>);