From 4c283d88c7eb18a2cff877ec961904d985015ccd Mon Sep 17 00:00:00 2001
From: Dan Stillman <dstillman@zotero.org>
Date: Thu, 4 May 2023 07:59:20 -0400
Subject: [PATCH] Remove `key` hack for setting innerHTML in item tree

Results in a segfault during tests due to a null pointer deference
---
 chrome/content/zotero/itemTree.jsx | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/chrome/content/zotero/itemTree.jsx b/chrome/content/zotero/itemTree.jsx
index 719f61c2c6..d907f15fa1 100644
--- a/chrome/content/zotero/itemTree.jsx
+++ b/chrome/content/zotero/itemTree.jsx
@@ -933,13 +933,6 @@ var ItemTree = class ItemTree extends LibraryTree {
 			}}
 			className={"items-tree-message"}
 			style={{ display: showMessage ? "flex" : "none" }}
-			// Due to some collision between React and the XUL environment
-			// setting innerHTML on a cached React node triggers an XML
-			// parsing error god knows where. So on every refresh we set a new
-			// key for the element, forcing it to be recreated. This shouldn't
-			// be a major performance concern since we're not calling #forceUpdate()
-			// that often and even if we did it's just a single div here.
-			key={Date.now()}
 			dangerouslySetInnerHTML={{ __html: itemsPaneMessageHTML }}>
 		</div>);