scriptoriumadmin/skillhub
1
0
Fork 0
mirror of https://github.com/iflytek/skillhub.git synced 2026-11-14 09:01:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

test(review): assert explicit display name in namespace E2E

Browse source 
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
This commit is contained in:
XiaoSeS 2026-10-20 19:33:51 +08:00
parent 62e215bbd0
commit 53663267df
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
web/e2e/helpers/review-seed.ts
View file

@ -27,7 +27,7 @@ export async function createNamespaceReviewData(
browser: Browser,
page: Page,
testInfo: TestInfo,
): Promise<SeededReviewData & { reviewTaskId: number; cleanup: () => Promise<void> }> {
): Promise<SeededReviewData & { skillDisplayName: string; reviewTaskId: number; cleanup: () => Promise<void> }> {
const credentials = await registerSession(page, testInfo, { allowMockSession: false })
const builder = new E2eTestDataBuilder(page, testInfo)
await builder.init()
@ -48,12 +48,14 @@ export async function createNamespaceReviewData(
}
await adminBuilder.addNamespaceMember(namespace.slug, matchedCandidate.userId, 'ADMIN')
const skill = await builder.publishSkill(namespace.slug)
const skillDisplayName = 'E2E namespace review'
const skill = await builder.publishSkill(namespace.slug, { displayName: skillDisplayName })
const reviewTaskId = await adminBuilder.waitForPendingReview(namespace.slug, skill.slug, skill.version)
return {
namespace,
skill,
skillDisplayName,
reviewTaskId,
cleanup: async () => {
await builder.cleanup()

4
web/e2e/namespace-review-detail-access.spec.ts
View file

@ -25,7 +25,7 @@ test.describe('Namespace Review Detail Access (Real API)', () => {
await page.getByRole('link', { name: 'Open review' }).first().click()
await expect(page).toHaveURL(new RegExp(`/dashboard/namespaces/${seeded.namespace.slug}/reviews/\\d+$`))
await expect(page.getByRole('heading', { level: 1, name: seeded.skill.slug, exact: true })).toBeVisible()
await expect(page.getByRole('heading', { level: 1, name: seeded.skillDisplayName, exact: true })).toBeVisible()
await expect(page.getByText(`${seeded.namespace.slug}/${seeded.skill.slug}`).first()).toBeVisible()
} finally {
await seeded?.cleanup()
@ -59,7 +59,7 @@ test.describe('Namespace Review Detail Access (Real API)', () => {
await page.goto(`/dashboard/reviews/${seeded.reviewTaskId}`)
await expect(page).toHaveURL(new RegExp(`/dashboard/namespaces/${seeded.namespace.slug}/reviews/${seeded.reviewTaskId}$`))
await expect(page.getByRole('heading', { level: 1, name: seeded.skill.slug, exact: true })).toBeVisible()
await expect(page.getByRole('heading', { level: 1, name: seeded.skillDisplayName, exact: true })).toBeVisible()
} finally {
await seeded?.cleanup()
}