From 53663267df1c5889f8fc6fde3403c72dcbdca920 Mon Sep 17 00:00:00 2001
From: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Date: Tue, 20 Oct 2026 19:33:51 +0800
Subject: [PATCH] test(review): assert explicit display name in namespace E2E

Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
---
 web/e2e/helpers/review-seed.ts                 | 6 ++++--
 web/e2e/namespace-review-detail-access.spec.ts | 4 ++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/web/e2e/helpers/review-seed.ts b/web/e2e/helpers/review-seed.ts
index 683ad2b5d..b782c8819 100644
--- a/web/e2e/helpers/review-seed.ts
+++ b/web/e2e/helpers/review-seed.ts
@@ -27,7 +27,7 @@ export async function createNamespaceReviewData(
   browser: Browser,
   page: Page,
   testInfo: TestInfo,
-): Promise<SeededReviewData & { reviewTaskId: number; cleanup: () => Promise<void> }> {
+): Promise<SeededReviewData & { skillDisplayName: string; reviewTaskId: number; cleanup: () => Promise<void> }> {
   const credentials = await registerSession(page, testInfo, { allowMockSession: false })
   const builder = new E2eTestDataBuilder(page, testInfo)
   await builder.init()
@@ -48,12 +48,14 @@ export async function createNamespaceReviewData(
   }
 
   await adminBuilder.addNamespaceMember(namespace.slug, matchedCandidate.userId, 'ADMIN')
-  const skill = await builder.publishSkill(namespace.slug)
+  const skillDisplayName = 'E2E namespace review'
+  const skill = await builder.publishSkill(namespace.slug, { displayName: skillDisplayName })
   const reviewTaskId = await adminBuilder.waitForPendingReview(namespace.slug, skill.slug, skill.version)
 
   return {
     namespace,
     skill,
+    skillDisplayName,
     reviewTaskId,
     cleanup: async () => {
       await builder.cleanup()
diff --git a/web/e2e/namespace-review-detail-access.spec.ts b/web/e2e/namespace-review-detail-access.spec.ts
index f66c66029..161e4948f 100644
--- a/web/e2e/namespace-review-detail-access.spec.ts
+++ b/web/e2e/namespace-review-detail-access.spec.ts
@@ -25,7 +25,7 @@ test.describe('Namespace Review Detail Access (Real API)', () => {
       await page.getByRole('link', { name: 'Open review' }).first().click()
 
       await expect(page).toHaveURL(new RegExp(`/dashboard/namespaces/${seeded.namespace.slug}/reviews/\\d+$`))
-      await expect(page.getByRole('heading', { level: 1, name: seeded.skill.slug, exact: true })).toBeVisible()
+      await expect(page.getByRole('heading', { level: 1, name: seeded.skillDisplayName, exact: true })).toBeVisible()
       await expect(page.getByText(`${seeded.namespace.slug}/${seeded.skill.slug}`).first()).toBeVisible()
     } finally {
       await seeded?.cleanup()
@@ -59,7 +59,7 @@ test.describe('Namespace Review Detail Access (Real API)', () => {
       await page.goto(`/dashboard/reviews/${seeded.reviewTaskId}`)
 
       await expect(page).toHaveURL(new RegExp(`/dashboard/namespaces/${seeded.namespace.slug}/reviews/${seeded.reviewTaskId}$`))
-      await expect(page.getByRole('heading', { level: 1, name: seeded.skill.slug, exact: true })).toBeVisible()
+      await expect(page.getByRole('heading', { level: 1, name: seeded.skillDisplayName, exact: true })).toBeVisible()
     } finally {
       await seeded?.cleanup()
     }