scriptoriumadmin/open-webui
1
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-10-06 02:48:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: file uploads and hybrid search fail on Qdrant with strict mode enabled (#31461)

Browse source 
With Qdrant strict mode on and a max_query_limit below 999999999, Qdrant rejects Open WebUI's reads with "Limit exceeded", so every file upload after the first fails in the default multitenancy mode, and hybrid search finds nothing. Reads now go in pages of 1000 points, so any strict-mode limit of 1000 or more works. Without strict mode the results are the same as before.

Tested against Qdrant 1.19.1 with max_query_limit 1000, for both multitenancy on and off: collections of up to 2500 points come back complete, limits are respected, and tenants stay separated.

Fixes #31459
This commit is contained in:
Classic298 2026-09-27 20:58:42 +02:00 • committed by GitHub
parent 2ab5023e5a
commit 8a90f0fc93
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 43 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
backend/open_webui/retrieval/vector/dbs/qdrant.py
View file

@ -28,6 +28,7 @@ from qdrant_client.http.models import PointStruct
from qdrant_client.models import models
NO_LIMIT = 999999999
SCROLL_PAGE_SIZE = 1000
log = logging.getLogger(__name__)
@ -92,6 +93,24 @@ class QdrantClient(VectorDBBase):
}
)
def _scroll_points(
self, collection_name: str, scroll_filter: Optional[models.Filter] = None, limit: Optional[int] = None
) -> list:
# Paged so a strict-mode max_query_limit does not reject the read
points = []
offset = None
while True:
page_size = SCROLL_PAGE_SIZE if limit is None else min(SCROLL_PAGE_SIZE, limit - len(points))
page, offset = self.client.scroll(
collection_name=f'{self.collection_prefix}_{collection_name}',
scroll_filter=scroll_filter,
limit=page_size,
offset=offset,
)
points.extend(page)
if offset is None or len(points) == limit:
return points
def _create_collection(self, collection_name: str, dimension: int):
collection_name_with_prefix = f'{self.collection_prefix}_{collection_name}'
self.client.create_collection(
@ -180,32 +199,22 @@ class QdrantClient(VectorDBBase):
if not self.has_collection(collection_name):
return None
try:
if limit is None:
limit = NO_LIMIT # otherwise qdrant would set limit to 10!
field_conditions = []
for key, value in filter.items():
field_conditions.append(
models.FieldCondition(key=f'metadata.{key}', match=models.MatchValue(value=value))
)
points = self.client.scroll(
collection_name=f'{self.collection_prefix}_{collection_name}',
scroll_filter=models.Filter(should=field_conditions),
limit=limit,
)
return self._result_to_get_result(points[0])
points = self._scroll_points(collection_name, models.Filter(should=field_conditions), limit)
return self._result_to_get_result(points)
except Exception as e:
log.exception(f"Error querying a collection '{collection_name}': {e}")
return None
def get(self, collection_name: str) -> Optional[GetResult]:
# Get all the items in the collection.
points = self.client.scroll(
collection_name=f'{self.collection_prefix}_{collection_name}',
limit=NO_LIMIT, # otherwise qdrant would set limit to 10!
)
return self._result_to_get_result(points[0])
points = self._scroll_points(collection_name)
return self._result_to_get_result(points)
def insert(self, collection_name: str, items: list[VectorItem]):
# Insert the items into the collection, if the collection does not exist, it will be created.

35
backend/open_webui/retrieval/vector/dbs/qdrant_multitenancy.py
View file

@ -29,7 +29,7 @@ from qdrant_client.http.exceptions import UnexpectedResponse
from qdrant_client.http.models import PointStruct
from qdrant_client.models import models
NO_LIMIT = 999999999
SCROLL_PAGE_SIZE = 1000
TENANT_ID_FIELD = 'tenant_id'
DEFAULT_DIMENSION = 384
@ -97,6 +97,21 @@ class QdrantClient(VectorDBBase):
metadatas.append(payload['metadata'])
return GetResult(ids=[ids], documents=[documents], metadatas=[metadatas])
def _scroll_points(self, collection_name: str, scroll_filter: models.Filter, limit: Optional[int] = None) -> List:
# Paged so a strict-mode max_query_limit does not reject the read
points, offset = [], None
while True:
page_size = SCROLL_PAGE_SIZE if limit is None else min(SCROLL_PAGE_SIZE, limit - len(points))
page, offset = self.client.scroll(
collection_name=collection_name,
scroll_filter=scroll_filter,
limit=page_size,
offset=offset,
)
points.extend(page)
if offset is None or len(points) == limit:
return points
def _get_collection_and_tenant_id(self, collection_name: str) -> Tuple[str, str]:
"""
Maps the traditional collection name to multi-tenant collection and tenant ID.
@ -287,17 +302,11 @@ class QdrantClient(VectorDBBase):
if not self.client.collection_exists(collection_name=mt_collection):
log.debug("Collection %s doesn't exist, query returns None", mt_collection)
return None
if limit is None:
limit = NO_LIMIT
tenant_filter = _tenant_filter(tenant_id)
field_conditions = [_metadata_filter(k, '$eq', v) for k, v in filter.items()]
combined_filter = models.Filter(must=[tenant_filter, *field_conditions])
points = self.client.scroll(
collection_name=mt_collection,
scroll_filter=combined_filter,
limit=limit,
)
return self._result_to_get_result(points[0])
points = self._scroll_points(mt_collection, combined_filter, limit)
return self._result_to_get_result(points)
def get(self, collection_name: str) -> Optional[GetResult]:
"""
@ -310,12 +319,8 @@ class QdrantClient(VectorDBBase):
log.debug("Collection %s doesn't exist, get returns None", mt_collection)
return None
tenant_filter = _tenant_filter(tenant_id)
points = self.client.scroll(
collection_name=mt_collection,
scroll_filter=models.Filter(must=[tenant_filter]),
limit=NO_LIMIT,
)
return self._result_to_get_result(points[0])
points = self._scroll_points(mt_collection, models.Filter(must=[tenant_filter]))
return self._result_to_get_result(points)
def upsert(self, collection_name: str, items: List[VectorItem]):
"""