scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-10-10 03:28:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 86

fix: address PR review - allow clearing router settings, remove unused modelData prop

Browse source 
- Send router_settings when clearing existing settings (so backend
  updates instead of silently retaining old values)
- Remove unused modelData prop from RouterSettingsAccordion (it fetches
  models internally via fetchAvailableModels)
This commit is contained in:
Yuneng Jiang 2026-04-08 22:24:21 -07:00
parent 4ba9219e1d
commit e8c51ecd7c
No known key found for this signature in database
1 changed files with 13 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
ui/litellm-dashboard/src/components/team/TeamInfo.tsx
View file

@ -592,19 +592,21 @@ const TeamInfoView: React.FC<TeamInfoProps> = ({
}
// Handle router_settings - read fresh values from DOM at save time.
// Only include if the user actually configured something meaningful
// (exclude defaults like enable_tag_filtering: false and empty arrays).
const currentRouterSettings = routerSettingsRef.current?.getValue();
if (currentRouterSettings?.router_settings) {
const hasValues = Object.values(currentRouterSettings.router_settings).some(
(value) =>
value !== null &&
value !== undefined &&
value !== "" &&
value !== false &&
!(Array.isArray(value) && value.length === 0),
);
if (hasValues) {
const isMeaningfulValue = (value: unknown) =>
value !== null &&
value !== undefined &&
value !== "" &&
value !== false &&
!(Array.isArray(value) && value.length === 0);
const hasNewValues = Object.values(currentRouterSettings.router_settings).some(isMeaningfulValue);
const hadExistingSettings = info.router_settings &&
Object.values(info.router_settings).some(isMeaningfulValue);
// Send if there are new values OR if the user is clearing existing ones
if (hasNewValues || hadExistingSettings) {
updateData.router_settings = currentRouterSettings.router_settings;
}
}
@ -1112,7 +1114,6 @@ const TeamInfoView: React.FC<TeamInfoProps> = ({
ref={routerSettingsRef}
accessToken={accessToken || ""}
value={info.router_settings ? { router_settings: info.router_settings } : undefined}
modelData={userModels.length > 0 ? { data: userModels.map((model) => ({ model_name: model })) } : undefined}
/>
</Form.Item>