From e8c51ecd7c61f871ed044eb8f22bee98c51821eb Mon Sep 17 00:00:00 2001
From: Yuneng Jiang <yuneng@berri.ai>
Date: Wed, 8 Apr 2026 22:24:21 -0700
Subject: [PATCH] fix: address PR review - allow clearing router settings,
 remove unused modelData prop

- Send router_settings when clearing existing settings (so backend
  updates instead of silently retaining old values)
- Remove unused modelData prop from RouterSettingsAccordion (it fetches
  models internally via fetchAvailableModels)
---
 .../src/components/team/TeamInfo.tsx          | 25 ++++++++++---------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/ui/litellm-dashboard/src/components/team/TeamInfo.tsx b/ui/litellm-dashboard/src/components/team/TeamInfo.tsx
index 96cde701f7d..a4008e08342 100644
--- a/ui/litellm-dashboard/src/components/team/TeamInfo.tsx
+++ b/ui/litellm-dashboard/src/components/team/TeamInfo.tsx
@@ -592,19 +592,21 @@ const TeamInfoView: React.FC<TeamInfoProps> = ({
       }
 
       // Handle router_settings - read fresh values from DOM at save time.
-      // Only include if the user actually configured something meaningful
-      // (exclude defaults like enable_tag_filtering: false and empty arrays).
       const currentRouterSettings = routerSettingsRef.current?.getValue();
       if (currentRouterSettings?.router_settings) {
-        const hasValues = Object.values(currentRouterSettings.router_settings).some(
-          (value) =>
-            value !== null &&
-            value !== undefined &&
-            value !== "" &&
-            value !== false &&
-            !(Array.isArray(value) && value.length === 0),
-        );
-        if (hasValues) {
+        const isMeaningfulValue = (value: unknown) =>
+          value !== null &&
+          value !== undefined &&
+          value !== "" &&
+          value !== false &&
+          !(Array.isArray(value) && value.length === 0);
+
+        const hasNewValues = Object.values(currentRouterSettings.router_settings).some(isMeaningfulValue);
+        const hadExistingSettings = info.router_settings &&
+          Object.values(info.router_settings).some(isMeaningfulValue);
+
+        // Send if there are new values OR if the user is clearing existing ones
+        if (hasNewValues || hadExistingSettings) {
           updateData.router_settings = currentRouterSettings.router_settings;
         }
       }
@@ -1112,7 +1114,6 @@ const TeamInfoView: React.FC<TeamInfoProps> = ({
                         ref={routerSettingsRef}
                         accessToken={accessToken || ""}
                         value={info.router_settings ? { router_settings: info.router_settings } : undefined}
-                        modelData={userModels.length > 0 ? { data: userModels.map((model) => ({ model_name: model })) } : undefined}
                       />
                     </Form.Item>