scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-11 22:51:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 124

refactor: inline get_upstream_initialize_instructions

Browse source 
Remove the trivial one-line wrapper and access the dict directly.

Made-with: Cursor
This commit is contained in:
Milan 2026-04-14 15:59:00 +03:00
parent 7e656f4329
commit e7c630ed19
No known key found for this signature in database
3 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
litellm/proxy/_experimental/mcp_server/mcp_server_manager.py
View file

@ -186,9 +186,6 @@ class MCPServerManager:
"""
self._upstream_initialize_instructions_by_server_id: Dict[str, str] = {}
def get_upstream_initialize_instructions(self, server_id: str) -> Optional[str]:
return self._upstream_initialize_instructions_by_server_id.get(server_id)
def _remember_upstream_initialize_instructions(
self, server: MCPServer, client: MCPClient
) -> None:

2
litellm/proxy/_experimental/mcp_server/server.py
View file

@ -1148,7 +1148,7 @@ if MCP_AVAILABLE:
continue
if server.spec_path:
continue
cached = global_mcp_server_manager.get_upstream_initialize_instructions(
cached = global_mcp_server_manager._upstream_initialize_instructions_by_server_id.get(
server.server_id
)
if cached and cached.strip():

10
tests/test_litellm/proxy/_experimental/mcp_server/test_mcp_server_manager.py
View file

@ -2494,7 +2494,7 @@ class TestMCPServerManagerUpstreamInstructionsCache:
def test_get_returns_none_when_empty(self):
"""Empty cache returns None for any key."""
manager = MCPServerManager()
assert manager.get_upstream_initialize_instructions("nonexistent") is None
assert manager._upstream_initialize_instructions_by_server_id.get("nonexistent") is None
def test_remember_stores_stripped_value(self):
"""_remember_upstream_initialize_instructions stores a stripped string."""
@ -2502,7 +2502,7 @@ class TestMCPServerManagerUpstreamInstructionsCache:
fake_server = MagicMock(server_id="srv")
fake_client = MagicMock(_last_initialize_instructions=" hello \n")
manager._remember_upstream_initialize_instructions(fake_server, fake_client)
assert manager.get_upstream_initialize_instructions("srv") == "hello"
assert manager._upstream_initialize_instructions_by_server_id.get("srv") == "hello"
def test_remember_ignores_empty_string(self):
"""Whitespace-only instructions are not stored."""
@ -2510,7 +2510,7 @@ class TestMCPServerManagerUpstreamInstructionsCache:
fake_server = MagicMock(server_id="srv")
fake_client = MagicMock(_last_initialize_instructions=" ")
manager._remember_upstream_initialize_instructions(fake_server, fake_client)
assert manager.get_upstream_initialize_instructions("srv") is None
assert manager._upstream_initialize_instructions_by_server_id.get("srv") is None
def test_remember_ignores_none(self):
"""None instructions are not stored."""
@ -2518,7 +2518,7 @@ class TestMCPServerManagerUpstreamInstructionsCache:
fake_server = MagicMock(server_id="srv")
fake_client = MagicMock(_last_initialize_instructions=None)
manager._remember_upstream_initialize_instructions(fake_server, fake_client)
assert manager.get_upstream_initialize_instructions("srv") is None
assert manager._upstream_initialize_instructions_by_server_id.get("srv") is None
@pytest.mark.asyncio
async def test_load_servers_from_config_clears_cache(self):
@ -2533,7 +2533,7 @@ class TestMCPServerManagerUpstreamInstructionsCache:
}
}
)
assert manager.get_upstream_initialize_instructions("old") is None
assert manager._upstream_initialize_instructions_by_server_id.get("old") is None
@pytest.mark.asyncio
async def test_load_servers_reads_instructions_from_config(self):