diff --git a/litellm/proxy/_experimental/mcp_server/mcp_server_manager.py b/litellm/proxy/_experimental/mcp_server/mcp_server_manager.py index 750c9204c55..68b858868ad 100644 --- a/litellm/proxy/_experimental/mcp_server/mcp_server_manager.py +++ b/litellm/proxy/_experimental/mcp_server/mcp_server_manager.py @@ -186,9 +186,6 @@ class MCPServerManager: """ self._upstream_initialize_instructions_by_server_id: Dict[str, str] = {} - def get_upstream_initialize_instructions(self, server_id: str) -> Optional[str]: - return self._upstream_initialize_instructions_by_server_id.get(server_id) - def _remember_upstream_initialize_instructions( self, server: MCPServer, client: MCPClient ) -> None: diff --git a/litellm/proxy/_experimental/mcp_server/server.py b/litellm/proxy/_experimental/mcp_server/server.py index b7dbdeed5fc..adeacc06f8a 100644 --- a/litellm/proxy/_experimental/mcp_server/server.py +++ b/litellm/proxy/_experimental/mcp_server/server.py @@ -1148,7 +1148,7 @@ if MCP_AVAILABLE: continue if server.spec_path: continue - cached = global_mcp_server_manager.get_upstream_initialize_instructions( + cached = global_mcp_server_manager._upstream_initialize_instructions_by_server_id.get( server.server_id ) if cached and cached.strip(): diff --git a/tests/test_litellm/proxy/_experimental/mcp_server/test_mcp_server_manager.py b/tests/test_litellm/proxy/_experimental/mcp_server/test_mcp_server_manager.py index 503ef71173f..aa95836a927 100644 --- a/tests/test_litellm/proxy/_experimental/mcp_server/test_mcp_server_manager.py +++ b/tests/test_litellm/proxy/_experimental/mcp_server/test_mcp_server_manager.py @@ -2494,7 +2494,7 @@ class TestMCPServerManagerUpstreamInstructionsCache: def test_get_returns_none_when_empty(self): """Empty cache returns None for any key.""" manager = MCPServerManager() - assert manager.get_upstream_initialize_instructions("nonexistent") is None + assert manager._upstream_initialize_instructions_by_server_id.get("nonexistent") is None def test_remember_stores_stripped_value(self): """_remember_upstream_initialize_instructions stores a stripped string.""" @@ -2502,7 +2502,7 @@ class TestMCPServerManagerUpstreamInstructionsCache: fake_server = MagicMock(server_id="srv") fake_client = MagicMock(_last_initialize_instructions=" hello \n") manager._remember_upstream_initialize_instructions(fake_server, fake_client) - assert manager.get_upstream_initialize_instructions("srv") == "hello" + assert manager._upstream_initialize_instructions_by_server_id.get("srv") == "hello" def test_remember_ignores_empty_string(self): """Whitespace-only instructions are not stored.""" @@ -2510,7 +2510,7 @@ class TestMCPServerManagerUpstreamInstructionsCache: fake_server = MagicMock(server_id="srv") fake_client = MagicMock(_last_initialize_instructions=" ") manager._remember_upstream_initialize_instructions(fake_server, fake_client) - assert manager.get_upstream_initialize_instructions("srv") is None + assert manager._upstream_initialize_instructions_by_server_id.get("srv") is None def test_remember_ignores_none(self): """None instructions are not stored.""" @@ -2518,7 +2518,7 @@ class TestMCPServerManagerUpstreamInstructionsCache: fake_server = MagicMock(server_id="srv") fake_client = MagicMock(_last_initialize_instructions=None) manager._remember_upstream_initialize_instructions(fake_server, fake_client) - assert manager.get_upstream_initialize_instructions("srv") is None + assert manager._upstream_initialize_instructions_by_server_id.get("srv") is None @pytest.mark.asyncio async def test_load_servers_from_config_clears_cache(self): @@ -2533,7 +2533,7 @@ class TestMCPServerManagerUpstreamInstructionsCache: } } ) - assert manager.get_upstream_initialize_instructions("old") is None + assert manager._upstream_initialize_instructions_by_server_id.get("old") is None @pytest.mark.asyncio async def test_load_servers_reads_instructions_from_config(self):