scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-19 00:01:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 122

fix(ui/memory): preserve slashes in key path encoding

Browse source 
The backend route `/v1/memory/{key:path}` supports keys with slashes,
but `encodeURIComponent` encoded `/` as `%2F`. Some proxies (nginx
default, CloudFlare, AWS ALB) reject or re-decode `%2F` mid-flight,
so UI update/delete calls on slash-containing keys could fail or
silently misroute.

New helper `encodeMemoryKeyForPath` splits by `/`, URL-encodes each
segment, then rejoins with literal `/`. Every other unsafe char
(spaces, `?`, `#`, `%`) stays encoded per-segment; slashes stay as
path delimiters, matching what the `:path` converter expects.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Krrish Dholakia 2026-04-23 22:47:23 -07:00
parent dd200958cd
commit c1ccfb397b
1 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
ui/litellm-dashboard/src/components/networking.tsx
View file

@ -9991,6 +9991,22 @@ export const listMCPUserCredentials = async (
// Memory management (/v1/memory)
// ============================================================
/**
* Encode a memory key for use in a URL path segment.
*
* The backend route is declared as `/v1/memory/{key:path}`, which supports
* slashes in the key (e.g. `user/123/notes`). Plain `encodeURIComponent`
* encodes `/` as `%2F`, and some proxies/middlewares (nginx default,
* CloudFlare, AWS ALB) either reject or silently re-decode `%2F`, which
* can break the request before FastAPI ever sees it.
*
* We keep slashes literal as path delimiters while still encoding every
* other potentially-unsafe character (spaces, `?`, `#`, `%`, etc.) per
* path segment.
*/
const encodeMemoryKeyForPath = (key: string): string =>
key.split("/").map(encodeURIComponent).join("/");
export interface MemoryRow {
memory_id: string;
key: string;
@ -10075,7 +10091,7 @@ export const updateMemory = async (
key: string,
payload: { value?: string; metadata?: unknown },
): Promise<MemoryRow> => {
const encoded = encodeURIComponent(key);
const encoded = encodeMemoryKeyForPath(key);
const url = proxyBaseUrl
? `${proxyBaseUrl}/v1/memory/${encoded}`
: `/v1/memory/${encoded}`;
@ -10098,7 +10114,7 @@ export const deleteMemory = async (
accessToken: string,
key: string,
): Promise<void> => {
const encoded = encodeURIComponent(key);
const encoded = encodeMemoryKeyForPath(key);
const url = proxyBaseUrl
? `${proxyBaseUrl}/v1/memory/${encoded}`
: `/v1/memory/${encoded}`;