scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-17 23:51:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 66

fix(ui/memory): send explicit null when user clears metadata

Browse source 
Addresses the remaining P1 from the last greptile review:

When the edit modal's metadata textarea was cleared and saved,
`metadataParsed` stayed `undefined`, `JSON.stringify` dropped the key
entirely, and the backend's `model_fields_set` guard therefore left
the stored metadata untouched — UI showed success but nothing changed.

Now: empty textarea on edit → send explicit `null` so the backend
sees `metadata` in `model_fields_set` and clears the column.
Empty textarea on create still maps to `undefined` (field omitted)
to avoid Prisma's `Json? = None` quirk on insert.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Krrish Dholakia 2026-04-23 22:19:49 -07:00
parent be7fe9b5f5
commit dd200958cd
1 changed files with 17 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
ui/litellm-dashboard/src/components/MemoryView/MemoryView.tsx
View file

@ -127,27 +127,39 @@ export const MemoryView: React.FC<MemoryViewProps> = ({ accessToken }) => {
isCreate: boolean,
): Promise<boolean> => {
if (!accessToken) return false;
let metadataParsed: unknown | undefined;
if (metadataText.trim()) {
// On edit, an empty textarea is a user's intent to CLEAR existing
// metadata — we must send explicit `null` (not `undefined`), or
// JSON.stringify drops the field and the backend's model_fields_set
// won't see it, leaving the stored value untouched.
//
// On create, an empty textarea just means "no metadata" — we omit the
// field so the DB default (NULL) applies and we avoid Prisma's
// `Json? = None` quirk on create.
let metadataPayload: unknown;
if (!metadataText.trim()) {
metadataPayload = isCreate ? undefined : null;
} else {
try {
metadataParsed = JSON.parse(metadataText);
metadataPayload = JSON.parse(metadataText);
} catch {
message.error("Metadata must be valid JSON (or leave empty).");
return false;
}
}
try {
if (isCreate) {
await createMemory(accessToken, {
key,
value,
metadata: metadataParsed,
metadata: metadataPayload,
});
message.success(`Created ${key}`);
} else {
await updateMemory(accessToken, key, {
value,
metadata: metadataParsed,
metadata: metadataPayload,
});
message.success(`Updated ${key}`);
}