(sap) fix after bot review

This commit is contained in:
Vasilisa Parshikova 2026-03-11 17:47:09 +04:00 • committed by Sameer Kankute
parent bde544cad7
commit 4630ef90c5
No known key found for this signature in database
2 changed files with 6 additions and 2 deletions

View file

@ -285,7 +285,11 @@ class GenAIHubOrchestrationConfig(OpenAIGPTConfig):
for modules_dict in fallback_modules:
modules_dict = dict(modules_dict)
fallback_model = modules_dict.pop("model")
fallback_model = modules_dict.pop("model", None)
if fallback_model is None:
raise ValueError(
"Each entry in `fallback_sap_modules` must include a 'model' key."
)
if fallback_model.startswith("sap/"):
fallback_model = fallback_model[4:]
fallback_template = modules_dict.pop("messages", [])

View file

@ -162,7 +162,7 @@ class GenAIHubEmbeddingConfig(BaseEmbeddingConfig):
model_dict["params"] = optional_params.get("parameters", {})
if optional_params.get("timeout", None):
model_dict["timeout"] = optional_params.get("timeout")
if optional_params.get("max_retries", None):
if optional_params.get("max_retries", None) is not None:
model_dict["max_retries"] = optional_params.get("max_retries")
input_dict = {"text": input}
if optional_params.get("type"):