From 4630ef90c51f88a5499902842ed598cb21142351 Mon Sep 17 00:00:00 2001 From: Vasilisa Parshikova Date: Wed, 11 Mar 2026 17:47:09 +0400 Subject: [PATCH] (sap) fix after bot review --- litellm/llms/sap/chat/transformation.py | 6 +++++- litellm/llms/sap/embed/transformation.py | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/litellm/llms/sap/chat/transformation.py b/litellm/llms/sap/chat/transformation.py index b1196a8b70d..9049ea3a35b 100755 --- a/litellm/llms/sap/chat/transformation.py +++ b/litellm/llms/sap/chat/transformation.py @@ -285,7 +285,11 @@ class GenAIHubOrchestrationConfig(OpenAIGPTConfig): for modules_dict in fallback_modules: modules_dict = dict(modules_dict) - fallback_model = modules_dict.pop("model") + fallback_model = modules_dict.pop("model", None) + if fallback_model is None: + raise ValueError( + "Each entry in `fallback_sap_modules` must include a 'model' key." + ) if fallback_model.startswith("sap/"): fallback_model = fallback_model[4:] fallback_template = modules_dict.pop("messages", []) diff --git a/litellm/llms/sap/embed/transformation.py b/litellm/llms/sap/embed/transformation.py index df32d4dc826..4583531402b 100644 --- a/litellm/llms/sap/embed/transformation.py +++ b/litellm/llms/sap/embed/transformation.py @@ -162,7 +162,7 @@ class GenAIHubEmbeddingConfig(BaseEmbeddingConfig): model_dict["params"] = optional_params.get("parameters", {}) if optional_params.get("timeout", None): model_dict["timeout"] = optional_params.get("timeout") - if optional_params.get("max_retries", None): + if optional_params.get("max_retries", None) is not None: model_dict["max_retries"] = optional_params.get("max_retries") input_dict = {"text": input} if optional_params.get("type"):