address greptile review feedback (greploop iteration 2)

- Remove re-raise in _store_transactions_in_redis so one Redis
  push failure doesn't drop remaining transaction types
- Downgrade per-push success log from info to debug to reduce noise
- Fix misleading error message in update_database — entity spend
  updates run as independent tasks and are not affected by this catch
This commit is contained in:
yuneng-jiang 2026-02-24 12:10:19 -08:00 committed by Sameer Kankute
parent 0e65eb79d8
commit 18047f4c7c
2 changed files with 3 additions and 3 deletions

View file

@ -168,7 +168,8 @@ class DBSpendUpdateWriter:
verbose_proxy_logger.debug("Runs spend update on all tables")
except Exception:
verbose_proxy_logger.error(
"Spend tracking - update_database failed. All spend updates for this request will be lost. "
"Spend tracking - update_database failed. Spend log insertion or daily transaction enqueue "
"may not have completed for this request. "
"response_cost=%s, token=%s, user_id=%s, team_id=%s, org_id=%s, end_user_id=%s - %s",
response_cost,
token,

View file

@ -101,7 +101,7 @@ class RedisUpdateBuffer:
key=redis_key,
values=list_of_transactions,
)
verbose_proxy_logger.info(
verbose_proxy_logger.debug(
"Spend tracking - pushed spend updates to Redis buffer. "
"redis_key=%s, buffer_size=%s",
redis_key,
@ -118,7 +118,6 @@ class RedisUpdateBuffer:
redis_key,
str(e),
)
raise
async def store_in_memory_spend_updates_in_redis(
self,