From 18047f4c7c95afcd7ceaa7549cfee139cbb7f3a0 Mon Sep 17 00:00:00 2001 From: yuneng-jiang Date: Tue, 24 Feb 2026 12:10:19 -0800 Subject: [PATCH] address greptile review feedback (greploop iteration 2) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Remove re-raise in _store_transactions_in_redis so one Redis push failure doesn't drop remaining transaction types - Downgrade per-push success log from info to debug to reduce noise - Fix misleading error message in update_database — entity spend updates run as independent tasks and are not affected by this catch --- litellm/proxy/db/db_spend_update_writer.py | 3 ++- litellm/proxy/db/db_transaction_queue/redis_update_buffer.py | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/litellm/proxy/db/db_spend_update_writer.py b/litellm/proxy/db/db_spend_update_writer.py index 77619a35ba9..20abe2dbe17 100644 --- a/litellm/proxy/db/db_spend_update_writer.py +++ b/litellm/proxy/db/db_spend_update_writer.py @@ -168,7 +168,8 @@ class DBSpendUpdateWriter: verbose_proxy_logger.debug("Runs spend update on all tables") except Exception: verbose_proxy_logger.error( - "Spend tracking - update_database failed. All spend updates for this request will be lost. " + "Spend tracking - update_database failed. Spend log insertion or daily transaction enqueue " + "may not have completed for this request. " "response_cost=%s, token=%s, user_id=%s, team_id=%s, org_id=%s, end_user_id=%s - %s", response_cost, token, diff --git a/litellm/proxy/db/db_transaction_queue/redis_update_buffer.py b/litellm/proxy/db/db_transaction_queue/redis_update_buffer.py index 85e139b4de0..027f3e639e3 100644 --- a/litellm/proxy/db/db_transaction_queue/redis_update_buffer.py +++ b/litellm/proxy/db/db_transaction_queue/redis_update_buffer.py @@ -101,7 +101,7 @@ class RedisUpdateBuffer: key=redis_key, values=list_of_transactions, ) - verbose_proxy_logger.info( + verbose_proxy_logger.debug( "Spend tracking - pushed spend updates to Redis buffer. " "redis_key=%s, buffer_size=%s", redis_key, @@ -118,7 +118,6 @@ class RedisUpdateBuffer: redis_key, str(e), ) - raise async def store_in_memory_spend_updates_in_redis( self,