Matthew Jaffee
4488ab1062
Merge pull request #1784 from molecula/recordbatch-ingestapi
...
add new RecordBatch implementation which uses ingest API
2021-12-06 20:40:09 -06:00
Matthew Jaffee
77897f3ef0
try to get some more test coverage on error cases
...
(without creating too much duplication!)
2021-12-06 20:19:42 -06:00
Matthew Jaffee
1a4180ca4a
add new RecordBatch implementation which uses ingest API
2021-12-06 17:06:55 -06:00
reese
7788af166f
Merge pull request #1797 from molecula/staticcheck-issues-pt-2
...
[fb-964] fixes some more staticcheck errors
2021-12-06 17:04:35 -06:00
reesporte
a0aaa0f371
don't start error messages with a capital letter
2021-12-06 16:40:13 -06:00
reesporte
0a82474a65
Merge branch 'master' into staticcheck-issues-pt-2
2021-12-06 16:33:25 -06:00
reese
8cd9dcd70d
Merge pull request #1799 from molecula/distinct-timestamp-count
...
[FB-1081] fix count on distinctTimestamp
2021-12-06 16:28:38 -06:00
reesporte
716a3a89c1
added test case
2021-12-06 16:16:43 -06:00
reesporte
060c73fb2f
add some tests for the encoding/decoding of DistinctTimestamp
2021-12-06 15:35:39 -06:00
reesporte
af3c5809e2
add support for multi-node queries
2021-12-06 14:57:05 -06:00
reesporte
4f03228968
fix count on distinctTimestamp
...
adds the ability to get the count of a distinct call to a timestamp field
2021-12-06 11:57:17 -06:00
reese
6ae433efbd
Merge branch 'master' into staticcheck-issues-pt-2
2021-12-06 09:11:59 -06:00
Matthew Jaffee
a8b1b93fa7
Merge pull request #1795 from molecula/topk-on-mutex
...
FB-1079 enable TopK on mutex fields
2021-12-03 17:15:40 -06:00
reesporte
b046ad5e8f
fixes some more staticcheck errors
2021-12-03 16:50:02 -06:00
Matthew Jaffee
bd3e73ba66
refactor test to reduce duplication
...
I guess this is actually better... thanks SonarCloud!
2021-12-03 16:41:49 -06:00
Matthew Jaffee
58b4f40cdc
enable TopK on mutex fields
...
I think it was just an oversight that it wasn't, because this seems to work
2021-12-03 16:41:49 -06:00
reese
d47cf8d3de
Merge pull request #1758 from molecula/staticcheck-issues
...
[FB-964] resolve some more staticcheck issues
2021-12-03 16:39:20 -06:00
reese
3d3d0b7a51
Merge branch 'master' into staticcheck-issues
2021-12-03 16:02:30 -06:00
reese
f4a2960a11
Merge pull request #1796 from molecula/pilosa-rename
...
[FB-1021] rename to pilosa
2021-12-03 15:28:54 -06:00
reesporte
c2964f7c7b
rename to pilosa
...
thanks to alan's comment [here](https://molecula.atlassian.net/browse/FB-1021?focusedCommentId=11721 )
2021-12-03 14:56:18 -06:00
reese
30b45adb30
Merge branch 'master' into staticcheck-issues
2021-12-03 14:28:44 -06:00
souhailanoor
ad5b3da9f9
Merge pull request #1793 from molecula/fb1031-souhaila
...
FB-1031: Update featurebase.conf to enable configuring an arbitrary OAuth2.0 provider as the Identity Provider for FB AuthN/AuthZ
2021-12-03 13:42:13 -06:00
reese
47d70f1aa9
Merge branch 'master' into staticcheck-issues
2021-12-03 13:34:27 -06:00
souhailanoor
2a2e272093
Merge branch 'master' into fb1031-souhaila
2021-12-03 13:00:36 -06:00
seebs
b3270c61eb
Merge pull request #1791 from molecula/sup119
...
FB-1073: handle errors more gracefully, but don't stream CreateKeys
2021-12-03 13:00:23 -06:00
Souhaila Noor
7bcbb5eaca
fixed indentation
2021-12-03 12:10:31 -06:00
Souhaila Noor
90c3c67ce4
fixed test for auth disabled
2021-12-03 12:00:07 -06:00
souhailanoor
e8f5458100
only validate config when auth is enabled
...
Co-authored-by: reese <45641995+reesporte@users.noreply.github.com>
2021-12-03 11:58:08 -06:00
souhailanoor
cebba84bee
add scope to install/featurebase.conf
...
Co-authored-by: Samir Patel <48686912+54mir@users.noreply.github.com>
2021-12-03 11:38:43 -06:00
Souhaila Noor
6425fc50fc
added identity provider scope url as parameter
2021-12-03 11:24:18 -06:00
Souhaila Noor
8bf7f58961
Merge branch 'master' into fb1031-souhaila
2021-12-03 10:59:57 -06:00
Souhaila Noor
06fd65cb31
resolved reviewer's suggestions and made it pretty & user friendly
2021-12-03 10:56:21 -06:00
tgruben
da1cc34f96
Merge branch 'master' into sup119
2021-12-03 10:55:38 -06:00
reesporte
666baffb7d
Merge branch 'master' into staticcheck-issues
2021-12-03 09:36:13 -06:00
reesporte
63c5c11108
fix some staticcheck issues
2021-12-03 09:31:45 -06:00
tgruben
f17d6b836e
Merge pull request #1792 from molecula/store-fix
...
[FB-1041] Handle bitmap page recycling properly
2021-12-02 17:11:42 -06:00
Souhaila Noor
978f236c59
resolved additional comments
2021-12-02 16:36:04 -06:00
Souhaila Noor
78e11e0fda
resolved reviewer's comments
2021-12-02 16:15:15 -06:00
tgruben
3e5877299b
Merge branch 'master' into store-fix
2021-12-02 16:00:53 -06:00
Todd Gruben
1df90af26e
free bitmap pages on deallocate
2021-12-02 15:57:52 -06:00
Souhaila Noor
50d80f2f1c
fixed arg cli descriptions
2021-12-02 14:52:38 -06:00
Souhaila Noor
aebd4c4c62
fixed formatting
2021-12-02 14:22:08 -06:00
Souhaila Noor
7de3eaa935
resolved review's comment
2021-12-02 14:19:59 -06:00
Souhaila Noor
91c8bf5e05
fixed duplicated empty string
2021-12-02 14:04:21 -06:00
Souhaila Noor
214a6dfac4
Merge branch 'fb1031-souhaila' of github.com:molecula/featurebase into fb1031-souhaila
2021-12-02 14:01:06 -06:00
Souhaila Noor
64b31da4a1
resolved duplicated line
2021-12-02 14:00:51 -06:00
souhailanoor
0189b2eef7
Merge branch 'master' into fb1031-souhaila
2021-12-02 13:11:19 -06:00
Souhaila Noor
b5ba3fb2ea
added auth arg validation and set up auth package
2021-12-02 13:09:13 -06:00
Seebs
8b20406f45
experiment: handle errors more gracefully, but don't stream CreateKeys
...
We were trying to write an error to a ResponseWriter After attempting to
write to it, and this produces messages about superfluous WriteHeaders,
which is correct. This patch changes things so that we report messages
more clearly and verbosely if we hit them before writing, and if we try
to write and fail, we log the message because that's all we can do.
This does change semantics slightly, in that now we're marshalling
separately from trying to write the marshalled data. I think this is
probably a reasonable call because it lets us get diagnostics about a
hypothetical encoding problem, but in practice I don't think there
should be any encoding problems. So my guess is the actual error will
occur in that last line, and be logged to the server console instead
of failing to write over HTTP.
Also note that this changes some of the messages to include the
underlying error they're complaining about.
We also merge the create/find and index/field cases because only a
couple of lines of code changed between four largeish functions,
and we test some of the failure cases.
We don't have test coverage on the "field isn't provided" type things
because the mux won't actually route things there without them, so
far as I know.
2021-12-01 11:06:54 -06:00
tgruben
73f3c01284
Merge pull request #1790 from molecula/tgruben-patch-1
2021-11-30 21:34:27 -06:00
