Commit graph

8312 commits

Author SHA1 Message Date
reese
f4a2960a11
Merge pull request #1796 from molecula/pilosa-rename
[FB-1021] rename to pilosa
2021-12-03 15:28:54 -06:00
reesporte
c2964f7c7b rename to pilosa
thanks to alan's comment [here](https://molecula.atlassian.net/browse/FB-1021?focusedCommentId=11721)
2021-12-03 14:56:18 -06:00
souhailanoor
ad5b3da9f9
Merge pull request #1793 from molecula/fb1031-souhaila
FB-1031: Update featurebase.conf to enable configuring an arbitrary OAuth2.0 provider as the Identity Provider for FB AuthN/AuthZ
2021-12-03 13:42:13 -06:00
souhailanoor
2a2e272093
Merge branch 'master' into fb1031-souhaila 2021-12-03 13:00:36 -06:00
seebs
b3270c61eb
Merge pull request #1791 from molecula/sup119
FB-1073:  handle errors more gracefully, but don't stream CreateKeys
2021-12-03 13:00:23 -06:00
Souhaila Noor
7bcbb5eaca fixed indentation 2021-12-03 12:10:31 -06:00
Souhaila Noor
90c3c67ce4 fixed test for auth disabled 2021-12-03 12:00:07 -06:00
souhailanoor
e8f5458100
only validate config when auth is enabled
Co-authored-by: reese <45641995+reesporte@users.noreply.github.com>
2021-12-03 11:58:08 -06:00
souhailanoor
cebba84bee
add scope to install/featurebase.conf
Co-authored-by: Samir Patel <48686912+54mir@users.noreply.github.com>
2021-12-03 11:38:43 -06:00
Souhaila Noor
6425fc50fc added identity provider scope url as parameter 2021-12-03 11:24:18 -06:00
Souhaila Noor
8bf7f58961 Merge branch 'master' into fb1031-souhaila 2021-12-03 10:59:57 -06:00
Souhaila Noor
06fd65cb31 resolved reviewer's suggestions and made it pretty & user friendly 2021-12-03 10:56:21 -06:00
tgruben
da1cc34f96
Merge branch 'master' into sup119 2021-12-03 10:55:38 -06:00
tgruben
f17d6b836e
Merge pull request #1792 from molecula/store-fix
[FB-1041] Handle bitmap page recycling properly
2021-12-02 17:11:42 -06:00
Souhaila Noor
978f236c59 resolved additional comments 2021-12-02 16:36:04 -06:00
Souhaila Noor
78e11e0fda resolved reviewer's comments 2021-12-02 16:15:15 -06:00
tgruben
3e5877299b
Merge branch 'master' into store-fix 2021-12-02 16:00:53 -06:00
Todd Gruben
1df90af26e free bitmap pages on deallocate 2021-12-02 15:57:52 -06:00
Souhaila Noor
50d80f2f1c fixed arg cli descriptions 2021-12-02 14:52:38 -06:00
Souhaila Noor
aebd4c4c62 fixed formatting 2021-12-02 14:22:08 -06:00
Souhaila Noor
7de3eaa935 resolved review's comment 2021-12-02 14:19:59 -06:00
Souhaila Noor
91c8bf5e05 fixed duplicated empty string 2021-12-02 14:04:21 -06:00
Souhaila Noor
214a6dfac4 Merge branch 'fb1031-souhaila' of github.com:molecula/featurebase into fb1031-souhaila 2021-12-02 14:01:06 -06:00
Souhaila Noor
64b31da4a1 resolved duplicated line 2021-12-02 14:00:51 -06:00
souhailanoor
0189b2eef7
Merge branch 'master' into fb1031-souhaila 2021-12-02 13:11:19 -06:00
Souhaila Noor
b5ba3fb2ea added auth arg validation and set up auth package 2021-12-02 13:09:13 -06:00
Seebs
8b20406f45 experiment: handle errors more gracefully, but don't stream CreateKeys
We were trying to write an error to a ResponseWriter After attempting to
write to it, and this produces messages about superfluous WriteHeaders,
which is correct. This patch changes things so that we report messages
more clearly and verbosely if we hit them before writing, and if we try
to write and fail, we log the message because that's all we can do.

This does change semantics slightly, in that now we're marshalling
separately from trying to write the marshalled data. I think this is
probably a reasonable call because it lets us get diagnostics about a
hypothetical encoding problem, but in practice I don't think there
should be any encoding problems. So my guess is the actual error will
occur in that last line, and be logged to the server console instead
of failing to write over HTTP.

Also note that this changes some of the messages to include the
underlying error they're complaining about.

We also merge the create/find and index/field cases because only a
couple of lines of code changed between four largeish functions,
and we test some of the failure cases.

We don't have test coverage on the "field isn't provided" type things
because the mux won't actually route things there without them, so
far as I know.
2021-12-01 11:06:54 -06:00
tgruben
73f3c01284
Merge pull request #1790 from molecula/tgruben-patch-1 2021-11-30 21:34:27 -06:00
tgruben
740f3e2838
Merge branch 'master' into tgruben-patch-1 2021-11-30 18:48:41 -06:00
Souhaila Noor
dc1c39fd21 updated featurebase.conf 2021-11-29 16:46:55 -06:00
seebs
21f2868175
Merge pull request #1785 from molecula/sanitycheck
Perform sanity check only if we have the storage it runs on
2021-11-29 09:58:55 -06:00
Souhaila Noor
28e1be7540 added AuthN/AuthZ parameters to featurebase server configuration 2021-11-29 09:40:05 -06:00
tgruben
8b7d429417
Update README.md 2021-11-29 09:18:44 -06:00
souhailanoor
0bcac33313
Merge branch 'master' into sanitycheck 2021-11-24 08:31:13 -06:00
souhailanoor
42f3b79640
Merge pull request #1786 from molecula/fixBugInCicdPipeline
remove duplicate code in multiple stages of gitlab yml for CICD
2021-11-24 08:30:54 -06:00
Souhaila Noor
65c4fc9cdb updated error messages 2021-11-23 20:28:14 -06:00
Souhaila Noor
02b0f4ffd6 test standard condition 2021-11-23 18:50:47 -06:00
Souhaila Noor
0e2d71c303 added error handling 2021-11-23 18:48:06 -06:00
Souhaila Noor
6172f98eab test failed condition 2021-11-23 18:32:09 -06:00
Souhaila Noor
001678386f define ip var 2021-11-23 17:27:57 -06:00
Souhaila Noor
42b6c2b351 updated syntax 2021-11-23 17:25:10 -06:00
Souhaila Noor
afb96f4a9b pass error back to gitlab runner 2021-11-23 17:17:13 -06:00
Souhaila Noor
b243f4b8a3 fix yaml error 2021-11-23 17:10:13 -06:00
Souhaila Noor
d13eef4c4b echo errors 2021-11-23 17:09:35 -06:00
Souhaila Noor
612e11887f added dependency 2021-11-23 16:41:35 -06:00
Souhaila Noor
88c89749af updated job's stage 2021-11-23 16:37:11 -06:00
Souhaila Noor
f03720f0a3 error handling 2021-11-23 16:33:32 -06:00
Souhaila Noor
2de7d2c885 fixed yaml syntax error 2021-11-23 16:26:09 -06:00
Souhaila Noor
0030e759da removed aws config from shell script 2021-11-23 16:24:56 -06:00
Souhaila Noor
d781dfb29b remove error handling to debug 2021-11-23 16:18:14 -06:00