Jason E. Aten
bf36f54b8d
take a mutex off the fast path of TxFactory.NewTx
2020-11-04 01:04:04 +00:00
tgruben
40a773b839
Merge pull request #1068 from jaten-molecula/qcx_gettx_error
...
qcx.GetTx returns an error
2020-11-03 18:34:24 -06:00
Jason E. Aten
6aadd13095
qcx.GetTx returns an error
...
- to indicate that the query context is already
done.
- handles the case where the import worker is
interrupted early by a ctx cancellation,
thus avoiding a panic.
2020-11-04 00:01:02 +00:00
Ben Johnson
06cb04f87a
Merge pull request #1052 from molecula/fix-wal-not-found
...
Fix RBF WAL ID panic.
2020-11-03 11:16:33 -07:00
Ben Johnson
731a1ef25e
Refactor RBF WAL to only only checkpoint-in-full.
2020-11-03 10:41:31 -07:00
Ben Johnson
ea3732fa62
Fix WAL ID not found panic.
...
This commit changes the checkpointing to determine a minimum WAL ID
for readers and a max ID based on the writer. Pages are checkpointed
from the WAL up to the writer's max WAL ID but segments are removed
only up to the reader's minimum WAL ID. This ensures that WAL pages
are not removed out from under current read transactions.
2020-11-03 10:41:31 -07:00
Ben Johnson
c47b49a06e
Merge pull request #1053 from molecula/increase-rbf-wal-write-cache
2020-11-03 07:37:05 -07:00
Ben Johnson
db74f0dffa
Increase RBF WAL write cache size to 1MB.
...
Previously we dropped the cache size to 64KB but that seems much
too low. Write performance suffers considerably.
2020-10-30 17:09:33 -06:00
Matthew Jaffee
3ff85ccb53
Merge pull request #1051 from molecula/default-txn-bolt-fix-ci
...
default to Bolt txn due to CI failures blocking other team
2020-10-30 15:01:57 -05:00
Matt Jaffee
83dd8026d5
default to Bolt txn due to CI failures blocking other team
...
Our nightly CI has been failing for a week due to WAL issues and it's
making it difficult for Kuba and Antonio to do things on the
integration repo. Hoping bolt backend will solve that in the short
term. I think the issue is Pilosa #1046 (that's from memory though)
2020-10-30 13:55:36 -05:00
Ben Johnson
bb5153a7c1
Merge pull request #1049 from molecula/rbf-cli-help
...
Improve RBF CLI help
2020-10-30 08:38:14 -06:00
Ben Johnson
d5369a084e
Improve RBF CLI help
2020-10-30 07:25:36 -06:00
tgruben
f446eee088
Merge pull request #1048 from jaten-molecula/delete_empty
...
DeleteEmptyContainer true by default now
2020-10-30 06:30:09 -05:00
Jason E. Aten
9c66cd5a81
DeleteEmptyContainer true by default now
2020-10-30 04:15:53 +00:00
tgruben
4113a3d85b
Merge pull request #933 from molecula/qcx_no_auto_reset
...
pilosa: no automatic reuse of Qcx
2020-10-29 20:03:42 -05:00
Jason Aten
016e5e0774
no automatic reuse of Qcx
...
Per slack discussion with Seebs and Nia,
we'll try not automatically resetting the Qcx.
The worry was that our goroutine shutdown
management is so poor that we are asking for
GetTx on a goroutine that still has a Qcx
from a query that was cancelled.
If this is the case, we will now panic instead of
issuing a new Tx. Then we can fix the poor
goroutine management.
- also require Qcx.Finish or Abort before Reset
2020-10-30 00:36:46 +00:00
tgruben
51c9f4feeb
Merge pull request #1044 from jaten-molecula/startup_shards
...
don't apply startup shard cache to roaring with a specified view path
2020-10-29 18:24:57 -05:00
Jason E. Aten
18e253870e
cleanup TypedDBPerShardGetShardsForIndex logic
2020-10-29 22:25:06 +00:00
Jason E. Aten
f8e7b27a6f
don't apply startup shard cache to roaring with a specified view path
...
- avoids creating a new empty 8 byte shard file under all the
views that don't have them already.
2020-10-29 22:09:55 +00:00
tgruben
ed6f59a827
Merge pull request #1042 from jaten-molecula/migration_logging
...
better migration logging
2020-10-29 04:38:53 -05:00
Jason E. Aten
2d55ffbd28
short circuit if no data to migrate
2020-10-29 02:44:22 +00:00
Jason E. Aten
d4df15721d
allow migration of empty to empty
2020-10-29 02:41:09 +00:00
Jason E. Aten
aa47cf5bf4
fix verify test
2020-10-29 02:35:38 +00:00
Jason E. Aten
0e354aedf2
error expected trying to migration to roaring
2020-10-29 02:29:57 +00:00
Jason E. Aten
f9f94aab0d
fix typo
2020-10-29 02:15:43 +00:00
Jason E. Aten
bceabc9127
error on un-implemented migrate to roaring
2020-10-29 02:11:28 +00:00
Jason E. Aten
3baa8ea0f6
check if roaring data present with RoaringHasData
2020-10-29 01:47:26 +00:00
Jason E. Aten
639e9b3bf0
quiet
2020-10-29 01:32:04 +00:00
Jason E. Aten
6e20e6439f
more logging
2020-10-29 01:30:16 +00:00
Jason E. Aten
b1ff3791b8
better error when green does not exist on migration
2020-10-29 01:20:41 +00:00
Jason E. Aten
85fc785296
timed progress
2020-10-29 01:12:19 +00:00
Jason E. Aten
509348260f
better migration logging
2020-10-28 22:54:58 +00:00
Ben Johnson
e332f6fd7e
Merge pull request #1018 from molecula/rbf-cli
2020-10-28 06:26:27 -06:00
jaten-molecula
6386587f12
Merge branch 'master' into rbf-cli
2020-10-28 05:35:43 -05:00
jaten-molecula
9d233c4849
Merge pull request #1040 from jaten-molecula/rowcache_lock
...
pilosa: write lock the fragment when rowcache used
2020-10-27 20:11:10 -05:00
Jason E. Aten
062bd5c8c7
pilosa: write lock the fragment when rowcache used
...
- only allocate the rowcache if it is in use (avoid allocation per fragment)
- when the rowcache is use, fragment.go intRowIterator must write lock the
fragment because the f.rowCache will be updated.
- eliminate unused bitmapCache interface to keep the linter happy.
- fixes #1035
2020-10-28 00:53:38 +00:00
jaten-molecula
1784384153
Merge pull request #1039 from jaten-molecula/rbf_logging
...
pilosa server --rbf-checkpoint-dur to 0 by default
2020-10-27 18:19:04 -05:00
Jason E. Aten
1ca8a45357
pilosa server --rbf-checkpoint-dur to 0 by default
...
- we return to checkpointing after every commit, by default.
- the internal rbf logic is not ready to have
checkpoints deferred. Doing so results in
references to WAL segments that are not
in the current slice of live segments.
2020-10-27 22:38:18 +00:00
jaten-molecula
c9912e3607
Merge branch 'master' into rbf-cli
2020-10-27 15:03:43 -05:00
Cody Soyland
7855cd4d21
Merge pull request #1038 from jaten-molecula/dockerfile_go1.14.10
...
use go1.14.10 for now because of https://github.com/molecula/pilosa/issues/1036
2020-10-27 14:04:03 -05:00
Jason E. Aten
24bd1543f3
Makefile to go1.14.10
2020-10-27 18:07:13 +00:00
Jason E. Aten
2fb53b982a
update .circleci/config.yml to use go1.14.10
2020-10-27 18:00:15 +00:00
Jason E. Aten
03f24303d7
use go1.14.10 for now because of https://github.com/molecula/pilosa/issues/1036
2020-10-27 17:44:53 +00:00
Jason E. Aten
85f3fa9836
merge with the update to rbf to take a Config parameter
2020-10-27 15:11:45 +00:00
jaten-molecula
4543237e09
Merge branch 'master' into rbf-cli
2020-10-27 10:09:24 -05:00
jaten-molecula
305f81a310
Merge pull request #1034 from jaten-molecula/rbf_checkpoint_rb
...
performance tuning: rbfcfg package, binary search for wal segment
2020-10-27 10:07:47 -05:00
Ben Johnson
2b1d790625
Fix tree key formatting; add --with-tree option
2020-10-27 08:24:56 -06:00
Ben Johnson
7fa1a5edd2
Add RBF CLI commands
2020-10-27 08:12:22 -06:00
Jason E. Aten
957cba1768
performance tuning: rbfcfg package, binary search for wal segment
...
- rbfcfg package holds Config for --rbf- command line flags
- wal.go: replace linear search with bisection for wal segment
2020-10-27 00:49:56 +00:00
jaten-molecula
14cb29ea7d
Merge pull request #1024 from jaten-molecula/avoid_excessive_directory_scans
...
pilosa: avoid re-scanning shards during holder open
2020-10-23 20:31:05 -05:00