Seebs
2c6eb66895
check for slightly fewer errors
...
json.Decoder.Decode() can yield io.EOF which is not actually an
error. This appears to have caused a number of indirect test failures
by making ImportRoaring generally report failure.
2019-04-16 12:07:18 -05:00
Seebs
d5907b2a2e
lint fixes to cluster behavior in utils test
...
This is more lint fixes, but it's less obvious to me what the
right handling for errors is, or whether disregarding them is
safe, so it's a separate commit.
2019-04-16 12:07:18 -05:00
Seebs
77d49ded64
so much lint
...
So with the switch to a new linter, we get a lot of new warnings,
and the majority of them are harmless probably, but a few might be
real. Variously just use _ to suppress warnings, or report errors.
There's probably things here that deserve better fixes, but we can
always revisit it.
2019-04-16 12:07:18 -05:00
Seebs
20a8c48552
boltdb/attrstore.go: fix up lint about error checking
...
There's two kinds of unchecked errors here. Writes to a hash
(we don't care, hash functions usually don't error in ways we
care about), and rollbacks of non-writing transactions to a
database. After studying the boltdb docs, I concluded that
the recommended solution is to use the `.View(...)` function
instead of directly controlling the transaction, so I switched
the functions to do that.
2019-04-16 12:06:28 -05:00
Seebs
3070c2d4ac
try suppressing modules for golangci-lint
2019-04-16 12:06:28 -05:00
Seebs
d491724461
don't go get -u for golangci-lint
...
golangci-lint is actually dependent on a specific not-quite
most recent version of golang.org/x/tools, fixing the dependency
is hard and requires changing one of the upstream packages,
just omitting the `-u` lets golangci-lint grab the version it
wants and use that.
2019-04-16 12:06:28 -05:00
Cody Soyland
d84fcb09e7
Workaround due to write permission to bin directory
...
Pro tip: If you're gonna curl|bash, at least don't curl|sudo bash.
2019-04-16 12:06:28 -05:00
Cody Soyland
258646a7d5
Add golangci-lint to Makefile and CI config
2019-04-16 12:06:28 -05:00
Matthew Jaffee
099dc2d4f3
Merge pull request #1944 from jaffee/update-memberlist
...
update to latest memberlist fork with race fixes
2019-04-16 10:32:14 -05:00
Matt Jaffee
53aac3b17a
update to latest memberlist fork with race fixes
2019-04-16 09:56:40 -05:00
Matthew Jaffee
ffec2696c8
Merge pull request #1943 from jaffee/error-context
...
return orig error instead of cause in handler
2019-04-15 11:44:24 -05:00
Matt Jaffee
2414c71812
goimports
2019-04-15 11:15:11 -05:00
Matt Jaffee
27ff1b69c6
fix error messages in test. Fatalf=>Errorf to see more errors.
2019-04-15 08:41:13 -05:00
Matt Jaffee
f8a8a5d096
return orig error instead of cause in handler
...
also include the invalid name when erroring that a name is invalid.
2019-04-12 21:28:30 -05:00
Cody Soyland
000c188682
Merge pull request #1941 from codysoyland/pr-template-changelog
...
Add changelog steps to PR template
2019-04-12 14:11:31 -05:00
Cody Soyland
357f0bbf8c
Add changelog steps to PR template
2019-04-12 13:47:40 -05:00
Cody Soyland
140c26ceec
Merge pull request #1940 from codysoyland/license-headers
...
Add license headers and CI check
2019-04-12 13:24:55 -05:00
Cody Soyland
b8ab44eb62
Fix enterprise license header and add shardwidth files to license header check
2019-04-12 11:57:28 -05:00
Cody Soyland
3c1d3e3145
Use bash for check-license-headers target
2019-04-12 11:35:42 -05:00
Cody Soyland
fdbfc68f7c
Add license headers to files missing them and CI check to verify they are present. Fixes #1633
2019-04-12 11:30:41 -05:00
Matthew Jaffee
713dbb60ad
Merge pull request #1921 from jaffee/shardwidth22
...
add support to modify shard width at build time
2019-04-11 11:20:31 -05:00
Cody Soyland
7ede65bf80
Merge branch 'master' into shardwidth22
2019-04-11 10:10:47 -05:00
Travis Turner
980517962f
Merge pull request #1938 from travisturner/duplicate-pql-args
...
validate (and panic) on duplicate PQL arguments
2019-04-11 09:02:19 -05:00
Travis Turner
02b1f4ae0b
Merge branch 'master' into duplicate-pql-args
2019-04-11 08:39:56 -05:00
Yuce Tekol
61c28d1de4
Merge pull request #1934 from yuce/doc-update
...
Updated import and client libraries docs
2019-04-11 10:22:27 +03:00
Travis Turner
bdc4f3b07e
recover the duplicate arg panic from parser, treat as error
2019-04-10 23:48:17 -05:00
Yuce Tekol
4df4375db0
Merge branch 'master' into doc-update
2019-04-11 06:16:06 +03:00
Travis Turner
5f079163cb
validate (and panic) on duplicate PQL arguments
2019-04-10 16:34:30 -05:00
Cody Soyland
c4e5b1f434
Merge pull request #1936 from codysoyland/query-response-content-type
...
Add correct content type to query responses. Fixes #1873
2019-04-10 16:16:19 -05:00
Cody Soyland
7bb6fdffcb
Add correct content type to query responses. Fixes #1873
2019-04-10 15:49:33 -05:00
Cody Soyland
8041a9fa5f
Merge pull request #1937 from codysoyland/empty-query-response
...
Return empty result set when query empty. Fixes #1840
2019-04-10 15:48:16 -05:00
Cody Soyland
992a075cfb
Return empty result set when query empty. Fixes #1840
2019-04-10 15:27:12 -05:00
Yuce Tekol
b973f8c963
Merge pull request #1935 from yuce/doc-example-update
...
Updated examples section
2019-04-10 19:27:49 +03:00
Yuce Tekol
1e7208d60f
the
2019-04-10 17:25:21 +03:00
Yuce Tekol
2fd6287222
recommend
2019-04-10 17:20:02 +03:00
Yuce Tekol
73cc49770c
suggest client libraries for import
2019-04-10 17:17:55 +03:00
Yuce Tekol
cc4de71473
updated examples section
2019-04-10 17:14:47 +03:00
Yuce Tekol
b95f739b07
Updated import and client libraries docs
2019-04-10 15:07:07 +03:00
Matthew Jaffee
55a6fe1eef
Merge pull request #1932 from jaffee/memberlist-fork
...
replace memberlist dep with patched fork
2019-04-08 12:24:01 -05:00
Matt Jaffee
09e4e20915
replace memberlist dep with patched fork
...
fixes (hopefully) race condidtion which plagues our CI builds
2019-04-08 08:53:03 -05:00
Matthew Jaffee
2c4f4d7d63
Merge pull request #1931 from jaffee/1919-cluster-race
...
address race condition by getting cluster nodes with lock
2019-04-06 11:11:49 -05:00
Matt Jaffee
7b436a4e30
remove now-unused cluster.status method
2019-04-06 09:46:39 -05:00
Matt Jaffee
79968e5d2f
fix unlocked access to cluster.nodes
2019-04-05 15:40:25 -05:00
Matt Jaffee
d5cfe880f7
address race condition by getting cluster nodes with lock
...
needed an unlocked version of sendsync for use within the cluster, so also
implemented that. Added a number of tests trying to reproduce the issue, but was
not able to. Not sure it's worth keeping the new tests.
2019-04-05 15:40:24 -05:00
Matthew Jaffee
b263d8ccdf
Merge pull request #1928 from jaffee/op-apply-simplify
...
simply setting list of values with *N methods
2019-04-05 16:39:55 -04:00
Matt Jaffee
bd085e0a21
simply setting list of values with *N methods
2019-04-05 14:08:11 -05:00
Matthew Jaffee
9f8d6f6b76
Merge pull request #1930 from jaffee/1843-range-bug
...
add parser rule to catch old-style Range query
2019-04-05 09:33:32 -04:00
Matt Jaffee
55d9d49f2f
add executor test for deprecated range query style
2019-04-05 07:52:25 -05:00
Matt Jaffee
5458a42ad0
add parser rule to catch old-style Range query
2019-04-04 19:46:02 -05:00
Matt Jaffee
811f1b4124
move build-tagged shardwidth files to subpackage
2019-04-04 14:27:52 -05:00
