Commit graph

5570 commits

Author SHA1 Message Date
Travis Turner
198a2910f2
set cache size to 0 if cache type is none 2019-01-25 14:51:00 -06:00
tgruben
f3941f5aa1
Merge pull request #1761 from tgruben/shift-op
Shift operator
2019-01-25 14:21:25 -06:00
Travis Turner
113c6998be
add Shift() to query docs 2019-01-25 14:08:49 -06:00
Travis Turner
779f89815d
Merge branch 'master' into shift-op 2019-01-25 12:57:51 -06:00
Travis Turner
8fe966e8a0
Modifying some of the logic around Shift()
add some comments to the shift() logic
improve test coverage
fix full bitmap overflow
add support to specify shift-by amount
2019-01-25 12:54:44 -06:00
Travis Turner
636513f843
Merge pull request #1832 from travisturner/advertise-addr
support advertise address and listen on 0.0.0.0
2019-01-24 18:12:16 -06:00
Travis Turner
cd7d4ecc22
Merge branch 'master' into advertise-addr 2019-01-24 17:55:51 -06:00
Matthew Jaffee
9880f0a20c
Update docs/configuration.md
Co-Authored-By: travisturner <travis@pilosa.com>
2019-01-24 17:55:25 -06:00
Travis Turner
2467d88ddc
Merge branch 'master' into shift-op 2019-01-24 13:56:28 -06:00
Travis Turner
96d61fe034
Merge pull request #1793 from WaaX/patch-3
Replaced seed with seeds
2019-01-24 09:34:07 -06:00
Travis Turner
fa975411b7
change seeds examples from string to list 2019-01-24 09:20:01 -06:00
WaaX
8062fc6ea7
Replaced seed with seeds
Cluster config referred to seed but the server now expects seeds
2019-01-24 09:17:43 -06:00
tgruben
923e67959c
Merge pull request #1839 from tgruben/numbytes
added convenience function to efficiently calculate size of a roaring bitmap in bytes
2019-01-23 18:04:18 -06:00
Todd Gruben
c2ca00ebe8 force bitmap creation on test; for real this time 2019-01-23 17:05:40 -06:00
Todd Gruben
cb08749967 correct bitmap test 2019-01-23 16:47:59 -06:00
Todd Gruben
4436bce943 Merge branch 'numbytes' of github.com:tgruben/pilosa into numbytes 2019-01-23 13:50:40 -06:00
Todd Gruben
790123410f metalinter fix 2019-01-23 13:50:01 -06:00
tgruben
374caa4746
Merge branch 'master' into numbytes 2019-01-23 13:36:35 -06:00
Todd Gruben
15494becac formatting 2019-01-23 13:35:27 -06:00
Todd Gruben
374fc9deff added convience function to calculate size of bitmap in bytes
completed test converage
2019-01-23 13:30:41 -06:00
Travis Turner
e15f054075
update docs for advertise, gossip.advertise-host, gossip.advertise-port 2019-01-22 14:22:39 -06:00
Travis Turner
efb9f97e61
Advertise address and listen on 0.0.0.0
This commit adds support for advertise address by using a new config
option `advertise`, or by defaulting its value to that
specified in `bind`.

Also adds support for listening on 0.0.0.0 by trying to determine
the preferred outbound IP to use for the advertise address.
2019-01-21 22:36:55 -06:00
Matthew Jaffee
b86f0c677d
Merge pull request #1831 from jaffee/bench-temp-dir
make sure more tests and benchmarks can have their temp dir set by flag
2019-01-21 16:44:54 -06:00
Matt Jaffee
b7973b75f1
get rid of init 2019-01-21 16:23:28 -06:00
Matt Jaffee
04c7ab5034
add nolint for init 2019-01-21 16:23:27 -06:00
Matt Jaffee
fe7b926773
make sure more tests and benchmarks can have their temp dir set by flag
This is to allow the directory to be set to where a particular disk is mounted
during benchmarking.
2019-01-21 16:23:27 -06:00
Matthew Jaffee
1c470e4c10
Merge pull request #1834 from seebs/seebs/deadlock
prevent deadlock in replication logic on reopening a store
2019-01-21 16:21:46 -06:00
Matthew Jaffee
3bbd3cbfb1
Merge branch 'master' into seebs/deadlock 2019-01-21 15:33:41 -06:00
Matthew Jaffee
7b8589bdab
Merge pull request #1835 from jaffee/log-nil-fix
pass loggers around properly in gossip
2019-01-21 15:33:22 -06:00
Matt Jaffee
bb9f3a95d2
move legacy field check to non-concurrent code 2019-01-21 15:17:33 -06:00
Matt Jaffee
44270fe9fd
rename memberlist.logger and add explanatory comments 2019-01-21 14:47:02 -06:00
Matt Jaffee
6f4dee5e31
pass loggers around properly in gossip 2019-01-21 14:47:02 -06:00
Matthew Jaffee
36c38808f4
Merge pull request #1837 from jaffee/staticcheck-fixes
Staticcheck fixes (lint)
2019-01-21 14:46:23 -06:00
Matt Jaffee
20e06b7b0f
fix direct usage of std log instead of configured logger 2019-01-21 14:39:24 -06:00
Matt Jaffee
f1ecead069
fix failing tests due to staticcheck fixes 2019-01-21 14:38:58 -06:00
Matt Jaffee
daa87d8e12
fix staticcheck warnings 2019-01-21 14:24:11 -06:00
Yuce Tekol
d0f7115c91
Merge pull request #1830 from yuce/1805-rows-call-format
Fixes #1805. Fixes Store call error messages
2019-01-21 22:31:43 +03:00
seebs
7961f87430
Merge branch 'master' into seebs/deadlock 2019-01-21 13:31:21 -06:00
Yuce Tekol
b898460a18
Merge branch 'master' into 1805-rows-call-format 2019-01-21 18:35:05 +03:00
Yuce Tekol
1d3fafa207
trivial 2019-01-21 18:32:58 +03:00
Travis Turner
2e6635ec6d
Merge pull request #1836 from travisturner/cluster-nodes-rlock
cluster.Nodes() just needs a read lock
2019-01-21 09:30:50 -06:00
Yuce Tekol
511f7de422
added staticcheck to gometalinter target 2019-01-21 18:29:42 +03:00
Yuce Tekol
7531c337a9
removed megacheck from metalienter target 2019-01-21 18:23:40 +03:00
Yuce Tekol
21c0a5e3de
Merge branch 'master' into 1805-rows-call-format 2019-01-21 18:03:50 +03:00
Yuce Tekol
773d661b68
GroupBy legacy Rows 2019-01-21 18:02:51 +03:00
Travis Turner
fc1de2dba9
cluster.Nodes() just needs a read lock 2019-01-18 14:49:58 -06:00
Seebs
cd534af430 prevent deadlock in replication logic on reopening a store
Depending on where in the replicate() loop you are when a
store is closed or reassigned, it's possible for it to deadlock.
The deadlock would be that replicate has just successfully read an
entry from your PrimaryTranslateStore.Reader, when a new
PrimaryTranslateStore event happens. Then handlePrimaryTranslateStore
grabs the mutex, signals that the replication handler should
close, and waits for the replication handler to close. Meanwhile,
the replicate() loop tries to grab the mutex... and deadlocks.

Solution: Make the replicate() loop part that needs the mutex
a goroutine that signals on a channel, so we can put it in a select
along with checking for the replicationClosing signal (or the
context terminating). If one of those happens, replicate()
terminates, allowing monitorReplication() to return, which
causes the anonymous function which called it to call
repWG.Done(), allowing handlePrimaryTranslateStore to continue
and eventually release the mutex. At some later point, appendEntry
succeeds or fails, dumps its result status in a buffered
channel, and exits, and the buffered channel is garbage collected.

This is way simpler than it sounds, but it took me a while
to figure out how simple it was.
2019-01-18 13:24:24 -06:00
seebs
8762c2a4dc
Merge pull request #1763 from seebs/seebs/bench
improve  sliceascending/slicedescending benchmarks.
2019-01-18 09:17:00 -06:00
Yuce Tekol
ca7dc073ab
Merge branch 'master' into 1805-rows-call-format 2019-01-18 17:48:58 +03:00
Yuce Tekol
5fb82ac7b3
Rows sets _field if field is set 2019-01-18 17:46:20 +03:00