scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-09-06 00:25:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

tweak comment, add validation TODO

Browse source
This commit is contained in:
Matt Jaffee 2020-04-21 21:11:52 -05:00
parent afcb3e7f96
commit 7da137277c
No known key found for this signature in database
GPG key ID: 08A3DFFF987B11BF
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
transaction.go
View file

@ -134,7 +134,7 @@ func (tm *TransactionManager) Start(ctx context.Context, id string, timeout time
return trns, errors.Wrap(err, "adding to store")
}
// we won't check deadlines unless there's actually an exclusive
// we won't check deadlines unless there's actually a
// transaction pending
if exclusive && !active {
tm.startDeadlineChecker()

1
transaction.md
View file

@ -169,6 +169,7 @@ goes through API (and is passed directly to Server). (unimplemented)
- [ ] update go-pilosa/gpexp to actually USE transactions
- [ ] update IDK to use updated go-pilosa
- [ ] external testing with e.g. curl
- [ ] validate incoming transaction IDs
- ID validation. No slashes, no non-URL safe chars