From 7da137277c345474e168c8faa500b66ce350cccd Mon Sep 17 00:00:00 2001 From: Matt Jaffee Date: Tue, 21 Apr 2020 21:11:52 -0500 Subject: [PATCH] tweak comment, add validation TODO --- transaction.go | 2 +- transaction.md | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/transaction.go b/transaction.go index 299d3d134..1ad3077de 100644 --- a/transaction.go +++ b/transaction.go @@ -134,7 +134,7 @@ func (tm *TransactionManager) Start(ctx context.Context, id string, timeout time return trns, errors.Wrap(err, "adding to store") } - // we won't check deadlines unless there's actually an exclusive + // we won't check deadlines unless there's actually a // transaction pending if exclusive && !active { tm.startDeadlineChecker() diff --git a/transaction.md b/transaction.md index aeefad8bc..86c2c54dc 100644 --- a/transaction.md +++ b/transaction.md @@ -169,6 +169,7 @@ goes through API (and is passed directly to Server). (unimplemented) - [ ] update go-pilosa/gpexp to actually USE transactions - [ ] update IDK to use updated go-pilosa - [ ] external testing with e.g. curl +- [ ] validate incoming transaction IDs - ID validation. No slashes, no non-URL safe chars