scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-09-07 17:15:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #858 from niaow/deprecate-inspect

Browse source 
Add a deprecation warning to Inspect
This commit is contained in:
Nia 2020-09-16 15:31:57 -04:00 • committed by GitHub
commit 16c5212e2d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
server/grpc.go
View file

@ -37,9 +37,10 @@ import (
// GRPCHandler contains methods which handle the various gRPC requests.
type GRPCHandler struct {
api *pilosa.API
logger logger.Logger
stats stats.StatsClient
api *pilosa.API
logger logger.Logger
stats stats.StatsClient
inspectDeprecated sync.Once
}
func NewGRPCHandler(api *pilosa.API) *GRPCHandler {
@ -375,6 +376,10 @@ func ToRowserWrapper(result interface{}) (pb.ToRowser, error) {
func (h *GRPCHandler) Inspect(req *pb.InspectRequest, stream pb.Pilosa_InspectServer) error {
const defaultLimit = 100000
h.inspectDeprecated.Do(func() {
h.logger.Printf("DEPRECATED: Inspect is deprecated, please use Extract() instead.")
})
index, err := h.api.Index(stream.Context(), req.Index)
if err != nil {
return errToStatusError(err)