add a deprecation warning to Inspect

This commit is contained in:
Nia Weiss 2020-09-16 12:30:12 -04:00
parent 75b01ba87d
commit f03ba0e682
No known key found for this signature in database
GPG key ID: 895E83409BFDA1BB

View file

@ -37,9 +37,10 @@ import (
// GRPCHandler contains methods which handle the various gRPC requests.
type GRPCHandler struct {
api *pilosa.API
logger logger.Logger
stats stats.StatsClient
api *pilosa.API
logger logger.Logger
stats stats.StatsClient
inspectDeprecated sync.Once
}
func NewGRPCHandler(api *pilosa.API) *GRPCHandler {
@ -375,6 +376,10 @@ func ToRowserWrapper(result interface{}) (pb.ToRowser, error) {
func (h *GRPCHandler) Inspect(req *pb.InspectRequest, stream pb.Pilosa_InspectServer) error {
const defaultLimit = 100000
h.inspectDeprecated.Do(func() {
h.logger.Printf("DEPRECATED: Inspect is deprecated, please use Extract() instead.")
})
index, err := h.api.Index(stream.Context(), req.Index)
if err != nil {
return errToStatusError(err)