mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-09-19 00:03:30 +00:00
1.9 KiB
1.9 KiB
The diff looks exactly right. Let me summarize all the changes made:
Summary of changes
1. lib/crates/fabro-daytona/src/lib.rs — Core refactor
- Added
GitCloneParamsstruct withurl: Stringandbranch: Option<String>fields, publicly exported - Changed
DaytonaSandboxfield fromclone_branch: Option<String>toclone_params: Option<GitCloneParams> - Updated
new()signature: last param changed fromclone_branch: Option<String>toclone_params: Option<GitCloneParams> - Updated
reconnect():clone_params: None(wasclone_branch: None) - Refactored
initialize():- Removed
let cwd = std::env::current_dir()— no longer reads the process-global cwd - Replaced
match detect_repo_info(&cwd)withif let Some(ref clone_params) = self.clone_params Somearm: usesclone_params.url/clone_params.branchdirectly (URL is already HTTPS from caller)elsearm: creates empty working directory (the oldErrarm logic)
- Removed
- Removed unused import
use fabro_github::ssh_url_to_https
2. lib/crates/fabro-cli/src/commands/run.rs — Production callers
- Main
runpath: ConstructsGitCloneParamsfromorigin_url(withssh_url_to_https) anddetected_base_branch, passes it toDaytonaSandbox::new() - Doctor path: Already passes
None— type changed fromOption<String>toOption<GitCloneParams>butNoneis valid for both
3. lib/crates/fabro-workflows/tests/daytona_integration.rs — Test fixes
create_env_with_github_app: Detects repo info withdetect_repo_info(&cwd)and buildsGitCloneParamsbefore callingnew(), preserving clone behavior for all tests that use this helperdaytona_computer_use_browser_screenshot: Removedtempfile::tempdir()andset_current_dir()— passesNoneas last arg which now cleanly means "skip clone"daytona_playwright_mcp_sandbox_transport: Same — removedtempfile::tempdir()andset_current_dir()