Commit graph

814 commits

Author SHA1 Message Date
Bryan Helmkamp
be23369d28 Indent subagent status lines deeper than tool calls in CLI progress
Subagent lines (▸ subagent[...], ✓ subagent[...]) now render at 8-space
indent instead of 6, visually distinguishing them as children of the stage.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-09 02:00:21 -04:00
Bryan Helmkamp
fc7ecde756 Add exe.dev cancellation, git cloning, and checkpointing support
- Wire up cancel_token in ExeSandbox::exec_command via tokio::select!
- Clone the local git repo into exe.dev VMs after initialization
- Add GitCredentialSandbox decorator for push credential refresh
- Enable GitCheckpointMode::Remote for exe.dev (rename daytona_* → remote_*)
- Rename setup_daytona_git → setup_remote_git (already sandbox-agnostic)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-09 01:54:49 -04:00
Bryan Helmkamp
e60c431a6b Fix clippy filter_next lint for Rust 1.94+
Replace `.filter(..).next_back()` with `.rfind(..)` to satisfy the
expanded `clippy::filter_next` lint on newer toolchains.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-09 01:49:53 -04:00
Bryan Helmkamp
ac0314de2c Support [pull_request] config in cli.toml
Allow setting pull_request.enabled in ~/.arc/cli.toml so auto-PR
works when running `arc run` with a .dot file (no run.toml needed).
Cascade precedence: run.toml > cli.toml > server.toml > defaults.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-09 01:35:31 -04:00
Bryan Helmkamp
bf8faf03b9 Remove preflight tests step from implement-and-simplify workflow
The cargo test preflight step is slow and unnecessary since the verify
step already runs tests after implementation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-09 00:28:28 -04:00
Bryan Helmkamp
dbf9a7413f Shorten token/tool labels in CLI output for brevity
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-09 00:27:57 -04:00
Bryan Helmkamp
f0ea4d2971 Fix pipe deadlock in local sandbox when child output exceeds 64KB
The old code called child.wait() before draining stdout/stderr pipes.
If the child wrote more than the OS pipe buffer, write() blocked while
the parent blocked on wait() — classic deadlock. Now we spawn concurrent
tasks to drain the pipes before waiting.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-09 00:12:20 -04:00
Bryan Helmkamp
7b6a2a93b7 Fix asset collection tests to provide required asset globs
The opt-in change (7400a9d5) left these two tests with empty asset_globs,
which now means "no asset collection". Add the matching glob so the tests
actually exercise asset collection.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 23:54:53 -04:00
Bryan Helmkamp
3100fd3a62 Add assets schema to OpenAPI spec for ServerConfiguration
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 23:50:57 -04:00
Bryan Helmkamp
a735225253 Add missing assets field to RunDefaults in openapi conformance test
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 23:44:59 -04:00
Bryan Helmkamp
7400a9d5a1 Make asset collection opt-in via [assets] config globs
Asset collection previously ran a full `find` scan before and after every
stage (~30s per scan), even when no assets were needed. This makes it
opt-in: only workflows with an `[assets] include = [...]` section in their
TOML config will run asset collection, and only with user-specified globs.

- Add AssetsConfig struct and wire through WorkflowRunConfig, RunDefaults,
  and RunConfig
- Remove baseline snapshot approach; single post-execution scan using
  user globs filtered by mtime and size budgets
- Delete hardcoded pattern constants, is_asset_candidate, matches_simple_glob,
  FileFingerprint, and snapshot() — replaced by configurable globs
- Skip all asset work when asset_globs is empty (zero overhead default)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 23:39:04 -04:00
Bryan Helmkamp
686d6bbdb0 Name Daytona sandboxes arc-{run_id} for easy correlation with workflow runs
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 23:01:44 -04:00
Bryan Helmkamp
11b9159534 Rename "tool calls" to "tools" in CLI progress output
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 22:58:45 -04:00
Bryan Helmkamp
96bcff05b3 Add duration_ms, node_visits, and base_branch to shadow branch structs
Enrich Outcome with stage duration, Checkpoint with persisted node visit
counts (avoiding fragile reconstruction on resume), and Manifest with the
base branch name for offline analysis without git lookups.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 22:57:32 -04:00
Bryan Helmkamp
e24d20b439 Update daytona-sdk-rust to 06033ca and apply clippy/fmt fixes
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 22:13:43 -04:00
Bryan Helmkamp
f30effaadd Truncate stage failure error display to last line in arc run output
The full failure message (including entire stdout/stderr) was shown inline,
making terminal output very noisy. Now only the last non-empty line is
displayed, truncated to 120 chars. The full error remains in the log file.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 22:12:54 -04:00
Bryan Helmkamp
9dd481b509 Use sudo to symlink cargo binaries into /usr/local/bin
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 21:35:39 -04:00
Bryan Helmkamp
ef09048b20 Add cargo env to ~/.profile so login shells pick it up
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 21:34:17 -04:00
Bryan Helmkamp
6470e4c034 Symlink cargo binaries into /usr/local/bin for all script nodes
Each script node runs in a fresh sh shell, so sourcing .cargo/env
in the toolchain node doesn't persist. Symlinking into /usr/local/bin
puts cargo, rustc, clippy etc. on the default PATH for every node.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 21:31:48 -04:00
Bryan Helmkamp
ad2c113b62 Fix toolchain script: source cargo env outside subshell
The `. $HOME/.cargo/env` was running inside a subshell so the PATH
change didn't persist to the subsequent `cargo --version` command.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 21:30:11 -04:00
Bryan Helmkamp
eff97202e4 Install Rust toolchain in sandbox if not already present
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 21:29:34 -04:00
Bryan Helmkamp
6694dbbeb9 Change logs dir naming from arc-run-YYYYMMDD-HHMMSS to YYYYMMDD-{run_id}
Embeds the ULID run_id directly in the directory name so logs dirs
can be easily correlated with runs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 21:24:15 -04:00
Bryan Helmkamp
6c6cc652a6 Route script nodes through sandbox instead of spawning on host
CommandHandler was using tokio::process::Command to execute scripts
directly on the host machine, completely bypassing the configured
sandbox (local, Daytona, Docker). This meant script nodes in workflows
ran on the host while agent nodes ran in the sandbox, causing fix cycles
where agents edited files in the sandbox but lint checks ran on the host.

Now delegates to services.sandbox.exec_command() so all node types
execute in the same environment.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 21:17:46 -04:00
Bryan Helmkamp
3ff0494caf Exempt /tmp/ paths from read-before-write guard
The ReadBeforeWriteSandbox was blocking engine writes to /tmp/arc-commit-msg
on the second git checkpoint because the file already existed from the first
checkpoint. Temp files don't need source-file protection.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 21:05:27 -04:00
Bryan Helmkamp
4e84560bed Regenerate TypeScript API client with new models and updated fields
Adds completion messages/tools, git author/webhook config, checkpoint,
log, pull request config, and sandbox env/exe support.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 20:57:36 -04:00
Bryan Helmkamp
9e35c4a472 Add GitCheckpointFailed event and align with logging/events strategy
- Add GitCheckpointFailed variant to WorkflowRunEvent with node_id and error fields
- Add trace() arm at ERROR level per logging strategy (operation cannot continue)
- Add rename_fields rule to default node_label from node_id
- Emit the event before returning ArcError::Engine on checkpoint failure
- Update events-strategy.md with the new event in the checkpoints table
- Add rename_fields serialization test

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 20:54:27 -04:00
Bryan Helmkamp
2620a43950 Fail workflow run on git checkpoint commit failure instead of silently continuing
The git checkpoint functions (host and remote) now return Result<String, String>
with descriptive error messages instead of Option<String>. When a checkpoint commit
fails, the engine returns ArcError::Engine with FailureClass::Deterministic,
stopping the run immediately. This prevents stuck cycles where an agent's edits
are silently lost between node transitions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 20:52:11 -04:00
Bryan Helmkamp
e5cfeaacaa Update OpenAPI spec and TS client for stream_event SSE format
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 20:50:51 -04:00
Bryan Helmkamp
83fb20cb3c Fix SSE streaming format mismatch in /completions endpoint
The server was emitting Anthropic-style SSE events (content_block_delta,
message_delta, etc.) but both consumers — the arc_server provider and
run_prompt_via_server CLI — expect `event: stream_event` with serialized
StreamEvent JSON payloads. This caused streaming to silently produce no
output in server mode.

Now forwards all StreamEvent variants directly (text, tool calls,
reasoning, etc.) instead of manually mapping a subset.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 20:47:55 -04:00
Bryan Helmkamp
041486400e Add toolchain check step before preflight in implement-and-simplify workflow
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 20:47:30 -04:00
Bryan Helmkamp
eb584b88c9 Show Run ID before Logs in arc run output
Generate the run ULID early and display it before the logs directory,
then pass it into setup_worktree and setup_daytona_git instead of each
generating their own.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 20:35:15 -04:00
Bryan Helmkamp
9fa088b1a9 Split preflight into compile/lint/test stages with lint auto-fix loop
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 20:33:09 -04:00
Bryan Helmkamp
801a3936b4 Fix clippy::single_match lint in arc-llm SSE event handler
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 20:29:39 -04:00
Bryan Helmkamp
105bdc04de Add e2e tests for arc exec against live LLM
Five new CLI-level tests covering file creation, shell execution,
read-only permission enforcement, JSON output format, and read+edit
multi-step tool use. All gated with #[ignore = "requires API key"].

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 20:26:52 -04:00
Bryan Helmkamp
d568306701 Add --goal-file CLI flag to arc run for reading goal from a file
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 20:18:49 -04:00
Bryan Helmkamp
dcc8020aac Replace commented-out Inception tests with #[cfg(feature = "quarantine")]
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 19:54:18 -04:00
Bryan Helmkamp
0f3931ae9f Fix daytona_asset_collection test to use current artifacts directory layout
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 19:51:42 -04:00
Bryan Helmkamp
28bd9616a8 Add e2e tests for ReadBeforeWriteSandbox through execute_and_emit_one_tool
Tests the full production path: execute_and_emit_one_tool → real tool executor
→ ReadBeforeWriteSandbox guard, covering write-blocked, read-then-write,
grep-then-write, edit-blocked, and new-file-allowed scenarios.

Also updates MutableMockSandbox::grep to do substring matching against
in-memory files so the grep integration test works end-to-end.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 19:50:38 -04:00
Bryan Helmkamp
d95a9acf77 Fix daytona_cli_claude OOM by using daytona-medium snapshot (2 vCPU / 4 GiB)
The Claude CLI native binary install was getting OOM-killed (exit 137)
in the default 1 GiB sandbox. Using the daytona-medium default snapshot
also pre-includes Node, making the prereq install step a no-op.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 19:34:15 -04:00
Bryan Helmkamp
f6284026b1 Fix codex CLI auth: use codex login --with-api-key for credentials
Codex CLI no longer reads OPENAI_API_KEY from the environment at
runtime. It requires `codex login --with-api-key` to store credentials
via its auth system. Add a login step after ensure_cli for codex.

Also pass API keys via exec_command's env_vars parameter as belt-and-
suspenders alongside the env file, to avoid fs-to-process race conditions
in the Daytona sandbox.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 19:22:41 -04:00
Bryan Helmkamp
dd9bed01e5 Improve CLI backend reliability and error diagnostics
- Use `cat file | command` instead of `command < file` for stdin piping
  to avoid redirect issues in nested shell wrappers
- Include both stdout and stderr in error messages when CLI exits non-zero
  (previously only showed stderr, hiding API errors in stdout)
- Install Node 20 via nodesource + bash/curl as prerequisites for CLI tests
- Use bash instead of sh for Claude CLI install script

The codex test still fails with 401 Unauthorized — the OPENAI_API_KEY
env var isn't reaching the codex process in the sandbox despite the env
file being sourced correctly (gemini works with the same mechanism).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 19:06:03 -04:00
Bryan Helmkamp
59c01d62fd Fix Daytona e2e test failures and improve test reliability
- Pass GitHub App credentials in create_env() and daytona_snapshot_sandbox
  so private repo clones succeed
- Install git in sandbox before running git CLI in clone_private_repo test
- Use brynary/arc (where app is installed) instead of rust-lang/rust for
  clone_public_repo_gets_credentials test
- Fix git_checkpoint_remote_emits_events assertion: expect 1 event (work
  node only) since start is skipped and exit breaks before checkpoint
- Install Node 20 via nodesource and bash/curl in CLI test prerequisites
- Use bash instead of sh for Claude CLI install script
- Shorten toolbox_idle_diagnostic sleep durations to finish in ~12s
- Add nextest config with 120s per-test timeout

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 18:51:43 -04:00
Bryan Helmkamp
7d503180bc Fix flaky multi-turn cache test by checking best ratio across all turns
Provider implicit caching (Gemini, OpenAI) is non-deterministic — cache
hits can occur on some turns but not others. Checking only the final turn
caused intermittent failures. Track the best cache ratio across all turns
instead, which still validates the adapter surfaces cached token counts.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 17:35:42 -04:00
Bryan Helmkamp
44dce81409 Fix e2e test failures and quarantine unreliable Inception provider
- Anthropic max_tokens: use model catalog limit instead of hardcoded 65536,
  fixing claude-sonnet-4-5 (max_output=64000) API errors
- OCI feature tgz: detect actual filename from registry instead of
  assuming devcontainer-feature.tgz (registries use suffixed names)
- Test LlmCodergenBackend: implement one_shot() for prompt handler support
- Quarantine all Inception/mercury-2 parity matrix tests (unreliable provider)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 17:24:55 -04:00
Bryan Helmkamp
36ad1606ee Update docs for tool-level hooks, server mode, and auto-PR
- hooks.mdx: add pre_tool_use/post_tool_use/post_tool_use_failure events,
  tool-specific context fields, matcher support for tool names
- cli.mdx: add --mode and --server-url flags to arc exec
- run-configuration.mdx: add [pull_request] section
- github.mdx: add auto-PR to features table

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 16:49:28 -04:00
Bryan Helmkamp
39b10b0a5a Update changelog for 2026-03-08 with hooks, server mode, and auto-PR
Regenerate the changelog entry to cover all commits since the last
watermark. Add changelog writing guideline to use user-facing language
instead of internal Rust names.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 16:45:30 -04:00
Bryan Helmkamp
7cfbe5f9d1 Add PreToolUse, PostToolUse, PostToolUseFailure Hooks (#6)
* arc(01KK739V1KPSQJT6E492ZWR95G): implement (success)

Arc-Run: 01KK739V1KPSQJT6E492ZWR95G
Arc-Completed: 2
Arc-Checkpoint: 52e0f637b3c802833c0c6eb7e2e8b56aef071441

* arc(01KK739V1KPSQJT6E492ZWR95G): simplify (success)

Arc-Run: 01KK739V1KPSQJT6E492ZWR95G
Arc-Completed: 3
Arc-Checkpoint: c1d6abe508b30b269d019961988212076064fb9e

* Merge main into PR branch: integrate MCP servers with server mode dispatch

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: arc <arc@local>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 16:40:02 -04:00
Bryan Helmkamp
7f264e44c1 arc exec server mode via /completions proxy (#4)
* arc(01KK6WHKW0XB829BBCXH5N5G03): implement (success)

Arc-Run: 01KK6WHKW0XB829BBCXH5N5G03
Arc-Completed: 2
Arc-Checkpoint: b394706ae5111891bed4c3c20290464410a8ff23

* arc(01KK6WHKW0XB829BBCXH5N5G03): simplify (success)

Arc-Run: 01KK6WHKW0XB829BBCXH5N5G03
Arc-Completed: 3
Arc-Checkpoint: fa9fabbe6016dd6bb795a4a1711792320aa4e1b2

---------

Co-authored-by: arc <arc@local>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 16:36:33 -04:00
Bryan Helmkamp
80fbeb5fcd Auto-PR on Successful Workflow Run (#3)
* arc(01KK6WHJ904CXGN0MCQFGWKMKS): implement (success)

Arc-Run: 01KK6WHJ904CXGN0MCQFGWKMKS
Arc-Completed: 2
Arc-Checkpoint: 4c3a9115be9074c7e23792c0ef9b1f0525ffc10d

* arc(01KK6WHJ904CXGN0MCQFGWKMKS): simplify (success)

Arc-Run: 01KK6WHJ904CXGN0MCQFGWKMKS
Arc-Completed: 3
Arc-Checkpoint: 7d8e8413e70eb198e14fcb676903dcc91bd21b76

* Fix merge conflicts: add pull_request to OpenAPI spec, fix clippy warning, cargo fmt

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: arc <arc@local>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 16:32:55 -04:00
Bryan Helmkamp
7f6f356bae TOML Config Format for MCP Servers (#2)
* arc(01KK6WHD2MEDZ0JVYTHEK9HFNF): implement (success)

Arc-Run: 01KK6WHD2MEDZ0JVYTHEK9HFNF
Arc-Completed: 2
Arc-Checkpoint: 25f71de745f9001a09e566706d62a6ac2ea6f827

* arc(01KK6WHD2MEDZ0JVYTHEK9HFNF): simplify (success)

Arc-Run: 01KK6WHD2MEDZ0JVYTHEK9HFNF
Arc-Completed: 3
Arc-Checkpoint: fed4325308110df4799171944ddb5170de59044c

* Fix Rust formatting

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: arc <arc@local>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 16:26:46 -04:00