scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-09-06 08:18:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

refactor(workflow): adopt Emitter::notice in git lifecycle

Browse source 
Replaces four inline Event::RunNotice {...} constructions with
emitter.notice(level, code, message). Matches the pattern adopted in
finalize, initialize, pull_request, and artifact lifecycle.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bryan Helmkamp 2026-04-24 10:38:13 -04:00
parent fab5477061
commit bc06e2dbd5
No known key found for this signature in database
1 changed files with 20 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
lib/crates/fabro-workflow/src/lifecycle/git.rs
View file

@ -163,37 +163,37 @@ impl RunLifecycle<WorkflowGraph> for GitLifecycle {
) {
Ok(sha) => Some(sha),
Err(e) => {
self.emitter.emit(&Event::RunNotice {
level: RunNoticeLevel::Warn,
code: "checkpoint_metadata_write_failed".to_string(),
message: format!(
self.emitter.notice(
RunNoticeLevel::Warn,
"checkpoint_metadata_write_failed",
format!(
"[node: {node_id}] metadata checkpoint write failed: {e}"
),
});
);
None
}
}
}
Err(e) => {
self.emitter.emit(&Event::RunNotice {
level: RunNoticeLevel::Warn,
code: "checkpoint_metadata_write_failed".to_string(),
message: format!(
self.emitter.notice(
RunNoticeLevel::Warn,
"checkpoint_metadata_write_failed",
format!(
"[node: {node_id}] metadata checkpoint serialization failed: {e}"
),
});
);
None
}
}
}
Err(e) => {
self.emitter.emit(&Event::RunNotice {
level: RunNoticeLevel::Warn,
code: "checkpoint_metadata_write_failed".to_string(),
message: format!(
self.emitter.notice(
RunNoticeLevel::Warn,
"checkpoint_metadata_write_failed",
format!(
"[node: {node_id}] failed to load run state for metadata snapshot: {e}"
),
});
);
None
}
}
@ -289,11 +289,11 @@ impl RunLifecycle<WorkflowGraph> for GitLifecycle {
}
Ok(_) => {}
Err(err) => {
self.emitter.emit(&Event::RunNotice {
level: RunNoticeLevel::Warn,
code: "git_diff_failed".to_string(),
message: format!("[node: {node_id}] git diff failed: {err}"),
});
self.emitter.notice(
RunNoticeLevel::Warn,
"git_diff_failed",
format!("[node: {node_id}] git diff failed: {err}"),
);
}
}