From bc06e2dbd572d1369949dd4eca1a6eabe6936f4a Mon Sep 17 00:00:00 2001
From: Bryan Helmkamp <bryan@brynary.com>
Date: Fri, 24 Apr 2026 10:38:13 -0400
Subject: [PATCH] refactor(workflow): adopt Emitter::notice in git lifecycle

Replaces four inline Event::RunNotice {...} constructions with
emitter.notice(level, code, message). Matches the pattern adopted in
finalize, initialize, pull_request, and artifact lifecycle.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 .../fabro-workflow/src/lifecycle/git.rs       | 40 +++++++++----------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/lib/crates/fabro-workflow/src/lifecycle/git.rs b/lib/crates/fabro-workflow/src/lifecycle/git.rs
index 457fa9a91..b0bf042bc 100644
--- a/lib/crates/fabro-workflow/src/lifecycle/git.rs
+++ b/lib/crates/fabro-workflow/src/lifecycle/git.rs
@@ -163,37 +163,37 @@ impl RunLifecycle<WorkflowGraph> for GitLifecycle {
                             ) {
                                 Ok(sha) => Some(sha),
                                 Err(e) => {
-                                    self.emitter.emit(&Event::RunNotice {
-                                        level:   RunNoticeLevel::Warn,
-                                        code:    "checkpoint_metadata_write_failed".to_string(),
-                                        message: format!(
+                                    self.emitter.notice(
+                                        RunNoticeLevel::Warn,
+                                        "checkpoint_metadata_write_failed",
+                                        format!(
                                             "[node: {node_id}] metadata checkpoint write failed: {e}"
                                         ),
-                                    });
+                                    );
                                     None
                                 }
                             }
                         }
                         Err(e) => {
-                            self.emitter.emit(&Event::RunNotice {
-                                level:   RunNoticeLevel::Warn,
-                                code:    "checkpoint_metadata_write_failed".to_string(),
-                                message: format!(
+                            self.emitter.notice(
+                                RunNoticeLevel::Warn,
+                                "checkpoint_metadata_write_failed",
+                                format!(
                                     "[node: {node_id}] metadata checkpoint serialization failed: {e}"
                                 ),
-                            });
+                            );
                             None
                         }
                     }
                 }
                 Err(e) => {
-                    self.emitter.emit(&Event::RunNotice {
-                        level:   RunNoticeLevel::Warn,
-                        code:    "checkpoint_metadata_write_failed".to_string(),
-                        message: format!(
+                    self.emitter.notice(
+                        RunNoticeLevel::Warn,
+                        "checkpoint_metadata_write_failed",
+                        format!(
                             "[node: {node_id}] failed to load run state for metadata snapshot: {e}"
                         ),
-                    });
+                    );
                     None
                 }
             }
@@ -289,11 +289,11 @@ impl RunLifecycle<WorkflowGraph> for GitLifecycle {
                     }
                     Ok(_) => {}
                     Err(err) => {
-                        self.emitter.emit(&Event::RunNotice {
-                            level:   RunNoticeLevel::Warn,
-                            code:    "git_diff_failed".to_string(),
-                            message: format!("[node: {node_id}] git diff failed: {err}"),
-                        });
+                        self.emitter.notice(
+                            RunNoticeLevel::Warn,
+                            "git_diff_failed",
+                            format!("[node: {node_id}] git diff failed: {err}"),
+                        );
                     }
                 }